From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ED8C2C3DA4A for ; Mon, 19 Aug 2024 16:14:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Subject:CC:To: From:Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=6buq1h5K54O0w6E7uT1mzUSAAbYtzZFTB2udTJHzxA8=; b=XdXtgHeO27ALhdwM6mCaoZfhvV 691XNBWx4ZSO/8PP/D9FKu0JKEXaxfmjtsOr4Jq3MtDySbFKbuSmwEQUHYRCL1joGGpB7b9AtGhpa ukPtoh5kCbbAdotFOJAooLlvz2hgSEk9TnvXRaPa/qRB41fgwZZiurjCb9Y/3mq/bJFqSJV/yxwHi Q0EPPyfe875X3i9aIOHKvqyZSQ0iHdTLLaZcvJ188KpayUoIHthrSiXEE+yQiDgYzphlp1Iw1fneK WBg/qWq/3bHzexNMVWwGirsnnOBenaMZJozfl7+KO3E52k9tu4qnPCb/WfhaRXdS1CXuf6DcI+zo9 SUJKc8MA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sg51B-0000000270Y-1bdI; Mon, 19 Aug 2024 16:14:05 +0000 Received: from frasgout.his.huawei.com ([185.176.79.56]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sg50T-000000026ps-2qOn; Mon, 19 Aug 2024 16:13:23 +0000 Received: from mail.maildlp.com (unknown [172.18.186.231]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4WncxM0V7Rz6J6jB; Tue, 20 Aug 2024 00:09:43 +0800 (CST) Received: from lhrpeml500005.china.huawei.com (unknown [7.191.163.240]) by mail.maildlp.com (Postfix) with ESMTPS id C9AC31400DB; Tue, 20 Aug 2024 00:13:15 +0800 (CST) Received: from localhost (10.203.177.66) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Mon, 19 Aug 2024 17:13:15 +0100 Date: Mon, 19 Aug 2024 17:13:13 +0100 From: Jonathan Cameron To: Krzysztof Kozlowski CC: Ulf Hansson , "Rafael J. Wysocki" , Daniel Lezcano , Anup Patel , Paul Walmsley , "Palmer Dabbelt" , Albert Ou , , , , Subject: Re: [PATCH 2/4] cpuidle: riscv-sbi: Use scoped device node handling to simplify error paths Message-ID: <20240819171313.00004677@Huawei.com> In-Reply-To: <20240816150931.142208-2-krzysztof.kozlowski@linaro.org> References: <20240816150931.142208-1-krzysztof.kozlowski@linaro.org> <20240816150931.142208-2-krzysztof.kozlowski@linaro.org> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.203.177.66] X-ClientProxiedBy: lhrpeml500004.china.huawei.com (7.191.163.9) To lhrpeml500005.china.huawei.com (7.191.163.240) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240819_091322_176194_930501CC X-CRM114-Status: GOOD ( 18.55 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 16 Aug 2024 17:09:29 +0200 Krzysztof Kozlowski wrote: > Obtain the device node reference with scoped/cleanup.h to reduce error > handling and make the code a bit simpler. > > Signed-off-by: Krzysztof Kozlowski The original code looks suspect. See below. > --- > drivers/cpuidle/cpuidle-riscv-sbi.c | 21 +++++++-------------- > 1 file changed, 7 insertions(+), 14 deletions(-) > > diff --git a/drivers/cpuidle/cpuidle-riscv-sbi.c b/drivers/cpuidle/cpuidle-riscv-sbi.c > index a6e123dfe394..5bb3401220d2 100644 > --- a/drivers/cpuidle/cpuidle-riscv-sbi.c > +++ b/drivers/cpuidle/cpuidle-riscv-sbi.c > @@ -8,6 +8,7 @@ > > #define pr_fmt(fmt) "cpuidle-riscv-sbi: " fmt > > +#include > #include > #include > #include > @@ -236,19 +237,16 @@ static int sbi_cpuidle_dt_init_states(struct device *dev, > { > struct sbi_cpuidle_data *data = per_cpu_ptr(&sbi_cpuidle_data, cpu); > struct device_node *state_node; > - struct device_node *cpu_node; > u32 *states; > int i, ret; > > - cpu_node = of_cpu_device_node_get(cpu); > + struct device_node *cpu_node __free(device_node) = of_cpu_device_node_get(cpu); > if (!cpu_node) > return -ENODEV; > > states = devm_kcalloc(dev, state_count, sizeof(*states), GFP_KERNEL); > - if (!states) { > - ret = -ENOMEM; > - goto fail; > - } > + if (!states) > + return -ENOMEM; > > /* Parse SBI specific details from state DT nodes */ > for (i = 1; i < state_count; i++) { > @@ -264,10 +262,8 @@ static int sbi_cpuidle_dt_init_states(struct device *dev, > > pr_debug("sbi-state %#x index %d\n", states[i], i); > } > - if (i != state_count) { > - ret = -ENODEV; > - goto fail; > - } > + if (i != state_count) > + return -ENODEV; > > /* Initialize optional data, used for the hierarchical topology. */ > ret = sbi_dt_cpu_init_topology(drv, data, state_count, cpu); The handling of error ret from here doesn't free the node. Bug or something subtle I'm missing? If it's a bug, then fixes tag. > @@ -277,10 +273,7 @@ static int sbi_cpuidle_dt_init_states(struct device *dev, > /* Store states in the per-cpu struct. */ > data->states = states; > > -fail: > - of_node_put(cpu_node); > - > - return ret; > + return 0; > } > > static void sbi_cpuidle_deinit_cpu(int cpu)