From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4A777C52D7C for ; Mon, 19 Aug 2024 17:45:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To: Content-Type:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=5ILepDaKOlPeVymJJ2CN29KDQrBQUcxBARCZLq4aLtA=; b=Apt67UT+M7vb4/2NpI1yylY2rR MjXIVpsWIQd4ali2BMEhj03TqLrOPjHbQmKP59Pt3jYKPg9Bm8b5x5MSiOON8AH7ODa858p7CgIAs 8LpgZ+iKeXRHRSQG/2IFWu8a6PqfwbUlkyZiKtf0N46Dfxml3qI9mXyFb6JVg+SCcjcuMJCFZ0fIE KNqgvX9dKMFN3KUx4H9m+9AW0jFMn8sMFBXyncITueuDS1Q1tSNNoDfH7YP1+6qckDNbh0cIqMl43 4g0OdHCXIB1hPBHN5Ka15+x2nu+afiObmiRrJ+yTqpGfYVzPG7oxbBMKmNpSysRl3uGx0rYxBDeXR KUF7ZllQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sg6R3-00000002RR9-2LCu; Mon, 19 Aug 2024 17:44:53 +0000 Received: from mail-mw2nam10on20620.outbound.protection.outlook.com ([2a01:111:f403:2412::620] helo=NAM10-MW2-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sg6Dj-00000002Pzw-3N1B for linux-arm-kernel@lists.infradead.org; Mon, 19 Aug 2024 17:31:09 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=LPizdUmLWDLq3BCu4zaj1btnlutpHxCsYxAwUHiB8GqixgtRRKEDyLNsUOttwrx8E33hijXQ01MTccaSmYPThc4ME3p1+8bheX9oOQCWjYjvHtG9C8uLpCepT1SdAXrBT9m6EZ0mNUHCeSFouGzK4cihk7HIWhZ+fLFcxQrB0IB0ew6T0+jP/REG2gN7Nl1RPWi35Ygf20ue9ippC4H6J9lJ09HxIJlC2o8fv4pjyyPHcqtt6wwqQa/78gWtpeGfte1ZlNIZy7Zto30ccz6ep/x7KhzXqAU1r0/4TQ/VsHpVHD514rRH1obgnAF0Fh1LsEWnyJbPDGV5plOAQ1xAVA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5ILepDaKOlPeVymJJ2CN29KDQrBQUcxBARCZLq4aLtA=; b=VYliKMyw3BQ9H3Lp5EUCJKe2QUr1o3gHqKo6Ljlb0qanmNMs1sPfjyhROjt3i2pVyaFqF4qLD3Ov3bZjWxqZHwyS+PQepehTG9Ai18/TKRvWRDM+rz7SCxOCBOzl9oPSb8qWg0/MUmxyHvcBswIOXn7A5r6ZsCCe0f+Ecupchm1mp9rcOLucsd2Iexe8Nm/NMTXZ5FzjmQFGzbpGgRoiFGQkhORcEkosmz4DQnqcHDRnK7u9ThULzfC75bfJAPGklIylNeozSD3J+kLqG5gDy1bUxOGq0/yUv9wHz6RhzmAVetKSZgDXGDCs2EXgCotRt0fcVJ5KMkw76MbvRfBR0g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5ILepDaKOlPeVymJJ2CN29KDQrBQUcxBARCZLq4aLtA=; b=Hktbs6RKlWlpMCMIWlGO9LDQubk3YT2w69DOOSbIQVzeixXcVtP/KGdqWsvrf2IXYBi8DKP5wwHvAkAcI6C/aUgNBC1DRluy3HINPkyWgoNdHxtpyBsKZSOzSQqMjDqfYM5x8422Gvtkdbx2uFYAbD0cLslp6A/VqISoV4BBGjDiZJutr7JerLBRA0eRh7ulnTAVpkN5G+KV5oEkV9voPLbNuYMknlENrp8ZxQwB+XSd8NYbSQTCe/7DsHIuR7gVWlf0ct6s3Yg5GH1hgvpc/tFry77J89U86fCJMj0kEe+eqp+q1f3cBvbiSKH/XAXzz/2PVQ1JX7nRBOpw5uW06w== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from CH3PR12MB7763.namprd12.prod.outlook.com (2603:10b6:610:145::10) by DM4PR12MB6230.namprd12.prod.outlook.com (2603:10b6:8:a7::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7875.21; Mon, 19 Aug 2024 17:30:58 +0000 Received: from CH3PR12MB7763.namprd12.prod.outlook.com ([fe80::8b63:dd80:c182:4ce8]) by CH3PR12MB7763.namprd12.prod.outlook.com ([fe80::8b63:dd80:c182:4ce8%3]) with mapi id 15.20.7875.019; Mon, 19 Aug 2024 17:30:58 +0000 Date: Mon, 19 Aug 2024 14:30:56 -0300 From: Jason Gunthorpe To: Nicolin Chen Cc: kevin.tian@intel.com, will@kernel.org, joro@8bytes.org, suravee.suthikulpanit@amd.com, robin.murphy@arm.com, dwmw2@infradead.org, baolu.lu@linux.intel.com, shuah@kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH v1 08/16] iommufd/viommu: Add IOMMU_VIOMMU_INVALIDATE ioctl Message-ID: <20240819173056.GL2032816@nvidia.com> References: <59ad8c075bfa9de7098fd79a30b51d1f53d61a94.1723061378.git.nicolinc@nvidia.com> <20240815232405.GU2032816@nvidia.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: MN2PR05CA0047.namprd05.prod.outlook.com (2603:10b6:208:236::16) To CH3PR12MB7763.namprd12.prod.outlook.com (2603:10b6:610:145::10) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH3PR12MB7763:EE_|DM4PR12MB6230:EE_ X-MS-Office365-Filtering-Correlation-Id: 097b096c-c6ac-458c-3383-08dcc074aff5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|7416014|366016; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?3eFed6xJFo5BVZin+AG5kUwLNmihm4CSR52ixQmBPMf09fVrXJg4nXfHHN9l?= =?us-ascii?Q?5gJRDKRVl2Shx8wX5wCuA8S0Bsf+1UQQFm4Kn1X5ihjv4z/FBkM1aCV20zuG?= =?us-ascii?Q?FLUhRO1Ymr577f6/h5jiglc/N2xMzeS/HiRahN253JLG454zNxbu2bJ1HBGw?= =?us-ascii?Q?jAqpk2Vo3+7LtC4anYs2FxhBmK1eeOU1zqmzn1dOpGUfsPFMtqxyz2fauCB5?= =?us-ascii?Q?oNQoLjGVoFpyuoCJKN83NT2sm56wfI+aaay5qe/5dDoJz5hgURLzN/hAf62k?= =?us-ascii?Q?WsBuZboQsM0W8fhDVefjVVTLXkjG9B/hgeaaLQU5wsU3X0XkFuZrf9ugIv05?= =?us-ascii?Q?SR3hF2r9k8QzMBWg//3UJfJo7AjVWH3OGdoQH1Ik67uyMoTrxSkxUGECLiQM?= =?us-ascii?Q?kQIb29P0Poc9hU0hreocQOZgaXdSKpVG7tm9YfRBZoVlA1vu4h/XfzMd1MsV?= =?us-ascii?Q?SPeTCxbnVweAkKdffztKL1X9BKwmLkgHZFJkYCZHfi02Oaa4p7oUzHD52j89?= =?us-ascii?Q?VZaE0ZDA8VsxllBWFcrmW/DbXtDQPVKteDe0szMtjpIYkJnuVfUAhQDAyuhC?= =?us-ascii?Q?htDagwIljK6o246vezo4VMKnrozSJEC5jf7gfECJhu46aKZOFfWNpMgA142U?= =?us-ascii?Q?No5nVFhARCDmIOfclwrku9+fbOI9B6kFt2xxZbIU26sv/SMcMgvGZBX5a7L7?= =?us-ascii?Q?9aGxWMVb4lDfLNf+KQeTO1/9wxjsB7PjG84yJv94RLPFk/A6WdCADKWhmspA?= =?us-ascii?Q?GmwHB4pH45525zwGJHcOeKm+xPAVzcoaVaP5t5sIiuIdttSbeudVRhHEOf94?= =?us-ascii?Q?Hq9VxlbM/ntW/rFOvySXhIZlqjXZECOr0p/OWTUWWfpuY2n6si3wrjT3herd?= =?us-ascii?Q?dNcOzCMX6qTOOMuRum4nZv4H+r33uq4D3NDVwfgkoWRnKbpQWrBwdss726Ct?= =?us-ascii?Q?i1Iq4MfVkQ7nn4qklc9lLaRWYd333dL2zCEKw+0gdc/A7ih+soExutkGy2Ba?= =?us-ascii?Q?DImBxO6r1EePWXYRgkqdrgdbBDvehfjm5ORoDjERnPSIgrPuuKMq3qmHfOEn?= =?us-ascii?Q?08r6LGf37f+ahbnQy/9t0cwAkFlfFvzBKQYOPuKB8Li1CsBma9MlB4TBBOGc?= =?us-ascii?Q?J14ml1bO3ReylFwbUk5s2+6gzMcrVea+U6p6sUjPNhdcjqybq7a42qj+sR03?= =?us-ascii?Q?fhUvyPNqGwOX5O2oNO2s8vUHfHeG8jQsiV+fh30zD18AfOeBpFYJ7Exmwo8s?= =?us-ascii?Q?2UCFiKwHsOiGwYseVIR8OJr+P36ZJQ1JSaeQqlcUfmhH6dF8D1EB7oBOo0iE?= =?us-ascii?Q?k/GgDoQClELiXvknPFbJyjpNPNges2hnbRvfmdgGeOYsEA=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH3PR12MB7763.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(1800799024)(7416014)(366016);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?8X8iU51HGzJU7xl/RZsEQH57NUZCV1sG+/RBwRwtME+wBZ3k6DExyi13a/zI?= =?us-ascii?Q?BNRL1RcokGcwMoZ3D7SjseNDZSfraUrOWAQGhMCT/gfy5B+xX5t0XWa4ECQ1?= =?us-ascii?Q?LeM0pWilANuVuSzlUZCk1PllWE7wHBlf0WQ+gNL8xcS6o43/Vz/79GxTJfuS?= =?us-ascii?Q?Euz/KU5Xi4aQRWTEXxrKsOskcnk6TzKbLwayJjmf5DdW4lkfovKnBcg2YGwc?= =?us-ascii?Q?Vrz2dhZxlMHJFL6Wy+34gvSSovEf386gE4abVfvpMjxyNIgzF8h2rxtn/bNL?= =?us-ascii?Q?mkfw1fdNCbOfRLp3brosO9gZZloGfEMnXE5ej9cECcg+T8cztTMeoIMd9Sfz?= =?us-ascii?Q?An7FY/gulbsp+BhYrj5v11r+O0oIFhRmy/JiacdUTIqSgRz5K6ELMWK5uiGM?= =?us-ascii?Q?msg3Baj6Kji5PfJNP8VqRisq6t23m5ZvuLj2MRw62aD68Nv5Kq7vsH+Ieh1K?= =?us-ascii?Q?LgJo/ym4LJe/YuNdypaCg5F93gXclz72JE3/eHLgw3RoPXeBmHRwjU5Iu2DE?= =?us-ascii?Q?h1Us0+owN4DMv9T7AAJ99AKTIm9Y2ebtStfKdRLZqyfs3Uotkd6VHMtGF/2o?= =?us-ascii?Q?d1gEfbr9oQUG97yoMLf3dXO0k9o7J2WoFDXSV+I7Kb7sYFkY0MUaO1+pzMCe?= =?us-ascii?Q?MnbeOTLTAwjIrtF0mNyaoCyjqKXyhzfTwEJYEWW6Sn0W4IFdSUi6stGGMxkp?= =?us-ascii?Q?QUvoMQviCUhaAs1WX26MqbtPn6Qi4LrUWVtVzBsthDIQy906NS864NmkGCrR?= =?us-ascii?Q?VcjnxCIW71aRAtwGVRYXmPysA4Lb6GcOPimUi+y3+MAYMDCVLul2ww8LhY3M?= =?us-ascii?Q?BFRJFEHLz1LVKwuj6ST4ETfJgDg7Uzl9Wjq7/9ttZy0XkDO9VzOKxbTq3nnb?= =?us-ascii?Q?rq61rcA6oALt/lxo48gYcouYhNUGB95OYo5SfJfJ+pkLvbmb5sLjQPWPPqfb?= =?us-ascii?Q?OgNbWodtLfBh0NLG5nKBrtKwNh7t9p7iq1HTVDjRWU47WLVxAmFUrFA/Qhnm?= =?us-ascii?Q?jXWU807JPhil0srcVlHu8zZLcP3JTdqbo7cje6nvSd+eBrfp+WAotL6cNbSy?= =?us-ascii?Q?Si/qzlNFG1IjrlEo0m+l9XmsJcqxui0TdWnd246eZ4VDm7yvDG4CO2AgS/so?= =?us-ascii?Q?dfPKMTmvgYio22h8wwXfIPc4VuIYYBiJVFeQYlpkhpw1M7TS8iSlvUQIWNJa?= =?us-ascii?Q?TL18YV8CFwdybmrb/TE8EzZtZNq89ck7s76WGb08xzm+DyKetl4PKG7MWRR5?= =?us-ascii?Q?ySFNP4oq+5FpbnkUPvD7/s8iF8Knaa20Pe931h02oco/Jg+I77juqGG+OkCH?= =?us-ascii?Q?s61+1cZnTcLD2EPhAASt2GEV7Lrm/dCE5TutgiwG3glLdqsrhcGedpwJnGhs?= =?us-ascii?Q?b9koJyAPl16hcg2ZzxnnPVuTHZDaNFKF+P1jLOJ7mD1PLN8QbfNgb5XL2UQE?= =?us-ascii?Q?mx6nhYMOFutJZ+izVowL1Qowy2hyLhN14Cvj1o338aJZMHMb6BaNRWBOzjF3?= =?us-ascii?Q?FDws1V7uHWfl1WHXCn61itSuQnHw1+CGd+DWnL+dzqKJPs3NaA67RZMpHYQP?= =?us-ascii?Q?C/GhD0CyMZVnGxgBVJm8Nm7K2Nru3h7E1ST7zny/?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 097b096c-c6ac-458c-3383-08dcc074aff5 X-MS-Exchange-CrossTenant-AuthSource: CH3PR12MB7763.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Aug 2024 17:30:58.1949 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: TPVKh9yT9xgmjFGgjucK94jy0gr89OWiUZPUS46Y6dp5ilQ1rvsC7Z2f3eM/4Qqp X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB6230 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240819_103107_865088_554DE7FF X-CRM114-Status: GOOD ( 16.46 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Aug 15, 2024 at 04:51:39PM -0700, Nicolin Chen wrote: > On Thu, Aug 15, 2024 at 08:24:05PM -0300, Jason Gunthorpe wrote: > > On Wed, Aug 07, 2024 at 01:10:49PM -0700, Nicolin Chen wrote: > > > @@ -946,4 +947,40 @@ struct iommu_viommu_unset_vdev_id { > > > __aligned_u64 vdev_id; > > > }; > > > #define IOMMU_VIOMMU_UNSET_VDEV_ID _IO(IOMMUFD_TYPE, IOMMUFD_CMD_VIOMMU_UNSET_VDEV_ID) > > > + > > > +/** > > > + * enum iommu_viommu_invalidate_data_type - VIOMMU Cache Invalidate Data Type > > > + * @IOMMU_VIOMMU_INVALIDATE_DATA_ARM_SMMUV3: Invalidation data for ARM SMMUv3 > > > + */ > > > +enum iommu_viommu_invalidate_data_type { > > > + IOMMU_VIOMMU_INVALIDATE_DATA_ARM_SMMUV3, > > > +}; > > > > =1 here I think. Lets try to avoid 0 for the types.. > > > > And this shouldn't be in this patch > > > > But also we can probably just use reuse enum iommu_hwpt_invalidate_data_type > > here? > > Would that force IOMMU drivers to implement both hwpt and viommu > invalidations? SMMUv3 driver would implement both anyway though.. I wouldn't say force, just that they have to use a consistent numbering if they do choose to do both. Jason