From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E260CC52D6F for ; Tue, 20 Aug 2024 01:31:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Subject:Cc:To: From:Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=UDxFi2szfzUetEt+x2X1RqSzUgKqzA4Xx29t4sYwvn4=; b=Ccd6F4OwjPnzqD9mqJdEumkeXF AC1saDv4Tc5RSu/i0O61JUBJIPwGXTSv1Nntmr0tLinJ620uVZka3eT7COICxFv+V5h4sAvc4NY0y VE4dSUxIH2wPPJeFKr6uhID/eumzKy828EY6sKcBuIAuWOsDcP9p0uZXW1Kc4QM7fd9rQbfnE2Nde SQbFnmQIH9JIllu6xEfYSCTKOZd6hBqEAD0AGD1S8gA+OA0CmKp31ihUI5f/ml+cFpGSY9sEDrlHm mJQCoII2RhMODuQTag1+pCZ8i0u5lbF3HE2Sa0e7z881En6EEezFY5hhGCpKG7zir1sCZLWlQmkF3 Mc5O72ag==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sgDib-00000003RD6-26Fx; Tue, 20 Aug 2024 01:31:29 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sgDht-00000003QzF-3nC4 for linux-arm-kernel@lists.infradead.org; Tue, 20 Aug 2024 01:30:47 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id D91DFCE0B02; Tue, 20 Aug 2024 01:30:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B1A81C32782; Tue, 20 Aug 2024 01:30:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1724117443; bh=Yr+3Isy3zlBM+gRcVbOEwYmbxCbZ9TlULM7aDsDTb7c=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=DaKRNBAKEr5IcCQ8bXseEj0SW1YW6WNw7jj5h/gw+ovFFGaKOKShsR1Rh8RPYsoFX 8RNyBznmnC/kDtpSYGIpRRVuAyWdDElweKQdoCuWFGDh/wynEIET4+h8pitcR5FI1i mck6Sol6X3MWeQdC88/G8VowkVci13/a5HghFvhBsvBpYIjuRwEWXvaAacXqRSTzBg 31l7NpGXUYwR+z1EMLNX7mTEBxWQMXmYwzLIw449HCw1yiX5/YAt1RQ5W3qaHPXxv2 kS9QUICsGT2vUOUnuEA5tu50HdfdxMcsSDe+bAmRFekK3JdUN3MCazgRtCHw8ImBMo PvePUyfnb28OQ== Date: Mon, 19 Aug 2024 18:30:41 -0700 From: Jakub Kicinski To: Sean Anderson Cc: Radhey Shyam Pandey , netdev@vger.kernel.org, "David S . Miller" , Andrew Lunn , linux-arm-kernel@lists.infradead.org, Michal Simek , Daniel Borkmann , linux-kernel@vger.kernel.org, Paolo Abeni , Eric Dumazet , Simon Horman Subject: Re: [PATCH net-next v2 1/5] net: xilinx: axienet: Always disable promiscuous mode Message-ID: <20240819183041.2b985755@kernel.org> In-Reply-To: <20240815193614.4120810-2-sean.anderson@linux.dev> References: <20240815193614.4120810-1-sean.anderson@linux.dev> <20240815193614.4120810-2-sean.anderson@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240819_183046_148046_BBEC85DD X-CRM114-Status: UNSURE ( 9.72 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 15 Aug 2024 15:36:10 -0400 Sean Anderson wrote: > If promiscuous mode is disabled when there are fewer than four multicast > addresses, then it will to be reflected in the hardware. Fix this by it will *not* be reflected? Something is off with this commit messages, or at least I can't parse > always clearing the promiscuous mode flag even when we program multicast > addresses. > > Fixes: 8a3b7a252dca ("drivers/net/ethernet/xilinx: added Xilinx AXI Ethernet driver") I think we should ship it as a fix to net?