From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A01F6C52D6F for ; Tue, 20 Aug 2024 01:33:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Subject:Cc:To: From:Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=gErzsxx6Mf3MuQ32fTXRGinxs3JBJ2PpDwlMF91SETY=; b=ft0t5BxtS9jLQEMFmGvA3XH3yX mAQyWVVTSHUnIYOakWR877HqtonXTQgXmiui6SaWhDH9GLdak853mPGSejahrsGvfxJUdgL0X95UN EnAUc6fb/3ZOqckIaPjGJhySaNJQ/kUmMISe85hDY/rOAbaA9LiXtLWb3CTVET8KdlAl6qgomJ1eC oJRcbdOwmzt1KNhKhYyaZEJhEDLjxFpiQv6OPObzNzrL6lS8B7Cr6V3GflcRVU7tPtvl3l9ez1adj MWNGSagJh4xmnSvoP5rYLxlkRUqu8DmO+xWxtXReWEBAX2aU19gm5b2VLKLY6c0nNSqT7fhR72GBR qlyskDmA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sgDkq-00000003RTr-1aFQ; Tue, 20 Aug 2024 01:33:48 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sgDk9-00000003ROL-1IAL for linux-arm-kernel@lists.infradead.org; Tue, 20 Aug 2024 01:33:06 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 96178601DA; Tue, 20 Aug 2024 01:33:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C97C6C32782; Tue, 20 Aug 2024 01:33:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1724117583; bh=Tdqug5IeAAWe7rMOk6UxGjNRhUc56LQEVOagI1zSIR4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=hy4jsgGJsQEZNS17PMtGRSoNhD35Eeg2haJmwbzRdcIR49CPQrw34zkyxcRwIn0l/ po/6/AjYjHC/59IAbOTrHgOto7vWAaCV9DQrmJ3IeajmCB4PHMOrTy6jlT0w6iE6Nw Ilr34miXrfPit3rnoohbKeVjgptKmhlzj+i/xeqAMwgyRwAqAv2TvPlCzBYAMqhLJT 6wBfpq+4Ic1yXbV44vv2QEO9ZNb7I0+jpWt9sM5FE4KB6wmmjBzBkinrObxSdmeTFw 5LvJYwosrRQTdtHTejzBNprKcIgGXLQ2GoYCyMJl5hykrtGGvnXzfZedyCwoEKoRBI R8455drrYeNJw== Date: Mon, 19 Aug 2024 18:33:02 -0700 From: Jakub Kicinski To: Sean Anderson Cc: Radhey Shyam Pandey , netdev@vger.kernel.org, "David S . Miller" , Andrew Lunn , linux-arm-kernel@lists.infradead.org, Michal Simek , Daniel Borkmann , linux-kernel@vger.kernel.org, Paolo Abeni , Eric Dumazet , Simon Horman Subject: Re: [PATCH net-next v2 2/5] net: xilinx: axienet: Fix dangling multicast addresses Message-ID: <20240819183302.26b7a352@kernel.org> In-Reply-To: <20240815193614.4120810-3-sean.anderson@linux.dev> References: <20240815193614.4120810-1-sean.anderson@linux.dev> <20240815193614.4120810-3-sean.anderson@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240819_183305_436664_380BA297 X-CRM114-Status: GOOD ( 14.45 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 15 Aug 2024 15:36:11 -0400 Sean Anderson wrote: > If a multicast address is removed but there are still some multicast > addresses, that address would remain programmed into the frame filter. > Fix this by explicitly setting the enable bit for each filter. > > Fixes: 8a3b7a252dca ("drivers/net/ethernet/xilinx: added Xilinx AXI Ethernet driver") > Signed-off-by: Sean Anderson > Reviewed-by: Simon Horman Again, I'd go for net. > diff --git a/drivers/net/ethernet/xilinx/xilinx_axienet.h b/drivers/net/ethernet/xilinx/xilinx_axienet.h > index 0d5b300107e0..03fef656478e 100644 > --- a/drivers/net/ethernet/xilinx/xilinx_axienet.h > +++ b/drivers/net/ethernet/xilinx/xilinx_axienet.h > @@ -170,6 +170,7 @@ > #define XAE_UAW0_OFFSET 0x00000700 /* Unicast address word 0 */ > #define XAE_UAW1_OFFSET 0x00000704 /* Unicast address word 1 */ > #define XAE_FMI_OFFSET 0x00000708 /* Filter Mask Index */ > +#define XAE_FFE_OFFSET 0x0000070C /* Frame Filter Enable */ > #define XAE_AF0_OFFSET 0x00000710 /* Address Filter 0 */ > #define XAE_AF1_OFFSET 0x00000714 /* Address Filter 1 */ There is a conflict with current net / net-next here, because of 9ff2f816e2aa65ca9, you'll need to rebase / repost (which is why I'm allowing myself the nit picks ;)) > diff --git a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c > index e664611c29cf..1bcabb016ca9 100644 > --- a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c > +++ b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c > @@ -433,7 +433,7 @@ static int netdev_set_mac_address(struct net_device *ndev, void *p) > */ > static void axienet_set_multicast_list(struct net_device *ndev) > { > - int i; > + int i = 0; Consider renaming i to addr_cnt ? or addr_num ?