linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Shanker Donthineni <sdonthineni@nvidia.com>
To: James Morse <james.morse@arm.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
	Shanker Donthineni <sdonthineni@nvidia.com>,
	Rohit Mathew <rohit.mathew@arm.com>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-doc@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	Vikram Sethi <vsethi@nvidia.com>
Subject: [PATCH] arm_mpam: Fix T241-MPAM-4 workaround
Date: Mon, 19 Aug 2024 17:08:18 -0500	[thread overview]
Message-ID: <20240819220818.201870-1-sdonthineni@nvidia.com> (raw)

The workaround for T241-MPAM-4 was applied incorrectly, leading to
MBW_MIN being programmed with a zero value when the user specifies
MBW_MAX is less than 5%.

This patch ensures that MBW_MIN is programmed with a non-zero value,
set to 1 to fix the T241-MPAM-4 as expected.

Fixes: 13ff1b527e40 ("arm_mpam: Add workaround for T241-MPAM-4")
Signed-off-by: Shanker Donthineni <sdonthineni@nvidia.com>
---
 drivers/platform/arm64/mpam/mpam_devices.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/platform/arm64/mpam/mpam_devices.c b/drivers/platform/arm64/mpam/mpam_devices.c
index a802ca1c9f05..e49a27c02c66 100644
--- a/drivers/platform/arm64/mpam/mpam_devices.c
+++ b/drivers/platform/arm64/mpam/mpam_devices.c
@@ -2990,7 +2990,7 @@ static void mpam_extend_config(struct mpam_class *class, struct mpam_config *cfg
 	}
 
 	if (mpam_has_quirk(T241_FORCE_MBW_MIN_TO_ONE, class) &&
-	    cfg->mbw_min == 0) {
+	    cfg->mbw_min <= min_hw_granule) {
 		cfg->mbw_min = min_hw_granule + 1;
 		mpam_set_feature(mpam_feat_mbw_min, cfg);
 	}
-- 
2.25.1



             reply	other threads:[~2024-08-19 22:10 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-19 22:08 Shanker Donthineni [this message]
2024-08-21 11:42 ` [PATCH] arm_mpam: Fix T241-MPAM-4 workaround Jonathan Cameron
2024-09-17 16:12   ` Koba Ko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240819220818.201870-1-sdonthineni@nvidia.com \
    --to=sdonthineni@nvidia.com \
    --cc=catalin.marinas@arm.com \
    --cc=james.morse@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rohit.mathew@arm.com \
    --cc=vsethi@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).