From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E4C7CC3DA4A for ; Tue, 20 Aug 2024 19:04:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References :Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Lk39EVwUYTe/PmJgHJ0o6ZUpvB1YLfN5vQiutxbSGPc=; b=Xk5AsAATlG8/ZGvItV/dq8ei7j c2w4sGIwkh1xCq3wkdbDl3IjkRuI6Ro6Hl0bWmbBFYOA5QW4nKLn7Dvhc8L5khWrHEAGGeA6Ier/r nt5XSFMWPshzB50gsyUksDv46SxZwc/ChK/mntzh7gMtTggUar03ixHVms/L3MQcWwoGkNtnuTqjp XapXVjIcU/j4aZpzy5NffIuQLtA0M/LsoYo1zJv283ydA+6sENMHDf0q/VaAKIYvNIeL6abJJDHBa 8iQnfhK4uHS4MmvyTj/eA8oHc2rqsX/GTXTX+ByN2GvpFoTGDomI1ZVOsym1wjnF/TCNMjvwacL47 Aph/9ZpQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sgU9p-00000006POs-3Ddl; Tue, 20 Aug 2024 19:04:41 +0000 Received: from mail-wr1-x42a.google.com ([2a00:1450:4864:20::42a]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sgU7p-00000006P2X-41l2 for linux-arm-kernel@lists.infradead.org; Tue, 20 Aug 2024 19:02:39 +0000 Received: by mail-wr1-x42a.google.com with SMTP id ffacd0b85a97d-371a9bea8d4so1990209f8f.2 for ; Tue, 20 Aug 2024 12:02:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1724180556; x=1724785356; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Lk39EVwUYTe/PmJgHJ0o6ZUpvB1YLfN5vQiutxbSGPc=; b=C5/ha50z7ktarPXQvzSmP65bXizgGJeSKg+u1YN62eN/6KMiYfxadV6NHvMobSfwIG lqps5K8d8qS4CB+nop/TPu7k63cU1z/REpSBJFO9JnDS8/SKGIoWXtg+x6OkA5IGucG2 nZBZDcNQ5itGO6pUH/fOP0R9b5hp6kFsxyIGnvAP9Z6qop8tEFiVlgPZD5rNb8AYBTRv c9TcytMICpeg5U/Rsz2U683jy3v4apkwZizrmmvKexI9v7TJxE5KL6PpX2dZEU00Her8 PUzoBTtj1HyAkUnmoB8v1l7WEnaoptuGPVMhtJtsXjMbkTNIOrgatV+r3uumW106H4dQ 4FIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724180556; x=1724785356; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Lk39EVwUYTe/PmJgHJ0o6ZUpvB1YLfN5vQiutxbSGPc=; b=ssBNb2mWCWzvcWGW5ChTCW78VpNPAN/8FLatt7OrtHbd8TGv6dzkb8nGQNhslApTjg hyA5PUubP0MjEJCLDsCfsCzTyFcbBpR92DnjxhFI8n0Muk5DvAjeh0yGXeegwGWuc8OL HgkzxSh1KWVYmnmrkLcWvupJCT6YX1P9FV+6je0+Fy+b3jPLzLWYWP6F3Ld5QLcKm+jx RhsT47Vux8wUznkguIpfNZGvRgO3GBAAANCps/PuP+i7Tv5zPzDonQgsfLABFrPpKlBW wHWd3R+bASmIbAsg5yti93E9bibBcixuialTXHem73SlxCIgJv/JV44/rMrbRMp3iL9w 51rQ== X-Forwarded-Encrypted: i=1; AJvYcCWEbfIYPAVnTiKeLWDiGuwkyi8MwzQt0mj0S+OgddTvc9R6b5ttD0+PVU7nvj6Ai/Ts0P6eTpBHRkxuczeOA9Cs@lists.infradead.org X-Gm-Message-State: AOJu0YwCeOkf0OwPN+Czekp0hcLUHaghMWG4l6f9Ttd/HwC2QCBz4lXS n6pL/O7oOaW5L3EQZO9r91VVk1CsB+fX4oDe8s3GqH89UGmrKRZr X-Google-Smtp-Source: AGHT+IGGBhANiB3W6Reo3NqccFS905Z9Dy+9c9h/ngG3KSuRWQLpJHFooauis3rHBSlP+NQHFkGnJQ== X-Received: by 2002:a5d:408f:0:b0:368:5b80:b8d with SMTP id ffacd0b85a97d-37194456508mr8491898f8f.21.1724180556015; Tue, 20 Aug 2024 12:02:36 -0700 (PDT) Received: from [127.0.1.1] (84-115-213-37.cable.dynamic.surfer.at. [84.115.213.37]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-371898497ffsm13685375f8f.27.2024.08.20.12.02.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Aug 2024 12:02:35 -0700 (PDT) From: Javier Carrasco Date: Tue, 20 Aug 2024 21:02:27 +0200 Subject: [PATCH v3 2/2] leds: as3645a: use device_* to iterate over device child nodes MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20240820-device_child_node_access-v3-2-1ee09bdedb9e@gmail.com> References: <20240820-device_child_node_access-v3-0-1ee09bdedb9e@gmail.com> In-Reply-To: <20240820-device_child_node_access-v3-0-1ee09bdedb9e@gmail.com> To: Suzuki K Poulose , Mike Leach , James Clark , Alexander Shishkin , Michael Hennerich , Lars-Peter Clausen , Jonathan Cameron , Anand Ashok Dumbre , Michal Simek , Sakari Ailus , Pavel Machek , Lee Jones Cc: coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-leds@vger.kernel.org, Javier Carrasco X-Mailer: b4 0.14-dev X-Developer-Signature: v=1; a=ed25519-sha256; t=1724180551; l=1681; i=javier.carrasco.cruz@gmail.com; s=20240312; h=from:subject:message-id; bh=qaFPWD0RIQleYc4Ns6S0TI+inVjJZc6RI3ib63Jcn20=; b=+qLZOCM01OgoJCa1FolIUdEkTZVPRnhhGL5fjZKf4mR3vOOH/TFJIS15/h5JWDgs2cH1y1VCR DWLZrYfjvNEDnl2k7Je38HCKrH2jawUX/Nuze+0nKLtAA3SJllCcReB X-Developer-Key: i=javier.carrasco.cruz@gmail.com; a=ed25519; pk=lzSIvIzMz0JhJrzLXI0HAdPwsNPSSmEn6RbS+PTS9aQ= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240820_120238_034298_79BAE916 X-CRM114-Status: GOOD ( 13.86 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Drop the manual access to the fwnode of the device to iterate over its child nodes. `device_for_each_child_node` macro provides direct access to the child nodes, and given that the `child` variable is only required within the loop, the scoped variant of the macro can be used. Use the `device_for_each_child_node_scoped` macro to iterate over the direct child nodes of the device. Acked-by: Sakari Ailus Signed-off-by: Javier Carrasco --- drivers/leds/flash/leds-as3645a.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/leds/flash/leds-as3645a.c b/drivers/leds/flash/leds-as3645a.c index 2c6ef321b7c8..2f2d783c62c3 100644 --- a/drivers/leds/flash/leds-as3645a.c +++ b/drivers/leds/flash/leds-as3645a.c @@ -478,14 +478,12 @@ static int as3645a_detect(struct as3645a *flash) return as3645a_write(flash, AS_BOOST_REG, AS_BOOST_CURRENT_DISABLE); } -static int as3645a_parse_node(struct as3645a *flash, - struct fwnode_handle *fwnode) +static int as3645a_parse_node(struct device *dev, struct as3645a *flash) { struct as3645a_config *cfg = &flash->cfg; - struct fwnode_handle *child; int rval; - fwnode_for_each_child_node(fwnode, child) { + device_for_each_child_node_scoped(dev, child) { u32 id = 0; fwnode_property_read_u32(child, "reg", &id); @@ -686,7 +684,7 @@ static int as3645a_probe(struct i2c_client *client) flash->client = client; - rval = as3645a_parse_node(flash, dev_fwnode(&client->dev)); + rval = as3645a_parse_node(&client->dev, flash); if (rval < 0) return rval; -- 2.43.0