From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EAB57C531DF for ; Tue, 20 Aug 2024 09:52:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=QMRO5aEOOPp2GA4SgmW2MhbGQ/rLz3tZNU53B/4+f4g=; b=mEjJNPkR4bnZJ+QGPkzZEpgWbD rh3kPDgd2PaKWq3aThDFSCZXc0pCLwfSaF37m10marK4hmP1HTsjz4C1BCuUNWA0iiSbJAUC2poN1 +9RUI9opSWS1tM4TQBcOOy69c8TWE5JTQnKN9/vo1Nye574wHnOtIZF0KJLCKXIHR8Pgz4OZgEfHc GkNHjFIlZLUBwXREPLdYrtc4cnh5Ol6h3VRK1nbDSGM8fZdUxfgoL/k4Rqhh7lMQGxN0mVIft31GV u0WLATifRgk5GjMI8fzeHWQDcNVCJbOYsY26uYKNzpU91u6PXgwPTPLrMNJvLRNYOPW7V9fsnEsbj pyLkpcmQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sgLX3-00000004fkX-1BtZ; Tue, 20 Aug 2024 09:52:05 +0000 Received: from mail-ej1-x62e.google.com ([2a00:1450:4864:20::62e]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sgLWL-00000004fby-0mdD for linux-arm-kernel@lists.infradead.org; Tue, 20 Aug 2024 09:51:23 +0000 Received: by mail-ej1-x62e.google.com with SMTP id a640c23a62f3a-a86464934e3so93754466b.3 for ; Tue, 20 Aug 2024 02:51:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1724147479; x=1724752279; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=QMRO5aEOOPp2GA4SgmW2MhbGQ/rLz3tZNU53B/4+f4g=; b=VgHXhm73E1atfbpWBOLBlTVS2H8PIWjAeBMjGZG5UeQt5xQHHaw4LgxC4xwuvkDbjN g2zvyfLHZvgUU5rbxx65EsibKogH9JZ2rI1vYnAXvv78CLaLjSZuLtdW/kEIM7oPajUQ +e/KAjT5sTHHzY08qgQ1kDhIAVWmQxbrI4ER4D3MRmSG1c5CV6ZybnvmNEx03qsq16bX nBFits5lnXX05rGdrDLSbk7PvEhQwxwkhmRr0CbDrXXLYy+o70VPjyBVDl2B6sj91pro xyr2Z82NNVT6Cu9jS8xfTBDGiZOdFwWNe0sDauT9xm0+6/TVutMrjr+0LHo/jT6fMBbJ dC3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724147479; x=1724752279; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=QMRO5aEOOPp2GA4SgmW2MhbGQ/rLz3tZNU53B/4+f4g=; b=og4bPTPqC64WuMho0uEH67i1zfkLLB0VLK+PNUQfDAT3iOaQz3r7S/2tL8r1jHrYj2 9Dzh93kq+0PLaOzME66CTv8V1qZmLTNKyzcu5PP7WKzB2MKYOt42wrBgoZ4GCEN8j552 y5wbaj4YlIL8bIqjm2bT2rfG/oSU69HMsNrKnikA39Ib2JSMudqOOQ0dSSRIG4vwPy9N zjXMWaYDbzAnLJRMZtfkZLYyLecXEiPMKmlfJ90Yi2HLXpe5BHidYRp92YAhuPYOxzgi +2zfSbUZCNEaRMEQ++a5m7106fOkDGfbVJKIpZ4XyvNQ5Q8/1C5FRaY1ubWsaRq3CA1D 9+Gg== X-Forwarded-Encrypted: i=1; AJvYcCW7A5Vmo134KMqgef3F0+XKEevmOBPDlnYNqy3rQWey0Fxq9uaNWNqKGvXGLvTfEbnnbrI6q3sNeYjrpuEA73QhXPcZkQTFuPj7lG/q2sosIUkNeMc= X-Gm-Message-State: AOJu0Yyi7if6XEh4tJffgzp24KG5A1jEonwSlFAMSd55esaWpHq0mkIX MI3LYcn9KXcyrPpkMoexoTM429UGZN34lzd0TFmgwY5PWWihrIkI X-Google-Smtp-Source: AGHT+IFe89MF4PAXRq87PUkDRnYToPhl3veGvDUpACgEFBVjcT25Az4FnOvuI3g+DR4n6Ox2qbTARg== X-Received: by 2002:a17:907:7e94:b0:a7d:c148:ec85 with SMTP id a640c23a62f3a-a8392a38e70mr1068397266b.62.1724147478406; Tue, 20 Aug 2024 02:51:18 -0700 (PDT) Received: from skbuf ([188.25.134.29]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a838393560bsm741330866b.139.2024.08.20.02.51.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Aug 2024 02:51:17 -0700 (PDT) Date: Tue, 20 Aug 2024 12:51:15 +0300 From: Vladimir Oltean To: Furong Xu <0x1207@gmail.com> Cc: Serge Semin , Andrew Lunn , "David S. Miller" , Alexandre Torgue , Jose Abreu , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , Joao Pinto , netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, xfr@outlook.com Subject: Re: [PATCH net-next v4 5/7] net: stmmac: support fp parameter of tc-mqprio Message-ID: <20240820095115.bhg4rv7oeondetol@skbuf> References: <413a36781a9b215c857bd8ec3c9ee03462e861d7.1724145786.git.0x1207@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <413a36781a9b215c857bd8ec3c9ee03462e861d7.1724145786.git.0x1207@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240820_025121_252191_D7BF8287 X-CRM114-Status: GOOD ( 15.16 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Aug 20, 2024 at 05:38:33PM +0800, Furong Xu wrote: > +static int tc_setup_mqprio(struct stmmac_priv *priv, > + struct tc_mqprio_qopt_offload *mqprio) > +{ > + struct netlink_ext_ack *extack = mqprio->extack; > + struct tc_mqprio_qopt *qopt = &mqprio->qopt; > + struct net_device *ndev = priv->dev; > + int num_stack_tx_queues = 0; > + int num_tc = qopt->num_tc; > + u16 offset, count; > + int tc, err; > + > + if (!num_tc) { > + stmmac_reset_tc_mqprio(ndev, extack); > + return 0; > + } > + > + if (mqprio->preemptible_tcs && !ethtool_dev_mm_supported(ndev)) { > + NL_SET_ERR_MSG_MOD(extack, "Device does not support preemption"); > + return -EOPNOTSUPP; > + } When I said that "this condition is dealt with by the core, now" https://lore.kernel.org/netdev/20240819114242.2m6okk7bq64e437c@skbuf/ I meant that the driver doesn't need to check anything - the check has already run once, in the Qdisc layer. See taprio_parse_tc_entries() and mqprio_parse_tc_entries(). I was not asking to insert this test, just to completely remove, rather than adapt, the entire block: if (fpe && !priv->dma_cap.fpesel) { mutex_unlock(&priv->est_lock); return -EOPNOTSUPP; }