From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AA782C531DF for ; Tue, 20 Aug 2024 12:53:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Knx/Wm8d04mP0mUth0cL+YGIY2+xGYXs0Lh/UFhf76o=; b=1svbiHAw7sZIVctU+0mxcMViIi CcKEGxRrZdjLAC0J/GND+x89flU41JSHWdKDY6aMGKttm7uQmmyHrNhDuQHd0B2ATsoAsrle/FPg0 PUVKZOUlvTmXo/G3YyruDQBUPSzkSk1Tof1B+lBNqhirzCBk0tvcH1DVpHGN7VSoww0RAnxVh/j8E uoFc0zRbLQVwrO/kWo2SpAgPrBms9+qK4VgV8YqbGCttikXiY3J5w2WwBRfr2XhJvKQZlh9FxQahv 7upC7Ccj5lvOJyWHIrlbz9B2t9bfV1/9w7kWlfxoSH07xnVt+uAjxcTvzLW+n5slw4YcNspbGafIq 8cMDkFVw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sgOMI-00000005Gfi-3wV2; Tue, 20 Aug 2024 12:53:10 +0000 Received: from mail-ed1-x534.google.com ([2a00:1450:4864:20::534]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sgOLc-00000005GZM-04Jf for linux-arm-kernel@lists.infradead.org; Tue, 20 Aug 2024 12:52:29 +0000 Received: by mail-ed1-x534.google.com with SMTP id 4fb4d7f45d1cf-5bed83488b3so4147138a12.0 for ; Tue, 20 Aug 2024 05:52:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1724158346; x=1724763146; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Knx/Wm8d04mP0mUth0cL+YGIY2+xGYXs0Lh/UFhf76o=; b=jIHyZ3tRuCcidQSPmMHyqPhv2fPy3hc3PqWk+k3u+mWH8CubYFS8r3Ij0KocVi/Dkq wUjMOKwmISPjPytGQQ79/IQ+jw2tSyVc7X0UekIZY1No4A4Rd+nRWJiNklmwwmXo9uFY CZgq7kaQZnr9KeFIimhucLO5jv1tl06bE5BJqnOgCh+fxfmCwE7IE7ByTCvbTsHeTJsg d7FhdoIf53b0/oLfiaSHCg2UPJJRKwmsYpXXbd0E0rnCa5L/V3E8KcLRmbjsLCib9Nej +XL3Nltc7PJCcYDPbXPvyiZU9ctDjmYKhEuxaf+IsB0XluAoEzAIFctfgehOsa9bLOXI k+Nw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724158346; x=1724763146; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Knx/Wm8d04mP0mUth0cL+YGIY2+xGYXs0Lh/UFhf76o=; b=kfQoF/vJGYCQr4XOvjabWqygLm/ARmAKkiSQIdOPecO79Usi/a0DhaTl7lE5FN1qAP Rse5Y6DBMCzV1NXVMejsyObrCfBCLoJ+MEMFfPXUTY9dQidIrC3+qEHB7ABOFTqQIdlx BzbJ+Sfho9mw1e00CtQzfOyyEFSrP8i9VlsOrypGGa276z4GYCRryWVScOmvjHoWkZJ2 ttUgjQuo8rB7BrS09ZV8BdmWTdyoEmVVD7Nxb4/zIhtjuFy+XScfzN8z1veGGiRig3Br zMgiAflxnoej5f0eYpTZiVd3gcBkrKnhTEda5VLKXrGV05zBORtIXZSZwibsUdCThg2g AFqw== X-Forwarded-Encrypted: i=1; AJvYcCVWkIUWUnUlxxDdRqPEyAp32eSUdWy4dulvRiAeTl+wVIHtHcPzIapscEyF/5cl7rgEwdjg68pt2ErTQCW7hZ89@lists.infradead.org X-Gm-Message-State: AOJu0YwgxUZ/qsF6In8zkR0IJDo2llpU3Dnl81wgk2iWJenctr7Rl8lF UIU2yexV+TmH3qy6dL9j/Fh4AUJW4ffM9SoZaaDZNIH+8PaomBON X-Google-Smtp-Source: AGHT+IELQXfyg2G1L4D9vQw2uIX24lD9ZaNlxT9BSo4Kp7kVm3c1WwrsSrVTXpg6pVqMkwFN2/fdDQ== X-Received: by 2002:a17:907:9717:b0:a72:6b08:ab24 with SMTP id a640c23a62f3a-a83928a4178mr1099966866b.14.1724158345821; Tue, 20 Aug 2024 05:52:25 -0700 (PDT) Received: from skbuf ([188.25.134.29]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a83838c6bfcsm762540966b.28.2024.08.20.05.52.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Aug 2024 05:52:25 -0700 (PDT) Date: Tue, 20 Aug 2024 15:52:22 +0300 From: Vladimir Oltean To: Furong Xu <0x1207@gmail.com> Cc: Serge Semin , Andrew Lunn , "David S. Miller" , Alexandre Torgue , Jose Abreu , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , Joao Pinto , netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, xfr@outlook.com Subject: Re: [PATCH net-next v4 3/7] net: stmmac: refactor FPE verification process Message-ID: <20240820125222.uia4m27wizy2767a@skbuf> References: <20240820123456.qbt4emjdjg5pouym@skbuf> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240820123456.qbt4emjdjg5pouym@skbuf> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240820_055228_076925_5B4D1485 X-CRM114-Status: GOOD ( 14.75 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Aug 20, 2024 at 03:34:56PM +0300, Vladimir Oltean wrote: > I took the liberty of rewriting the fpe_task to a timer, and delete the > workqueue. Here is a completely untested patch, which at least is less > complex, has less code and is easier to understand. What do you think? I already found a bug in the code I sent, sorry. verify_limit needs to be reset each time status is reset to ETHTOOL_MM_VERIFY_STATUS_INITIAL, to allow for 3 retries on each clean-state verification process. diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c index 3eb5344e2412..530793bce231 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c @@ -1333,7 +1333,6 @@ static int stmmac_set_mm(struct net_device *ndev, struct ethtool_mm_cfg *cfg, fpe_cfg->tx_enabled = cfg->tx_enabled; fpe_cfg->verify_time = cfg->verify_time; fpe_cfg->verify_enabled = cfg->verify_enabled; - fpe_cfg->verify_limit = 3; /* IEEE 802.3 constant */ if (!cfg->verify_enabled) fpe_cfg->status = ETHTOOL_MM_VERIFY_STATUS_DISABLED; diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c index fa74504f3ad5..a88ec40c4b6d 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c @@ -7405,6 +7405,7 @@ void stmmac_fpe_apply(struct stmmac_priv *priv) fpe_cfg->pmac_enabled); } else { fpe_cfg->status = ETHTOOL_MM_VERIFY_STATUS_INITIAL; + fpe_cfg->verify_limit = 3; /* IEEE 802.3 constant */ stmmac_fpe_verify_timer_arm(fpe_cfg); } }