From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 81C7FC52D7C for ; Wed, 21 Aug 2024 13:21:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=/6SAo6PVLWJClsfzyHrkHAJBVOy5N9kixDFuGn0CPGk=; b=tAbHsp0Vwu/hDbiTrDMIGms/47 QLQwl1gra/6K5lOQcWyPEZqX0C8hmokVSwOfslGV5cuC92lS6QRdjbDdrt3hG3aH0QdnsavNK8N+c h0yTeBTreI7LTSogNwEEXyRIavHQnEhO4q5WeqqJoGFTsj/IsFBg7360fuqF+Cxn3sKztCiuWXOZ9 z7kqzDbDaomlRKkIRgTCgPLw2TyEyAQ5piXIeE1HOK5ZvmqLPbnXgbK58Q7r6oX4GEmqgVofRjEr2 ftnUsRmNsDozhUOt4Ki8XEV0CCd/CLm/3UuHOsRIFTLjw355GjyvcaGR5q9YStuKJ2mQCHRwUErFE DM4buAEQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sglHO-0000000979x-3Zwb; Wed, 21 Aug 2024 13:21:38 +0000 Received: from mail.thorsis.com ([217.92.40.78]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sglGF-000000096ud-1itL; Wed, 21 Aug 2024 13:20:29 +0000 Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id D3534148346C; Wed, 21 Aug 2024 15:20:20 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thorsis.com; s=dkim; t=1724246423; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=/6SAo6PVLWJClsfzyHrkHAJBVOy5N9kixDFuGn0CPGk=; b=cxKl84oDc8cT8pEQQDsgrozKSItB2ILu/jt0c2SHQi+SwwmhJ1Z35VnI6jHI99ZsltSM+o yDO/L8ok/4ZwRMGOIfx3uFK9fwH9u5ywGxu+/1gB8ATgSMQ3pT8spAQ9mC+GLyfG5lE2v/ WwMjYUFBZTNilPD14KuKtRPd69L1oqrI2cAV/AQ8S3wZnMqVhkVyYq52Bn/V07pMmQDkfi gLCxrqILoyWW/lKXjd1DRzUCrfNPs/pUUMX0zGTCH0WSl7MXxj+mxw8GthgfhQD5qmiCBh zz4NPPbanwtTpEqA+HEcU8PqvG8OCNyUUU4TKHYRWkCgyoAg3q5WD/6MHR/kOg== Date: Wed, 21 Aug 2024 15:20:19 +0200 From: Alexander Dahl To: Miquel Raynal Subject: Re: [PATCH] mtd: nand: raw: atmel: Add message on DMA usage Message-ID: <20240821-ouch-tanned-fed30ba26700@thorsis.com> Mail-Followup-To: Miquel Raynal , linux-mtd@lists.infradead.org, Richard Weinberger , Vignesh Raghavendra , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Kees Cook , "Gustavo A. R. Silva" , "moderated list:ARM/Microchip (AT91) SoC support" , open list References: <20240821120517.330868-1-ada@thorsis.com> <20240821151701.6bde9aba@xps-13> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240821151701.6bde9aba@xps-13> User-Agent: Mutt/2.2.12 (2023-09-09) X-Last-TLS-Session-Version: TLSv1.3 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240821_062027_779639_47785DB4 X-CRM114-Status: GOOD ( 16.00 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alexandre Belloni , "Gustavo A. R. Silva" , open list , Vignesh Raghavendra , Alexander Dahl , Richard Weinberger , Claudiu Beznea , Kees Cook , linux-mtd@lists.infradead.org, "moderated list:ARM/Microchip \(AT91\) SoC support" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Miquel, Am Wed, Aug 21, 2024 at 03:17:01PM +0200 schrieb Miquel Raynal: > Hi Alexander, > > ada@thorsis.com wrote on Wed, 21 Aug 2024 14:05:16 +0200: > > > Like for other atmel drivers (serial, crypto, mmc, …), too. > > > > Signed-off-by: Alexander Dahl > > --- > > drivers/mtd/nand/raw/atmel/nand-controller.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/drivers/mtd/nand/raw/atmel/nand-controller.c b/drivers/mtd/nand/raw/atmel/nand-controller.c > > index dc75d50d52e8..9e6dea2cf140 100644 > > --- a/drivers/mtd/nand/raw/atmel/nand-controller.c > > +++ b/drivers/mtd/nand/raw/atmel/nand-controller.c > > @@ -2051,6 +2051,8 @@ static int atmel_nand_controller_init(struct atmel_nand_controller *nc, > > nc->dmac = dma_request_channel(mask, NULL, NULL); > > if (!nc->dmac) > > dev_err(nc->dev, "Failed to request DMA channel\n"); > > + dev_info(nc->dev, "using %s for DMA transfers\n", > > + dma_chan_name(nc->dmac)); > > > The message here would be misleading if !nc->dmac. Of course you're right, this is somewhat embarassing. I'll send a v2. Thanks for reviewing. Alex > > > } > > > > /* We do not retrieve the SMC syscon when parsing old DTs. */ > > > > base-commit: 47ac09b91befbb6a235ab620c32af719f8208399 > > > Thanks, > Miquèl