From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0CD87C52D7C for ; Wed, 21 Aug 2024 12:17:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:In-Reply-To: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=TSBk3tiwYk5OG97kBGDXG+0Y8CDnp1Ut323qDsoZ2kI=; b=bUAV2rH4d9jcZqU/FIean1p3oa zt89eF5ID8QNN5bC4BF/ZGqjx1Q+27ABywLDWwDHm+QZ1lo5xcqJ4/y2dFp6mz0jvRI4sESHCjyyD vWtczEuh5inHzutGfPgPOOFe2oDTm5ZX6CKM1W9CzHQi6E0gQPf6E7hdoVKvEWG0Uja+kE/Hw++N1 W5F31WEiqAR8Rv79Yt/Mt7fKoggRwV922W72bcnDELjoYOczrAci7W1EEnKbdfsFzid8S3yXlWVES xP6NSQd5O6cHeYAcbQdbgaSum2iB59SH8G1wMPTXSn0I6nevoLMRMVdzduDaLFEySvocLlT82RHqE M6bQBxuQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sgkH9-00000008tE8-1o0j; Wed, 21 Aug 2024 12:17:19 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sgkD7-00000008rpH-1uxR for linux-arm-kernel@lists.infradead.org; Wed, 21 Aug 2024 12:13:11 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1724242387; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=TSBk3tiwYk5OG97kBGDXG+0Y8CDnp1Ut323qDsoZ2kI=; b=UubX1HUwYa45/kCYyMuP4bMoTnXAxmkfvv9ke/B2KIaWGjgjUIHdFR6c4ur2eiUcEc0zsD YaxBHptZpNQ7R9us+priZQ1xU2IInkNS1T5cvFWU+s2O1HzpLzZvkZQcb9iqEo8flOxjlt UU+Rry0hGSs5VhDMgF5xSd/CzfeN6WQ= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-682-I86L7VVwO1WHXFt6NlFjaQ-1; Wed, 21 Aug 2024 08:13:06 -0400 X-MC-Unique: I86L7VVwO1WHXFt6NlFjaQ-1 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-372fe1ba9a6so465564f8f.1 for ; Wed, 21 Aug 2024 05:13:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724242385; x=1724847185; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=TSBk3tiwYk5OG97kBGDXG+0Y8CDnp1Ut323qDsoZ2kI=; b=us/Th8xnGjxvCzSnm0bk4AGRYeTE1yT95u/KXXXth4XqWPkzOQ6jkqcDejB5xTjoOe 2ctzrq+puQ4VvBV/ZVtc3w9c9fEsDegjnEG8bFMWMcVJPgX1br50kjF6Oy255NGpRz8f 09LMfh85X3iTCTxGjeKUx80T5nKzx/4isLz7DdfOjj/KsjD1ALx/0LHkr0hTfrB1l0jd AsJuIc0FDvghBUlYxNyCVmyotqIItVAbbfHVEHHGZXTL7lUdO8Nx2J6KHQT0kAg39/Es d8ezdBc6eMzJZwEv1EPnk4y433q/t9ES9Dr8yabDhATesTpMEjXN0/piDv7bcQjRL6N3 bSoA== X-Forwarded-Encrypted: i=1; AJvYcCXTCyOk9SycIdpTZsm33pR4zUVdjUzGEc/ekfAZnKl3NXHrQO+ljXwolR+lD5+vSHIUf58cvHrf2rZRm50QQf8m@lists.infradead.org X-Gm-Message-State: AOJu0Ywz0eRAFhnzBha3xhVi9fXYgfHeNneYinKpQoi2qg4yA7cRPsfM hgESPpTqcBbSfXm8LkTECEmKDpfq7bTVe6WBOk5BEtUXGi9gc+IAWQvi1bHnmnCBgdNW//+7fpb NMrbkpEHPNnKkZzkXIQrheab/P2mrNPVyfnJN7aZPpB6yOwdYQrCnXeQey+gecZ7jnrQgB1iz X-Received: by 2002:adf:f005:0:b0:371:8a8e:bf34 with SMTP id ffacd0b85a97d-372fd92b361mr1353631f8f.62.1724242385051; Wed, 21 Aug 2024 05:13:05 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEMB/ggUo/vRUxhw5fu4gZQwLE961KLd/t4ur3YDaHKN+uT6R+5KIUihWYpnfVR7FqX1I8YOw== X-Received: by 2002:adf:f005:0:b0:371:8a8e:bf34 with SMTP id ffacd0b85a97d-372fd92b361mr1353594f8f.62.1724242384136; Wed, 21 Aug 2024 05:13:04 -0700 (PDT) Received: from redhat.com ([2a0d:6fc7:443:61f9:60b2:d178:7b81:4387]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42abefa20b9sm23302285e9.30.2024.08.21.05.12.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Aug 2024 05:13:03 -0700 (PDT) Date: Wed, 21 Aug 2024 08:12:50 -0400 From: "Michael S. Tsirkin" To: Philipp Stanner Cc: Jonathan Corbet , Jens Axboe , Wu Hao , Tom Rix , Moritz Fischer , Xu Yilun , Andy Shevchenko , Linus Walleij , Bartosz Golaszewski , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Alexandre Torgue , Jose Abreu , Maxime Coquelin , Bjorn Helgaas , Alvaro Karsz , Jason Wang , Xuan Zhuo , Eugenio =?iso-8859-1?Q?P=E9rez?= , Richard Cochran , Mark Brown , David Lechner , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Damien Le Moal , Hannes Reinecke , Keith Busch , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, linux-fpga@vger.kernel.org, linux-gpio@vger.kernel.org, netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org, virtualization@lists.linux.dev, stable@vger.kernel.org, Christophe JAILLET Subject: Re: [PATCH v2 7/9] vdpa: solidrun: Fix potential UB bug with devres Message-ID: <20240821081213-mutt-send-email-mst@kernel.org> References: <20240821071842.8591-2-pstanner@redhat.com> <20240821071842.8591-9-pstanner@redhat.com> MIME-Version: 1.0 In-Reply-To: <20240821071842.8591-9-pstanner@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240821_051309_612530_1029097B X-CRM114-Status: GOOD ( 25.13 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Aug 21, 2024 at 09:18:40AM +0200, Philipp Stanner wrote: > In psnet_open_pf_bar() a string later passed to pcim_iomap_regions() is > placed on the stack. Neither pcim_iomap_regions() nor the functions it > calls copy that string. > > Should the string later ever be used, this, consequently, causes > undefined behavior since the stack frame will by then have disappeared. > > Fix the bug by allocating the string on the heap through > devm_kasprintf(). > > Cc: stable@vger.kernel.org # v6.3 > Fixes: 51a8f9d7f587 ("virtio: vdpa: new SolidNET DPU driver.") > Reported-by: Christophe JAILLET > Closes: https://lore.kernel.org/all/74e9109a-ac59-49e2-9b1d-d825c9c9f891@wanadoo.fr/ > Suggested-by: Andy Shevchenko > Signed-off-by: Philipp Stanner I don't get why is this a part of a cleanup series - looks like an unrelated bugfix? > --- > drivers/vdpa/solidrun/snet_main.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/drivers/vdpa/solidrun/snet_main.c b/drivers/vdpa/solidrun/snet_main.c > index 99428a04068d..4d42a05d70fc 100644 > --- a/drivers/vdpa/solidrun/snet_main.c > +++ b/drivers/vdpa/solidrun/snet_main.c > @@ -555,7 +555,7 @@ static const struct vdpa_config_ops snet_config_ops = { > > static int psnet_open_pf_bar(struct pci_dev *pdev, struct psnet *psnet) > { > - char name[50]; > + char *name; > int ret, i, mask = 0; > /* We don't know which BAR will be used to communicate.. > * We will map every bar with len > 0. > @@ -573,7 +573,10 @@ static int psnet_open_pf_bar(struct pci_dev *pdev, struct psnet *psnet) > return -ENODEV; > } > > - snprintf(name, sizeof(name), "psnet[%s]-bars", pci_name(pdev)); > + name = devm_kasprintf(&pdev->dev, GFP_KERNEL, "psnet[%s]-bars", pci_name(pdev)); > + if (!name) > + return -ENOMEM; > + > ret = pcim_iomap_regions(pdev, mask, name); > if (ret) { > SNET_ERR(pdev, "Failed to request and map PCI BARs\n"); > -- > 2.46.0