From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 26B4BC52D6F for ; Wed, 21 Aug 2024 10:28:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=/fb/RuJkeM3aFjdMF0c0Xwmg+kLLocjFSamrIW7BWhs=; b=qlT88LsBvU2mCsb2DE1ODUJGCc UHvDfBbMjVsGWutTTIDvu1al7r5vaZnzMkPTBKfFjnAxwthNJBgCRoP6pYZsbxobExwCRg6tHmFri 9176a/BsK++KoWiCXx7FTvLC7Di/UZlU6AZobL1eSxjMhk92Z8Y3hKgTIfnpn7CtFD4zRCIGbbspW CE483n54TNbZs6SnlxeyMqhPh9wjv8mNsvvuIEzHg1Itk+b39vomiOjnBWnmiqDomjhXOmDzx+eiA 0uDCU1g8FUf0A3tIMARIoEjC9alQG6cbBEfekuuWrW/xYn4gokHo7WT1prcSnv09V44gBD5ieL+LJ OXk6mJDA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sgiZd-00000008PgO-1Yvp; Wed, 21 Aug 2024 10:28:17 +0000 Received: from mail-ed1-x52c.google.com ([2a00:1450:4864:20::52c]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sgiYu-00000008PYF-1uW1 for linux-arm-kernel@lists.infradead.org; Wed, 21 Aug 2024 10:27:33 +0000 Received: by mail-ed1-x52c.google.com with SMTP id 4fb4d7f45d1cf-5bec50de77fso90912a12.2 for ; Wed, 21 Aug 2024 03:27:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1724236051; x=1724840851; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=/fb/RuJkeM3aFjdMF0c0Xwmg+kLLocjFSamrIW7BWhs=; b=gPHs3QT3Hr7N+N4DT5kLhB2ghyD40OTYonwQ01AB0DbLgSzZ9tr2ph1hY/w84eAx3z 44ZXRLaAUghxe3oVHp3BYWnF1RviXIEv2nrFQWEv/dAonjZb2vUzVGv8iFCO2S5GFrhk WJs1XGSzbF6ODIukrp6TXsP5+5jDl8NrYXv4TKJ7cYeWqXx68O9nLs+tH9GyvLKtDveP V0w5zh8E7SopBFnFpLh0RXAjGbnKvff+QsxJL8uq1OG+3qmDsEr1tBfmvAwm2lIf9jnV UU4xnIX6hCBxFaDxXtoKxVirbW4r6nN2qTinPiGN/dEUfj4Za+Smtp1obcZHBrhy6WdA wCDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724236051; x=1724840851; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=/fb/RuJkeM3aFjdMF0c0Xwmg+kLLocjFSamrIW7BWhs=; b=p3JAR2KIvGmGBKtpuy1wo5NIyB5L2o/LpmAqIyRwOx0CWJCW0P3UsxZ6eRertShDSZ 4PdcqDqnea5cr63jN64cGZM5pQuH83c2EaZ1jyVZlWXfZunHI9gT/iM3x9UGJFBiP85r bolL7wSID26P2emvEv5W/J6rMYxiCJKZTkk3G4a7m+g/2akb03hJ+ha8eGPuHQJLmyLf 5Ye1TPhZ/POD/KN/eKBOCGd2XwHRi95mY590tvws14ZjGCFjwdXqlsN1YZyRr6F4Ww4W rohgjjIC387AlVa1q3Re5TtbAWz28E3vYswPRAN1eFpNscwplJXl1ZIKqaRCOLEaVGUu vuUA== X-Forwarded-Encrypted: i=1; AJvYcCW6Mc4SjmGhwJpLtvaT10RMi/KZJZ+jZNkMvpKrbUFNav9dEeFOt0W5xsaheGcmZa0BGse/Wd1HV4iX8KMaTcMx@lists.infradead.org X-Gm-Message-State: AOJu0YzW7ZDqhpA27gFH0WlJq/UVhXL7egGslKHO65FHA71PnZ9ptyLU tiQE00ipu5TNJnANuoB0AAHihQI/XaUnMHaXNS5wPyZUNj8Fba98 X-Google-Smtp-Source: AGHT+IF6e53jlF1aQdWI+jcMWFq1gf/ZzPGVpqcc9Wop3GOkHdEj2yHM0jbnNyjDTQ4O5WbTWDngZg== X-Received: by 2002:a05:6402:13c8:b0:5a0:d706:c1fe with SMTP id 4fb4d7f45d1cf-5bf1f2abe3amr645381a12.6.1724236050235; Wed, 21 Aug 2024 03:27:30 -0700 (PDT) Received: from skbuf ([188.25.134.29]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5becf1f3442sm6465107a12.31.2024.08.21.03.27.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Aug 2024 03:27:29 -0700 (PDT) Date: Wed, 21 Aug 2024 13:27:27 +0300 From: Vladimir Oltean To: Furong Xu <0x1207@gmail.com> Cc: Serge Semin , Andrew Lunn , "David S. Miller" , Alexandre Torgue , Jose Abreu , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , Joao Pinto , netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, xfr@outlook.com Subject: Re: [PATCH net-next v4 3/7] net: stmmac: refactor FPE verification process Message-ID: <20240821102727.qitmm2zxnpva4cqd@skbuf> References: <20240820123456.qbt4emjdjg5pouym@skbuf> <20240821125833.000010f7@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240821125833.000010f7@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240821_032732_522278_65B15225 X-CRM114-Status: GOOD ( 18.38 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Aug 21, 2024 at 12:58:33PM +0800, Furong Xu wrote: > > Hi Vladimir > > On Tue, 20 Aug 2024 15:34:56 +0300, Vladimir Oltean wrote: > > I took the liberty of rewriting the fpe_task to a timer, and delete the > > workqueue. Here is a completely untested patch, which at least is less > > complex, has less code and is easier to understand. What do you think? > > > > Your patch is much better than my ugly implementation ;) Well, to be fair, it took us a number of iterations to properly see how much it could be simplified. > Some small fixes are required to make kselftest-ethtool_mm pass. > > Would you mind if I rebase you patch, fix some small issues, make sure all > test cases pass, split it into two patches and include them in my patchset, > then send to review as a Co-developer and a tester? Please feel free to split up that patch and squash it into your patches, keeping your Author: field and just a Co-developed-by: + Signed-off-by: for me, where parts of that patch helped you.