From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 470A4C52D6F for ; Wed, 21 Aug 2024 04:59:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Subject:Cc:To: From:Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=T1wedJG/Bg4x+50/X/HHJc+xQbgaNB+dhizweD19x0U=; b=oA5JBzlYGw4mS61KGx8HnWlP0T zH/lD0oWmKD4RmlXyifTfnOX7XjN5ke4gMEt6LHkVGMIaxGG6KLsBzu5C3gP1iGIej+3vcYnYhHJZ 5MNOcSc9sAr3hGqoc43Kk0N1jVQ7JQptQF/nvg7ceg8eJAsOQfTIuBNIpzSA7lIm5p46YhZalzBAm v3OmqBIMk0jDCQpV7yeevvzxj+uYKr0QcIEsNy7U0A6vbUPzSNf5Sm2c5duN+LtqBnkgLEwAi7xcF VIsbcfn3g0S53xL5tU0usItJPN58oiTPsLMXunQrK6PzDvO87IGXkD5m65ssslkj3HkTmTG5J7vx1 L4N4FHDA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sgdRR-00000007Wnf-1TiC; Wed, 21 Aug 2024 04:59:29 +0000 Received: from mail-qt1-x832.google.com ([2607:f8b0:4864:20::832]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sgdQj-00000007Wgt-3Gil for linux-arm-kernel@lists.infradead.org; Wed, 21 Aug 2024 04:58:47 +0000 Received: by mail-qt1-x832.google.com with SMTP id d75a77b69052e-454b3d89a18so23483831cf.2 for ; Tue, 20 Aug 2024 21:58:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1724216324; x=1724821124; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=T1wedJG/Bg4x+50/X/HHJc+xQbgaNB+dhizweD19x0U=; b=BSmLTdfE+YM2PLBnRCCv5AvaTVtMVAFH4/5q4ebNhbvOvzWzJB0Ho/IfQawdguv+k5 WiFPkCOHS4qOd3jTuYekax4iaYtPjp7nqYOGO159zEFPZUhq66JIb0eAHlg+09TC5gbR FqwXyEpxldteseH+HND5FxPXhzadwbsGaW8L8L9T6jj04GgIPQBLkgDSYHRjEp5V/mfk a4jZuhMa8NRRwrxdzucrR7k+jC3LwHgCZZP+EyB1b5VyPGlYNLHVkNAzKrBeGNTqPbl9 vAG2W7D/V3xcreQqSUNlTjGwfColezFJVE8zOjLZAier/jhuRvCMGaKjLG+LNZlmAUR0 3dsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724216324; x=1724821124; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=T1wedJG/Bg4x+50/X/HHJc+xQbgaNB+dhizweD19x0U=; b=feRQfA86daL23htVSVvMUx1mhcYClcg2IFFZTtoL/UltwpGrEGZn4Qh4EQnvFL/nuz JMXgiwxccme45SBD/Dh5adeXETMVC0sRrzGlkzFVOfKcC/h0zpRVEn3IM2wH2oKWwjhP +C/z0mx6gsi3Ro1XwqrT7M7FUC0kUtntqGXsIN07brpcXIgzcjz8LU3DKsOfwRpPDXov SsHiZC07lsz9xb5vfP3rm61/IEpiwbeM04q8NOGGtdvzUaSl/8E/Cr1ho8dvRkqhgg+q G9XeT9Evt+268699Ma+5UHvdSmnhDvVVvjd2lB2frxh3KkmP32DZsyBmzVjPohV+tLTA D/Qg== X-Forwarded-Encrypted: i=1; AJvYcCXULsXlyhNcwlsroReTaF/EnXH+AcIltJDbn+RY8DE+yUwhi1mjZYaLcOqhAsS1YkiF1chmxOiETelbWxDb+tyW@lists.infradead.org X-Gm-Message-State: AOJu0Yy1UNQLk2SNKqLf0dUhXbEwDGG1Y4WscbJW9ZsukTW63P3uAada UoxcAdOPRC5+Iw4EPtL7kUFfo8K+fhGaYGe9NfB48gQP4N0GcAoi X-Google-Smtp-Source: AGHT+IGBo/S81CZz7j4bai9R3gFPYkz5tE2gxC9VhQUqFp/OT85vnumLFVbQZK7aG2h8zR+dajr5uA== X-Received: by 2002:a05:622a:4a13:b0:446:5a63:d68f with SMTP id d75a77b69052e-454f21ed913mr12368381cf.18.1724216324316; Tue, 20 Aug 2024 21:58:44 -0700 (PDT) Received: from localhost ([129.146.253.192]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-4536a0035c6sm56215401cf.42.2024.08.20.21.58.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Aug 2024 21:58:44 -0700 (PDT) Date: Wed, 21 Aug 2024 12:58:33 +0800 From: Furong Xu <0x1207@gmail.com> To: Vladimir Oltean Cc: Serge Semin , Andrew Lunn , "David S. Miller" , Alexandre Torgue , Jose Abreu , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , Joao Pinto , netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, xfr@outlook.com Subject: Re: [PATCH net-next v4 3/7] net: stmmac: refactor FPE verification process Message-ID: <20240821125833.000010f7@gmail.com> In-Reply-To: <20240820123456.qbt4emjdjg5pouym@skbuf> References: <20240820123456.qbt4emjdjg5pouym@skbuf> X-Mailer: Claws Mail 4.3.0 (GTK 3.24.42; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240820_215845_851856_C698FDAB X-CRM114-Status: GOOD ( 11.98 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Vladimir On Tue, 20 Aug 2024 15:34:56 +0300, Vladimir Oltean wrote: > I took the liberty of rewriting the fpe_task to a timer, and delete the > workqueue. Here is a completely untested patch, which at least is less > complex, has less code and is easier to understand. What do you think? > Your patch is much better than my ugly implementation ;) Some small fixes are required to make kselftest-ethtool_mm pass. Would you mind if I rebase you patch, fix some small issues, make sure all test cases pass, split it into two patches and include them in my patchset, then send to review as a Co-developer and a tester? Thanks.