From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 16ECFC52D7C for ; Wed, 21 Aug 2024 13:29:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Type:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To :Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=p4BRcHmXjTpD//6+7woCGDQMb6NChfm/jSnBKcCozBA=; b=wr5jj75pZy8vZr9Dlm7pIEN0uG s0HduP0Lz+s4kCH9gTMSVYVFS8issqXlCA3bEmGmOIR1F5hVdFzcuM9609mnspQP3vqKK5HzWfPXL gmo7t0zTXXLeFKkN8iT+3LlogLvHF9I+p84devh45aPM2uGrOX5XyWlwNWXyd26z+0AgQAed2HWCI 0iWLSWHeBVAM+4RZ39GASvHODDElYpXm7bMJCZ1vQfWRFqiVqQP6dzD0lX6pcSLpjXF6yMKkQ7Ogo yl3uf7VJtVnaS/PDhG9e+xAapSKXMxxpoFhF9RcMBiKGQupUqFOcajm27SSDei9EEbnqzDOfndXey c+zgXYVg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sglOT-0000000988j-39wu; Wed, 21 Aug 2024 13:28:57 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sglNc-000000097t8-06ss; Wed, 21 Aug 2024 13:28:13 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 345BF6102C; Wed, 21 Aug 2024 13:28:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 913DFC4AF0C; Wed, 21 Aug 2024 13:27:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1724246882; bh=EfwypYdM33lZ/G4fq92xQyPXwP/Q8lFk9UP+Y3zqev8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=N8y/D6ajVEV0BAph5QjS9IHl8V1bvulMD2qXUH9Q329DJmK+yb2x2l0ySSjgh0jM7 7/Q0QvG+wLcf6PqhaFlxQqY1ELM375gZZzB/4FykmIP405NOoDF+1h+mrRwcMBuG/0 2s3YycJls0/7SB/Fbw6aGK1kbi2sSueaGCscT8OYR7I5faFBfDcygYB6qH9qeaqY08 qnDenq4c3K3Mi00VqH1ClQy5fvXOIkQVAceypb2DEXf5bD2nNYSTfTPGRfGGs1QkWS denv1ouRjB1LTDk4dt3OYgly9vkwtPm1XYK8fqNcvosizMDRoo+uTa70uTUAfXRg98 qI9Wpn51OmS2Q== Date: Wed, 21 Aug 2024 14:27:54 +0100 From: Simon Horman To: Andrea della Porta Subject: Re: [PATCH 07/11] pinctrl: rp1: Implement RaspberryPi RP1 gpio support Message-ID: <20240821132754.GC6387@kernel.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240821_062804_139170_83CE4E43 X-CRM114-Status: GOOD ( 14.19 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Lunn , Catalin Marinas , Michael Turquette , Claudiu Beznea , Eric Dumazet , Dragan Cvetic , Will Deacon , linux-clk@vger.kernel.org, linux-arch@vger.kernel.org, Rob Herring , Florian Fainelli , Lee Jones , Saravana Kannan , Broadcom internal kernel review list , linux-pci@vger.kernel.org, Jakub Kicinski , Paolo Abeni , Linus Walleij , devicetree@vger.kernel.org, Conor Dooley , Arnd Bergmann , linux-gpio@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, Bjorn Helgaas , linux-arm-kernel@lists.infradead.org, Derek Kiernan , Stephen Boyd , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Stefan Wahren , netdev@vger.kernel.org, Krzysztof Kozlowski , "David S. Miller" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Aug 20, 2024 at 04:36:09PM +0200, Andrea della Porta wrote: > The RP1 is an MFD supporting a gpio controller and /pinmux/pinctrl. > Add minimum support for the gpio only portion. The driver is in > pinctrl folder since upcoming patches will add the pinmux/pinctrl > support where the gpio part can be seen as an addition. > > Signed-off-by: Andrea della Porta ... > diff --git a/drivers/pinctrl/pinctrl-rp1.c b/drivers/pinctrl/pinctrl-rp1.c ... > +const struct rp1_iobank_desc rp1_iobanks[RP1_NUM_BANKS] = { > + /* gpio inte ints rio pads */ > + { 0, 28, 0x0000, 0x011c, 0x0124, 0x0000, 0x0004 }, > + { 28, 6, 0x4000, 0x411c, 0x4124, 0x4000, 0x4004 }, > + { 34, 20, 0x8000, 0x811c, 0x8124, 0x8000, 0x8004 }, > +}; rp1_iobanks seems to only be used in this file. If so, it should be static. Flagged by Sparse. ...