From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Alexander Dahl <ada@thorsis.com>
Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>,
"Gustavo A. R. Silva" <gustavoars@kernel.org>,
open list <linux-kernel@vger.kernel.org>,
Vignesh Raghavendra <vigneshr@ti.com>,
Kees Cook <kees@kernel.org>, Richard Weinberger <richard@nod.at>,
Claudiu Beznea <claudiu.beznea@tuxon.dev>,
linux-mtd@lists.infradead.org,
"moderated list:ARM/Microchip AT91 SoC support"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] mtd: nand: raw: atmel: Add message on DMA usage
Date: Wed, 21 Aug 2024 15:17:01 +0200 [thread overview]
Message-ID: <20240821151701.6bde9aba@xps-13> (raw)
In-Reply-To: <20240821120517.330868-1-ada@thorsis.com>
Hi Alexander,
ada@thorsis.com wrote on Wed, 21 Aug 2024 14:05:16 +0200:
> Like for other atmel drivers (serial, crypto, mmc, …), too.
>
> Signed-off-by: Alexander Dahl <ada@thorsis.com>
> ---
> drivers/mtd/nand/raw/atmel/nand-controller.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/mtd/nand/raw/atmel/nand-controller.c b/drivers/mtd/nand/raw/atmel/nand-controller.c
> index dc75d50d52e8..9e6dea2cf140 100644
> --- a/drivers/mtd/nand/raw/atmel/nand-controller.c
> +++ b/drivers/mtd/nand/raw/atmel/nand-controller.c
> @@ -2051,6 +2051,8 @@ static int atmel_nand_controller_init(struct atmel_nand_controller *nc,
> nc->dmac = dma_request_channel(mask, NULL, NULL);
> if (!nc->dmac)
> dev_err(nc->dev, "Failed to request DMA channel\n");
> + dev_info(nc->dev, "using %s for DMA transfers\n",
> + dma_chan_name(nc->dmac));
The message here would be misleading if !nc->dmac.
> }
>
> /* We do not retrieve the SMC syscon when parsing old DTs. */
>
> base-commit: 47ac09b91befbb6a235ab620c32af719f8208399
Thanks,
Miquèl
next prev parent reply other threads:[~2024-08-21 13:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-21 12:05 [PATCH] mtd: nand: raw: atmel: Add message on DMA usage Alexander Dahl
2024-08-21 13:17 ` Miquel Raynal [this message]
2024-08-21 13:20 ` Alexander Dahl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240821151701.6bde9aba@xps-13 \
--to=miquel.raynal@bootlin.com \
--cc=ada@thorsis.com \
--cc=alexandre.belloni@bootlin.com \
--cc=claudiu.beznea@tuxon.dev \
--cc=gustavoars@kernel.org \
--cc=kees@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=richard@nod.at \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox