From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C84C0C52D7C for ; Thu, 22 Aug 2024 16:47:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=SP7nWHkiqy6r/7xKza503+47iX/WSQpmBJYVMovmgbg=; b=N68lxXDqTo9axoNzy6ozvxhn1I vneGv1r3EPhojEduZiZhOrrg8d5rpE0i4O68KnU6Rj1zSyjKvLwd7LDr09DSM5eA9/+Br/uOp29j3 E3azLwy0sswGchmd0vHYvoNbZGPWpVId9ZgMDb/LTMAkqiqf68L7XaRJS104A8zX4iV/tAdYoPTiD OtfP46vA3OpA6Wtf2XWEz94ZJFxS4n1hBbbEwG9bzQ9BcJYejprxdPtEfwfXbJvPsD5nL2Eepyagk FyZBSehfAfDvWrC9JCHQ7IF09ZAqjfIrgBLAuzKCEcwhbTHzW7U4KnsujyAP/mMutssmAq7QbuHYw ZJQ/baXA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1shAxb-0000000DemP-2ZNn; Thu, 22 Aug 2024 16:46:55 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1shAvp-0000000De6D-3UMC; Thu, 22 Aug 2024 16:45:07 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 142956125A; Thu, 22 Aug 2024 16:45:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4B23FC32782; Thu, 22 Aug 2024 16:45:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1724345104; bh=WrlN+67fyl/9DMCWCvghwD06kAjbzcfn6dDe7h6wxn0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=V4Mir6Jc65AVcAqoR1k1S8yF13+rBZctf7bvL/1PJOJZH1+tn/cUFuXSSIj3n6OLh h6Ce4waDtOd1SmjSD60mAYoIDQBWkGqUkG+SGPBgIphiOa2WzMRP+MorOfnhPCnRDT hWwdbbVFkcqYf7GTjDz7I66oPm1LHWs/YIXqTphXQ9224UBr2s1o9Fe5csRUA2Vbrd 51O3KQGws+QdU31tzIICRFzBZCtcCKgVk9ew5yQdsmUxcRybXXQASNOvoR6W3Y5XDY sNVmKDWoJCXsdP9rXgrsfV4TCKl/7smifMGk+AszUjvCk0gCZGNxnuWGoMp8hfLDuA wlM0bISIJAmqg== Date: Thu, 22 Aug 2024 17:44:58 +0100 From: Conor Dooley To: Claudiu Cc: vkoul@kernel.org, kishon@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, p.zabel@pengutronix.de, geert+renesas@glider.be, magnus.damm@gmail.com, gregkh@linuxfoundation.org, mturquette@baylibre.com, sboyd@kernel.org, yoshihiro.shimoda.uh@renesas.com, biju.das.jz@bp.renesas.com, ulf.hansson@linaro.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-pm@vger.kernel.org, Claudiu Beznea Subject: Re: [PATCH 02/16] dt-bindings: soc: renesas: renesas,rzg2l-sysc: Add #reset-cells for RZ/G3S Message-ID: <20240822-mountain-hurdle-dd1f08b96f64@spud> References: <20240822152801.602318-1-claudiu.beznea.uj@bp.renesas.com> <20240822152801.602318-3-claudiu.beznea.uj@bp.renesas.com> <20240822-vanilla-enigmatic-f0b05ecca4b6@spud> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ZWzRvO3ns8+wP6rp" Content-Disposition: inline In-Reply-To: <20240822-vanilla-enigmatic-f0b05ecca4b6@spud> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240822_094506_291037_495D6B66 X-CRM114-Status: GOOD ( 19.70 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --ZWzRvO3ns8+wP6rp Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Aug 22, 2024 at 05:42:57PM +0100, Conor Dooley wrote: > On Thu, Aug 22, 2024 at 06:27:47PM +0300, Claudiu wrote: > > From: Claudiu Beznea > >=20 > > The RZ/G3S System controller has registers to control signals that need > > to be de-asserted/asserted before/after different SoC areas are power > > on/off. This signals are implemented as reset signals. For this document > > the #reset-cells property. > >=20 > > Signed-off-by: Claudiu Beznea > > --- > > .../bindings/soc/renesas/renesas,rzg2l-sysc.yaml | 16 ++++++++++++++++ > > 1 file changed, 16 insertions(+) > >=20 > > diff --git a/Documentation/devicetree/bindings/soc/renesas/renesas,rzg2= l-sysc.yaml b/Documentation/devicetree/bindings/soc/renesas/renesas,rzg2l-s= ysc.yaml > > index 4386b2c3fa4d..6b0bb34485d9 100644 > > --- a/Documentation/devicetree/bindings/soc/renesas/renesas,rzg2l-sysc.= yaml > > +++ b/Documentation/devicetree/bindings/soc/renesas/renesas,rzg2l-sysc.= yaml > > @@ -42,12 +42,28 @@ properties: > > - const: cm33stbyr_int > > - const: ca55_deny > > =20 > > + "#reset-cells": > > + const: 1 > > + > > required: > > - compatible > > - reg > > =20 > > additionalProperties: false > > =20 > > +allOf: > > + - if: > > + properties: > > + compatible: > > + contains: > > + const: renesas,r9a08g045-sysc > > + then: > > + required: > > + - "#reset-cells" >=20 > Given this is new required property on an existing platform, I'd expect > some mention of why it used to be okay to not have this but is now > required. Did firmware or a bootloader stage take things out of reset? Reading a bit more into the series, the peripherals in question were just never used nor did a driver for the sysc exist, so there's neither explanation of prior behaviour nor concerns about compatibility? >=20 > > + else: > > + properties: > > + "#reset-cells": false > > + > > examples: > > - | > > #include > > --=20 > > 2.39.2 > >=20 --ZWzRvO3ns8+wP6rp Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZsdrCgAKCRB4tDGHoIJi 0uG8AP9KErhuqHGo0goHh4p9RoWQWSQLtxDDIaGI6XDc4GYpEAD/af+u+5EQKxfW u6mEr8fG1pmimijNTGtbSERV+00abgY= =TCjP -----END PGP SIGNATURE----- --ZWzRvO3ns8+wP6rp--