From: Conor Dooley <conor@kernel.org>
To: "Heiko Stübner" <heiko@sntech.de>
Cc: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>,
Andrzej Hajda <andrzej.hajda@intel.com>,
Neil Armstrong <neil.armstrong@linaro.org>,
Robert Foss <rfoss@kernel.org>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
Jonas Karlman <jonas@kwiboo.se>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
Sandy Huang <hjc@rock-chips.com>,
Andy Yan <andy.yan@rock-chips.com>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Mark Yao <markyao0591@gmail.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org,
kernel@collabora.com, Alexandre ARNOUD <aarnoud@me.com>,
Luis de Arquer <ldearquer@gmail.com>
Subject: Re: [PATCH v4 3/4] dt-bindings: display: rockchip: Add schema for RK3588 HDMI TX Controller
Date: Thu, 22 Aug 2024 09:41:10 +0100 [thread overview]
Message-ID: <20240822-pushchair-premises-f4055779216a@spud> (raw)
In-Reply-To: <4167579.6PsWsQAL7t@diego>
[-- Attachment #1: Type: text/plain, Size: 1023 bytes --]
On Thu, Aug 22, 2024 at 09:01:34AM +0200, Heiko Stübner wrote:
> @Conor: just for me, did some shift happen in our understanding of dt-
> best-practices in terms of syscon via phandle vs. syscon via compatible?
>
> Because Rockchip boards are referencing their GRFs via phandes forever
> but similar to the soc vs non-soc node thing, I'd like to stay on top of
> best-practices ;-)
If IP blocks, and thus drivers, are going to be reused between devices,
using the phandles makes sense given that it is unlikely that syscon
nodes can make use of fallback compatibles due to bits within that "glue"
changing between devices. It also makes sense when there are multiple
instances of an IP on the device, which need to use different syscons.
My goal is to ask people why they are using these type of syscons
phandle properties, cos often they are not required at all - for example
with clocks where you effectively need a whole new driver for every
single soc and having a phandle property buys you nothing.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2024-08-22 9:46 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240819-b4-rk3588-bridge-upstream-v4-0-6417c72a2749@collabora.com>
[not found] ` <20240819-b4-rk3588-bridge-upstream-v4-3-6417c72a2749@collabora.com>
2024-08-19 16:53 ` [PATCH v4 3/4] dt-bindings: display: rockchip: Add schema for RK3588 HDMI TX Controller Conor Dooley
[not found] ` <ec84bc0b-c4c2-4735-9f34-52bc3a852aaf@collabora.com>
2024-08-20 16:14 ` Conor Dooley
[not found] ` <038073d0-d4b9-4938-9a51-ea2aeb4530f6@collabora.com>
2024-08-21 15:07 ` Conor Dooley
[not found] ` <5813cea2-4890-4fa9-8826-19be5bf3e161@collabora.com>
2024-08-21 21:28 ` Conor Dooley
2024-08-21 21:38 ` Heiko Stuebner
[not found] ` <2085e998-a453-4893-9e80-3be68b0fb13d@collabora.com>
2024-08-22 7:01 ` Heiko Stübner
2024-08-22 8:41 ` Conor Dooley [this message]
[not found] ` <7fc8cbc3-43d0-43d2-9272-350ac556e2b2@collabora.com>
2024-08-23 1:01 ` Andy Yan
2024-08-23 16:02 ` Conor Dooley
2024-08-23 10:47 ` Heiko Stübner
2024-08-23 15:59 ` Conor Dooley
[not found] ` <20240819-b4-rk3588-bridge-upstream-v4-2-6417c72a2749@collabora.com>
2024-08-27 8:58 ` [PATCH v4 2/4] drm/bridge: synopsys: Add DW HDMI QP TX Controller support library Maxime Ripard
[not found] ` <34422b7a-ce70-445d-a574-60ac36322119@collabora.com>
2024-09-02 7:36 ` Maxime Ripard
[not found] ` <6e20410a-a24d-4454-8577-2cff65319a2a@collabora.com>
2024-09-03 8:09 ` Maxime Ripard
2024-09-06 1:25 ` Cristian Ciocaltea
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240822-pushchair-premises-f4055779216a@spud \
--to=conor@kernel.org \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=aarnoud@me.com \
--cc=airlied@gmail.com \
--cc=andrzej.hajda@intel.com \
--cc=andy.yan@rock-chips.com \
--cc=conor+dt@kernel.org \
--cc=cristian.ciocaltea@collabora.com \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=heiko@sntech.de \
--cc=hjc@rock-chips.com \
--cc=jernej.skrabec@gmail.com \
--cc=jonas@kwiboo.se \
--cc=kernel@collabora.com \
--cc=krzk+dt@kernel.org \
--cc=ldearquer@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=markyao0591@gmail.com \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=rfoss@kernel.org \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).