From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 26A6FC52D7C for ; Thu, 22 Aug 2024 16:14:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=c+ylB1g2uSkLLHcJdlxztR35Si4TDIglWdtbljocQ8Y=; b=B9gXHN8B4S+HSzhjPA8angPXVZ suBeWtY6NqnLSk9xffgB6nJgpbgERF3tEKMwwTvQvvTQqrAXLxCNBtnEdu/6EFtj6FI8olATiJIP4 e3L6+q/XbYrTF81HTGK/i31UPvZCrVCZjP+bi1CSMnafaSYX/AQ7LddlqvEblMRAq+HQdeHWfFOjE nSGpj2oXR2BxX2kwZk+9GOT6yCFgELGAlFM3NJQNkuxgt9Sw65ul+ByBsZt7IpXaH8U6Q/qrEzJGC df/Qzw/J4I6CEDbUg8YsJUSxUcU264ZF8mrbxQqxTRT52R8IaEVGm4gOlR7NW42Wt72IU48R1sj6B 00+p4WMA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1shARz-0000000DXVp-2wON; Thu, 22 Aug 2024 16:14:15 +0000 Received: from nyc.source.kernel.org ([2604:1380:45d1:ec00::3]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1shAKo-0000000DVuH-1dGA; Thu, 22 Aug 2024 16:06:51 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id ABFA4A40B28; Thu, 22 Aug 2024 16:06:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 27058C4AF0B; Thu, 22 Aug 2024 16:06:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1724342809; bh=JKSc2pCJPHiBPYG6O9itMsD/N2edGQ/08PARRYFbmoI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=YCLoBA6wK8HES0FLgfc3r7p3Ru9S+uWShWHV6U2bduADrNBxYRHYMnkOnIHGsttl9 sjbtOtDejqqhu0hiMg+FQSmBCotX5JNMyTPMxXIBixGBQAMwV93LEwSHP1HRNeKjzi BvkKOjlYiKSlqujAelZfBsUYKMtsHrhj6NeeRo6TIZet+iOdvxVbh+twWZ0I109THi CtOfdiu6gWyo4mqB0C8iTN/fj88Il4RTdbsNVZxoLgJ9/qB8ShBoJAhpLkXaxjrtJ1 rFtIroybZd3RB/4hjrnHEdpt3MxtHWV4LytV1fNDJE1MjjjpqG9og5qGovqU2ghEqp PoGwLrdks5XAw== Date: Thu, 22 Aug 2024 17:06:44 +0100 From: Conor Dooley To: Lorenzo Bianconi Cc: Linus Walleij , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Sean Wang , Matthias Brugger , AngeloGioacchino Del Regno , linux-mediatek@lists.infradead.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, upstream@airoha.com, benjamin.larsson@genexis.eu, ansuelsmth@gmail.com Subject: Re: [PATCH v2 1/2] dt-bindings: pinctrl: airoha: Add EN7581 pinctrl controller Message-ID: <20240822-taste-deceptive-03d0ad56ae2e@spud> References: <20240822-en7581-pinctrl-v2-0-ba1559173a7f@kernel.org> <20240822-en7581-pinctrl-v2-1-ba1559173a7f@kernel.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Keq2bc7KVkSdMDBF" Content-Disposition: inline In-Reply-To: <20240822-en7581-pinctrl-v2-1-ba1559173a7f@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240822_090650_575772_72481744 X-CRM114-Status: GOOD ( 13.94 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --Keq2bc7KVkSdMDBF Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Aug 22, 2024 at 11:40:52AM +0200, Lorenzo Bianconi wrote: > Introduce device-tree binding documentation for Airoha EN7581 pinctrl > controller. >=20 > Signed-off-by: Lorenzo Bianconi > + reg: > + items: > + - description: IOMUX base address > + - description: LED IOMUX base address > + - description: GPIO flash mode base address > + - description: GPIO flash mode extended base address > + - description: IO pin configuration base address > + - description: PCIE reset open-drain base address > + - description: GPIO bank0 register base address > + - description: GPIO bank0 second control register base address > + - description: GPIO bank1 second control register base address > + - description: GPIO bank1 register base address > + pinctrl@1fa20214 { > + compatible =3D "airoha,en7581-pinctrl"; > + reg =3D <0x0 0x1fa20214 0x0 0x30>, > + <0x0 0x1fa2027c 0x0 0x8>, > + <0x0 0x1fbf0234 0x0 0x4>, > + <0x0 0x1fbf0268 0x0 0x4>, > + <0x0 0x1fa2001c 0x0 0x50>, > + <0x0 0x1fa2018c 0x0 0x4>, > + <0x0 0x1fbf0200 0x0 0x18>, > + <0x0 0x1fbf0220 0x0 0x4>, > + <0x0 0x1fbf0260 0x0 0x8>, > + <0x0 0x1fbf0270 0x0 0x28>; > + reg-names =3D "iomux", "led-iomux", > + "gpio-flash-mode", "gpio-flash-mode-ext", > + "ioconf", "pcie-rst-od", > + "gpio-bank0", "gpio-ctrl1", > + "gpio-ctrl2", "gpio-bank1"; before looking at v1: I would really like to see an explanation for why this is a correct model of the hardware as part of the commit message. To me this screams syscon/MFD and instead of describing this as a child of a syscon and using regmap to access it you're doing whatever this is... after looking at v1: AFAICT the PWM driver does not currently exist in mainline, so I am now doubly of the opinion that this needs to be an MFD and a wee bit annoyed that you didn't include any rationale in your cover letter or w/e for not going with an MFD given there was discussion on the topic in v1. Thanks, Conor. --Keq2bc7KVkSdMDBF Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZsdiEwAKCRB4tDGHoIJi 0uKZAQDj5+09ic83KcLDIq5zWWJ09DULVEuilCvZB8SXAroqgAD+Jui9Hf6JNAuM 9ieVzZOf+irfrtrGnPCFLrkKqBC7hAQ= =dqn2 -----END PGP SIGNATURE----- --Keq2bc7KVkSdMDBF--