From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D25ADC3DA4A for ; Thu, 22 Aug 2024 04:28:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ad4qoWniChf82T5QGfPwPbkTF1xeh7rL6ZYeNrU8hmY=; b=oDKOjadKaZP1xtdFl1JjMK4IGm zm2qKsDTyZxUdvIZSEn7oCGlVQeWpc+QNk+ZUDxktblUJV/pkkGiAuQPbOrC0Zrg3mQhaRhZ6ZaXM 80rB8yYAK38jf2dbn4KaFpcZYQdH/1lQaCOZPKHAjo2cK5kkkcGXm0AArEQI0JqiW+S0uKkl5Bsy+ I2Gp8XYbTJ2sVWD5rVGvXTycq7Lc2pTB8E2BOGubc02oeajk2R9dV2HCaQCL8USlF5huJPLhPOVz8 LbcN1GWMhTKwe4KdiquTzpsMlGGLN2cTG2JPsurSsbZCnMi9s80iR/gOahsze0OSGlk9oZF+FQnjx fx7fO29w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sgzRG-0000000BNLk-0TNS; Thu, 22 Aug 2024 04:28:46 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sgzQ2-0000000BMyp-1FLX; Thu, 22 Aug 2024 04:27:31 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 6175160F5A; Thu, 22 Aug 2024 04:27:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5ABF1C4AF09; Thu, 22 Aug 2024 04:27:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1724300849; bh=7V+H9aiy6Hmq4hq9uhSZuA59Ro8lxYpKbAXrcA3sXLw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=v+ZgCF6eGa392JfISoJqCnTuDfcClAdh4ysQ90tWOJT9KwmDps2Ub8yXHB8VBfEt9 gNm4EtxXR0XFMPuBd3fS7RWPUvFAoIt55q2o82p/TP/yq2vaQjH7uS3t9fbsq+VMv7 CFVcp8RUFyDabTFc+aKR7xr/50PvrmGpZ4Joa0EU= Date: Thu, 22 Aug 2024 12:27:26 +0800 From: Greg Kroah-Hartman To: Lei Liu Cc: Neal Liu , Joel Stanley , Andrew Jeffery , Daniel Mack , Haojian Zhuang , Robert Jarzmik , Conor Dooley , Daire McNamara , Bin Liu , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , linux-aspeed@lists.ozlabs.org, linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, opensource.kernel@vivo.com Subject: Re: [PATCH v1 0/5] usb drivers use devm_clk_get_enabled() helpers Message-ID: <2024082210-stadium-sly-cf06@gregkh> References: <20240822040734.29412-1-liulei.rjpt@vivo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240822040734.29412-1-liulei.rjpt@vivo.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240821_212730_676630_EDB0EF27 X-CRM114-Status: GOOD ( 12.04 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Aug 22, 2024 at 12:07:25PM +0800, Lei Liu wrote: > The devm_clk_get_enabled() helpers: > - call devm_clk_get() > - call clk_prepare_enable() and register what is needed in order to > call clk_disable_unprepare() when needed, as a managed resource. > > This simplifies the code and avoids calls to clk_disable_unprepare(). > > --- > The files ux500.c, mpfs.c, and pxa27x_udc.c have incorrect usage of > certain interfaces due to the lack of synchronization during the > commit updates. These issues have been corrected in the v1 version. > > version 1 changes > 1.ux500: Incorrect usage of clk_prepare_enable() should be corrected to > devm_clk_get_enabled(). > 2.mpfs: Incorrect usage of devm_clk_get_enable() should be corrected to > devm_clk_get_enabled(). > 3.pxa27x_udc: Incorrect usage of clk_prepare_enable() should be > corrected to devm_clk_get_enabled(). Patch versions start at 1, this should be 2, right?