From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7BC2EC3DA4A for ; Thu, 22 Aug 2024 11:13:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=BbJ9Z+sMrkclfRagtYJm2Qhjn1slaJi07OZtLt0xRqg=; b=GLuwcn2xpBR2xKHAdDcNTrvfqW 87MAMpGd5zGLeTzhgoQUfW42DC50+fxX9qu1Bg/8lvMNHWuuL4jsEP9Y9axisGPgQUdvCjouFnFTV IAaooPouoFNnzb1Q4ZwTEumXZrTc+wiMF/u2OS8aVFo6iYLD6Uy0ViZwrJgu9hcqBL7V2DDt49xUW ceAXB0Hijv984mQ27cucWUw+6dMo+SBiv5YWL2S+Rjom6Ez3yEd/gtLHOihZYJp8i0gAzy1IgRhPZ WahpaWM6ZLM21JzRiDpiOJD/3vqc6+dQTb5T6t37lAbEg2r0t7T5CdYpl+ECqn58Dncww0zpQ+14Q 6mi1dc3Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sh5kV-0000000CXBC-1FBB; Thu, 22 Aug 2024 11:13:03 +0000 Received: from mail-pf1-x436.google.com ([2607:f8b0:4864:20::436]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sh5jk-0000000CX3x-3z23 for linux-arm-kernel@lists.infradead.org; Thu, 22 Aug 2024 11:12:18 +0000 Received: by mail-pf1-x436.google.com with SMTP id d2e1a72fcca58-7141b04e7a3so543274b3a.3 for ; Thu, 22 Aug 2024 04:12:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1724325136; x=1724929936; darn=lists.infradead.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=BbJ9Z+sMrkclfRagtYJm2Qhjn1slaJi07OZtLt0xRqg=; b=yIVHK51QrNfncxtNUl0GtA9eOPOriVSVfCevvKSyqR+XiwlCgx4UK6YMTTH//S/T8n 7oxbw1DPwKLG+sm3KBV0TN8vmtn0UIdM0wFdbB9/lwFvGTKuGURhw95v1TF5JQDcDq0b vl8xGIT+6Zi9Fy0Sr7305pCWCWENGv5JP0qiroohUR6/cBgsztyJhKgMWWkPsnB+dpZ8 +6QlexxXtI/vd2J+ffsRzwW3EXgljc9MqvG/S6o2o6Q1yHLlR/mXR9Ja64ZqsDAqChjI Hf6rtrgLibos6QoPyez6lSSCGpJozvoJdt+RgLNsrosn4ug6wcNEuv0h+GpqhOJEgvlU hsrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724325136; x=1724929936; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=BbJ9Z+sMrkclfRagtYJm2Qhjn1slaJi07OZtLt0xRqg=; b=ATJgiOe548pVV+PYMh+3gdd3pgKHyqjc76hQUYPyaumPhVu+gYt3IWvc/2n2hRmQmC /0Pu6MdWzSWe8UvtyTkEAa6YX+r4pnca1Ju4PVGXqI/xLB1AlgcKcRkLYoi09n/xwYBC L5iX/SNGM3hirko69KKDz5YgtGMBPwtgmmfCAxonst6Z6z7Grd6jnfOsEBD7Bwze53cw ZoQ4w2Pqj/mlapFCLhittffibe/k00Ii5zP+dl2Y4V0xfXWF4U/b25BMVNSLroghwZrV IX0eQ6gcgh8gWzkZdZQ/yi0Yv44F/uj+htbqavN3lJkwJH9hqmzV+55J2xm+zufM66R0 a73g== X-Forwarded-Encrypted: i=1; AJvYcCUT3auYFe4yzom4L8/ziAYNYPUgTlXSNRxr0/e7fvDwpkWOURWMylPjo8MTOBn579b+tj6udld3X5hXRT2tDoGT@lists.infradead.org X-Gm-Message-State: AOJu0Yzn2fxP/ol7r77/0QPCmjybzyH5nopdvv7ONG1MgzsFYG9AXikx tEKfnBRRCGkGi85rpM3uwkxob1cJvd4icSNAcaf2nNzXlv6C4VelH8Jxu29zxA== X-Google-Smtp-Source: AGHT+IGzybvAIUuXxPl7dmKySzy1eKxeJTiu0SQmcSr83L0+MazI/R/cvJax85qZEJ7fPuLq07i6aA== X-Received: by 2002:a05:6a20:9313:b0:1ca:da6d:675f with SMTP id adf61e73a8af0-1cada6d79e0mr4593437637.0.1724325135657; Thu, 22 Aug 2024 04:12:15 -0700 (PDT) Received: from thinkpad ([117.213.99.42]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-7cd9acdc7c6sm978832a12.46.2024.08.22.04.12.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Aug 2024 04:12:15 -0700 (PDT) Date: Thu, 22 Aug 2024 16:42:07 +0530 From: Manivannan Sadhasivam To: Pranjal Shrivastava Cc: Rob Clark , iommu@lists.linux.dev, linux-arm-msm@vger.kernel.org, Stephen Boyd , Robin Murphy , Rob Clark , Will Deacon , Joerg Roedel , Jason Gunthorpe , Jerry Snitselaar , Rob Herring , Krzysztof Kozlowski , Georgi Djakov , Dmitry Baryshkov , "moderated list:ARM SMMU DRIVERS" , open list Subject: Re: [PATCH v3 3/3] iommu/arm-smmu: Pretty-print context fault related regs Message-ID: <20240822111207.vbotlrtw72vflefj@thinkpad> References: <20240701162025.375134-1-robdclark@gmail.com> <20240701162025.375134-4-robdclark@gmail.com> <20240822100941.3tfqpjskzq43slfw@thinkpad> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240822_041217_014938_4220BD3B X-CRM114-Status: GOOD ( 24.79 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Aug 22, 2024 at 10:31:45AM +0000, Pranjal Shrivastava wrote: > On Thu, Aug 22, 2024 at 03:39:41PM +0530, Manivannan Sadhasivam wrote: > > On Mon, Jul 01, 2024 at 09:20:12AM -0700, Rob Clark wrote: > > > From: Rob Clark > > > > > > Parse out the bitfields for easier-to-read fault messages. > > > > > > Signed-off-by: Rob Clark > > > --- > > > .../iommu/arm/arm-smmu/arm-smmu-qcom-debug.c | 52 +++++--------- > > > drivers/iommu/arm/arm-smmu/arm-smmu.c | 70 +++++++++++++++---- > > > drivers/iommu/arm/arm-smmu/arm-smmu.h | 21 ++++++ > > > 3 files changed, 92 insertions(+), 51 deletions(-) > > > > > > > [...] > > > > > diff --git a/drivers/iommu/arm/arm-smmu/arm-smmu.c b/drivers/iommu/arm/arm-smmu/arm-smmu.c > > > index 23cf91ac409b..79ec911ae151 100644 > > > --- a/drivers/iommu/arm/arm-smmu/arm-smmu.c > > > +++ b/drivers/iommu/arm/arm-smmu/arm-smmu.c > > > @@ -405,32 +405,72 @@ static const struct iommu_flush_ops arm_smmu_s2_tlb_ops_v1 = { > > > .tlb_add_page = arm_smmu_tlb_add_page_s2_v1, > > > }; > > > > > > + > > > +void arm_smmu_read_context_fault_info(struct arm_smmu_device *smmu, int idx, > > > + struct arm_smmu_context_fault_info *cfi) > > > +{ > > > + cfi->iova = arm_smmu_cb_readq(smmu, idx, ARM_SMMU_CB_FAR); > > > + cfi->fsr = arm_smmu_cb_read(smmu, idx, ARM_SMMU_CB_FSR); > > > + cfi->fsynr = arm_smmu_cb_read(smmu, idx, ARM_SMMU_CB_FSYNR0); > > > + cfi->cbfrsynra = arm_smmu_gr1_read(smmu, ARM_SMMU_GR1_CBFRSYNRA(idx)); > > > +} > > > + > > > +void arm_smmu_print_context_fault_info(struct arm_smmu_device *smmu, int idx, > > > + const struct arm_smmu_context_fault_info *cfi) > > > +{ > > > + dev_dbg(smmu->dev, > > > + "Unhandled context fault: fsr=0x%x, iova=0x%08lx, fsynr=0x%x, cbfrsynra=0x%x, cb=%d\n", > > > + cfi->fsr, cfi->iova, cfi->fsynr, cfi->cbfrsynra, idx); > > > + > > > > I just happen to hit an IOMMU fault in 6.11-rc4 and I did not see the 'Unhandled > > context fault' log, but just the register dump in dmesg. Tracking that lead me > > to this patch. > > > > May I know the reasoning behind making the actual error message _dbg()? It is > > intentional first place? > > > > - Mani > > Hi Mani, > > That was a miss in this series, but it was fixed recently in [1]. > I think it should land soon. > > [1] https://lore.kernel.org/linux-iommu/172381862229.1794487.17068761066364130246.b4-ty@kernel.org/ > Cool, thanks! - Mani -- மணிவண்ணன் சதாசிவம்