From: Sean Anderson <sean.anderson@linux.dev>
To: Radhey Shyam Pandey <radhey.shyam.pandey@amd.com>,
netdev@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org,
Eric Dumazet <edumazet@google.com>,
Michal Simek <michal.simek@amd.com>, Andrew Lunn <andrew@lunn.ch>,
Daniel Borkmann <daniel@iogearbox.net>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
linux-kernel@vger.kernel.org, Paolo Abeni <pabeni@redhat.com>,
Sean Anderson <sean.anderson@linux.dev>,
Simon Horman <horms@kernel.org>
Subject: [PATCH net-next v3 1/5] net: xilinx: axienet: Always disable promiscuous mode
Date: Thu, 22 Aug 2024 11:40:55 -0400 [thread overview]
Message-ID: <20240822154059.1066595-2-sean.anderson@linux.dev> (raw)
In-Reply-To: <20240822154059.1066595-1-sean.anderson@linux.dev>
If promiscuous mode is disabled when there are fewer than four multicast
addresses, then it will not be reflected in the hardware. Fix this by
always clearing the promiscuous mode flag even when we program multicast
addresses.
Fixes: 8a3b7a252dca ("drivers/net/ethernet/xilinx: added Xilinx AXI Ethernet driver")
Signed-off-by: Sean Anderson <sean.anderson@linux.dev>
Reviewed-by: Simon Horman <horms@kernel.org>
---
(no changes since v1)
drivers/net/ethernet/xilinx/xilinx_axienet_main.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
index 38f7b764fe66..6fad473a937b 100644
--- a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
+++ b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
@@ -451,6 +451,10 @@ static void axienet_set_multicast_list(struct net_device *ndev)
} else if (!netdev_mc_empty(ndev)) {
struct netdev_hw_addr *ha;
+ reg = axienet_ior(lp, XAE_FMI_OFFSET);
+ reg &= ~XAE_FMI_PM_MASK;
+ axienet_iow(lp, XAE_FMI_OFFSET, reg);
+
i = 0;
netdev_for_each_mc_addr(ha, ndev) {
if (i >= XAE_MULTICAST_CAM_TABLE_NUM)
--
2.35.1.1320.gc452695387.dirty
next prev parent reply other threads:[~2024-08-22 15:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-22 15:40 [PATCH net-next v3 0/5] net: xilinx: axienet: Multicast fixes and improvements Sean Anderson
2024-08-22 15:40 ` Sean Anderson [this message]
2024-08-22 15:40 ` [PATCH net-next v3 2/5] net: xilinx: axienet: Fix dangling multicast addresses Sean Anderson
2024-08-22 15:40 ` [PATCH net-next v3 3/5] net: xilinx: axienet: Don't print if we go into promiscuous mode Sean Anderson
2024-08-22 15:40 ` [PATCH net-next v3 4/5] net: xilinx: axienet: Don't set IFF_PROMISC in ndev->flags Sean Anderson
2024-08-22 15:40 ` [PATCH net-next v3 5/5] net: xilinx: axienet: Support IFF_ALLMULTI Sean Anderson
2024-08-22 20:10 ` [PATCH net-next v3 0/5] net: xilinx: axienet: Multicast fixes and improvements patchwork-bot+netdevbpf
2024-08-26 17:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240822154059.1066595-2-sean.anderson@linux.dev \
--to=sean.anderson@linux.dev \
--cc=andrew@lunn.ch \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@amd.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=radhey.shyam.pandey@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).