From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A1FCBC3DA4A for ; Thu, 22 Aug 2024 05:15:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=XjUR5Tb1VXaF4t/8xDfEPIE2apiuHdG5X2S2kS9PUjA=; b=n1ZKUKby6L2RCot4N29DS2IeoC 3tiZez/AuT4EDaBHhaeQ7QyM7u5o3xtS9S93YEWO2LWNOKeRNEFLj1b1R+3pCxKJFlEP+2oz9O8qa eXIy5BjZQElU0aauHhy6QLBDu01vPjIgU3CA1bFoTCrO4oyaMCp4ic3H0IFT9/hUFOYu3GeFT7XmP zHhZhgM82sE1hdSQ8zJbFarhIwrMiLfxVJO+as9NpQZ6Gs73VE7Spzlk+KYLwQVwsnX01oIkC6O/u I4D4jA+ZjCONa4bKh3z77fvu64V9+0awBJKa9OJ+A86qUah+6xm2wtaw1KKHnx5gCzKaNP9mkLniD 3XVnEoNg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sh0AW-0000000BRYz-1t7b; Thu, 22 Aug 2024 05:15:32 +0000 Received: from sin.source.kernel.org ([145.40.73.55]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sh09m-0000000BRNN-3DZs; Thu, 22 Aug 2024 05:14:48 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id C88D0CE0FAA; Thu, 22 Aug 2024 05:14:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 81A4FC4AF0C; Thu, 22 Aug 2024 05:14:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1724303684; bh=ngDz7AVNJAUvMqiSy4yLF8BEcn3Ug63o03RV0QSI7As=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=bvmPV9NXqdombM0PixL1Rz1L8hnVmLhM/nT7uN//JOYsQ4ikNMF4yIjWioKyAHi7U i1IPgzSne267LhLUlNoDVXZKlNvHax8kXpgU9jOIBr4GZP6TvgTZNiVgQkETYXemrQ oWf4eUnU3vvEMu6Tf16e32MKRtt5lGZ+5sHH+XHo= Date: Thu, 22 Aug 2024 13:14:41 +0800 From: Greg Kroah-Hartman To: Lei Liu Cc: Neal Liu , Joel Stanley , Andrew Jeffery , Daniel Mack , Haojian Zhuang , Robert Jarzmik , Conor Dooley , Daire McNamara , Bin Liu , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , linux-aspeed@lists.ozlabs.org, linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, opensource.kernel@vivo.com Subject: Re: [PATCH v1 0/5] usb drivers use devm_clk_get_enabled() helpers Message-ID: <2024082227-sports-resource-9c65@gregkh> References: <20240822040734.29412-1-liulei.rjpt@vivo.com> <2024082210-stadium-sly-cf06@gregkh> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240821_221447_009356_7232EE52 X-CRM114-Status: GOOD ( 15.78 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Aug 22, 2024 at 12:46:10PM +0800, Lei Liu wrote: > > on 2024/8/22 12:27, Greg Kroah-Hartman wrote: > > On Thu, Aug 22, 2024 at 12:07:25PM +0800, Lei Liu wrote: > > > The devm_clk_get_enabled() helpers: > > > - call devm_clk_get() > > > - call clk_prepare_enable() and register what is needed in order to > > > call clk_disable_unprepare() when needed, as a managed resource. > > > > > > This simplifies the code and avoids calls to clk_disable_unprepare(). > > > > > > --- > > > The files ux500.c, mpfs.c, and pxa27x_udc.c have incorrect usage of > > > certain interfaces due to the lack of synchronization during the > > > commit updates. These issues have been corrected in the v1 version. > > > > > > version 1 changes > > > 1.ux500: Incorrect usage of clk_prepare_enable() should be corrected to > > > devm_clk_get_enabled(). > > > 2.mpfs: Incorrect usage of devm_clk_get_enable() should be corrected to > > > devm_clk_get_enabled(). > > > 3.pxa27x_udc: Incorrect usage of clk_prepare_enable() should be > > > corrected to devm_clk_get_enabled(). > > Patch versions start at 1, this should be 2, right? > > Hi，Do I need to update the patch from v1 to v2 again? Yes please, otherwise our tools will get confused. greg k-h