From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D9C1CC52D7C for ; Fri, 23 Aug 2024 11:44:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Subject:CC:To: From:Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Vca7X5jITDevHPvsvS0T3V9M6W+Tjova17YSHSNG3ws=; b=CLL8x8Qt4JWsKIE5LcnPKd3wRY Wc8WXoitfClOAO/sS1PT3jkGacJvNQzkAwnoisiS+JJiDNdq1q4nMbPGMLvY4wpqjgZcM405z3MGc Biv6G0wETJ/HLWVS/VGLZDQNHnVu6ZwNVhyqmSar9INu2l7bm0rtpkU1s1XRciTQOdoNqxmcvTu6V Kuj2RrM0BsdXGBCTPMM82qDQUj+oSyhdWHQMypc6DM7g0PnxfVRUoNRgOD3ec3S41gx5AtD0MHx/r ClhwC/DAiK8abPE9H6USrCyEmd0IwBwCbSUntVjCc++Vs9AVmA6i7pyZs3UoNFOkxfaNPOGpJZq/7 Y6IOAi5w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1shSiE-0000000GZJb-3EQl; Fri, 23 Aug 2024 11:44:14 +0000 Received: from frasgout.his.huawei.com ([185.176.79.56]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1shSeo-0000000GYdu-2Fzr for linux-arm-kernel@lists.infradead.org; Fri, 23 Aug 2024 11:40:43 +0000 Received: from mail.maildlp.com (unknown [172.18.186.216]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4Wqyhd71Sxz6K6j6; Fri, 23 Aug 2024 19:36:49 +0800 (CST) Received: from lhrpeml500005.china.huawei.com (unknown [7.191.163.240]) by mail.maildlp.com (Postfix) with ESMTPS id E4E661400DB; Fri, 23 Aug 2024 19:40:34 +0800 (CST) Received: from localhost (10.203.177.66) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Fri, 23 Aug 2024 12:40:34 +0100 Date: Fri, 23 Aug 2024 12:40:33 +0100 From: Jonathan Cameron To: Krzysztof Kozlowski CC: Santosh Shilimkar , Krzysztof Kozlowski , Roger Quadros , Tony Lindgren , Vladimir Zapolskiy , Miquel Raynal , Michal Simek , , , Subject: Re: [PATCH 2/7] memory: emif: simplify locking with guard() Message-ID: <20240823124033.00007f76@Huawei.com> In-Reply-To: <20240823-b4-cleanup-h-guard-v1-2-01668915bd55@linaro.org> References: <20240823-b4-cleanup-h-guard-v1-0-01668915bd55@linaro.org> <20240823-b4-cleanup-h-guard-v1-2-01668915bd55@linaro.org> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.203.177.66] X-ClientProxiedBy: lhrpeml100001.china.huawei.com (7.191.160.183) To lhrpeml500005.china.huawei.com (7.191.163.240) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240823_044042_750101_022DB73D X-CRM114-Status: UNSURE ( 6.69 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 23 Aug 2024 12:15:57 +0200 Krzysztof Kozlowski wrote: > Simplify error handling (less gotos) over locks with guard(). > > The driver used file-scope variable 'irq_state' for storing IRQ state > with spin_lock_irqsave, so move it into respective local scopes. This > should be equivalent, but more readable (less global variables). > > Signed-off-by: Krzysztof Kozlowski > LGTM. File scoped irq_state is certainly unusual... Reviewed-by: Jonathan Cameron