From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 36B01C52D7C for ; Fri, 23 Aug 2024 11:48:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Subject:CC:To: From:Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=/pb7x9y/c3TssqLp0/zM4ip+tSsQq6WyLFNpWez3B8k=; b=P03ImO9F9lXhAhR5wCP08WZpfv SqUYrgNlXyG3533ztaRevCmR9cJo7DD2IjG+NvGU0kyv9sAQ26xB5AD164H07qPFnNr1kjivFImts SNw92efAjJdm8vlmoHAjpX/qDaScGDw2GD7VGemeY8s6s1BMjdSeWmEdDqda9b9nLoYf56/wEX9I4 YfPCOjRivlTiSGFLgcmQK/1gqCN1xHkqXhO1+V/1gLn+6PwfWBKW3afB3SKiGEotNXuYcGAJ/BKsr oOmw1PoT0E44n03iYI01dADaZPtBuIuKZ7RMmL8TbtJBoJgUAgqDK6k6FBsaRoBTo3V9/J/8ucDj6 BNoAtjRA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1shSmW-0000000Ga1L-1Vug; Fri, 23 Aug 2024 11:48:40 +0000 Received: from frasgout.his.huawei.com ([185.176.79.56]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1shSkp-0000000GZlu-1N1c for linux-arm-kernel@lists.infradead.org; Fri, 23 Aug 2024 11:46:56 +0000 Received: from mail.maildlp.com (unknown [172.18.186.31]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4Wqyrd0b16z6K9Nk; Fri, 23 Aug 2024 19:43:45 +0800 (CST) Received: from lhrpeml500005.china.huawei.com (unknown [7.191.163.240]) by mail.maildlp.com (Postfix) with ESMTPS id 7B5F8140A70; Fri, 23 Aug 2024 19:46:49 +0800 (CST) Received: from localhost (10.203.177.66) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Fri, 23 Aug 2024 12:46:49 +0100 Date: Fri, 23 Aug 2024 12:46:48 +0100 From: Jonathan Cameron To: Krzysztof Kozlowski CC: Santosh Shilimkar , Krzysztof Kozlowski , Roger Quadros , Tony Lindgren , Vladimir Zapolskiy , Miquel Raynal , Michal Simek , , , Subject: Re: [PATCH 4/7] memory: pl172: simplify with dev_err_probe() Message-ID: <20240823124648.0000692b@Huawei.com> In-Reply-To: <20240823-b4-cleanup-h-guard-v1-4-01668915bd55@linaro.org> References: <20240823-b4-cleanup-h-guard-v1-0-01668915bd55@linaro.org> <20240823-b4-cleanup-h-guard-v1-4-01668915bd55@linaro.org> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.203.177.66] X-ClientProxiedBy: lhrpeml100001.china.huawei.com (7.191.160.183) To lhrpeml500005.china.huawei.com (7.191.163.240) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240823_044655_548975_2421034E X-CRM114-Status: GOOD ( 13.76 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 23 Aug 2024 12:15:59 +0200 Krzysztof Kozlowski wrote: > Use dev_err_probe() to avoid dmesg flood on actual defer. This makes > the code also simpler. > > Signed-off-by: Krzysztof Kozlowski FWIW Reviewed-by: Jonathan Cameron > --- > drivers/memory/pl172.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/drivers/memory/pl172.c b/drivers/memory/pl172.c > index 9eb8cc7de494..390012401f64 100644 > --- a/drivers/memory/pl172.c > +++ b/drivers/memory/pl172.c > @@ -217,10 +217,9 @@ static int pl172_probe(struct amba_device *adev, const struct amba_id *id) > return -ENOMEM; > > pl172->clk = devm_clk_get(dev, "mpmcclk"); > - if (IS_ERR(pl172->clk)) { > - dev_err(dev, "no mpmcclk provided clock\n"); > - return PTR_ERR(pl172->clk); > - } > + if (IS_ERR(pl172->clk)) > + return dev_err_probe(dev, PTR_ERR(pl172->clk), > + "no mpmcclk provided clock\n"); > > ret = clk_prepare_enable(pl172->clk); > if (ret) { >