From: Will Deacon <will@kernel.org>
To: Trilok Soni <quic_tsoni@quicinc.com>
Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Konrad Dybcio <konradybcio@gmail.com>,
Rob Clark <robdclark@gmail.com>,
Konrad Dybcio <konradybcio@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Robin Murphy <robin.murphy@arm.com>,
Joerg Roedel <joro@8bytes.org>,
Marijn Suijten <marijn.suijten@somainline.org>,
iommu@lists.linux.dev, linux-arm-msm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Sumit Semwal <sumit.semwal@linaro.org>
Subject: Re: [PATCH] iommu/arm-smmu-qcom: Work around SDM845 Adreno SMMU w/ 16K pages
Date: Fri, 23 Aug 2024 16:21:48 +0100 [thread overview]
Message-ID: <20240823152147.GA396@willie-the-truck> (raw)
In-Reply-To: <d766e2e8-9f3f-af3a-bb5e-633b11bce941@quicinc.com>
On Tue, Jul 30, 2024 at 10:16:00AM -0700, Trilok Soni wrote:
> On 7/30/2024 1:50 AM, Dmitry Baryshkov wrote:
> >>>>>> SDM845's Adreno SMMU is unique in that it actually advertizes support
> >>>>>> for 16K (and 32M) pages, which doesn't hold for newer SoCs.
> > My question is about forbidding 16k pages for sdm845 only or for other
> > chips too. I'd assume that it shouldn't also work for other smmu-v2
> > platforms.
>
> Yes, my understanding was that SMMUv2 based IPs doesn't have 16k support
> and it is only starting from SMMUv3.
I'm not sure about that. The architecture doc for SMMUv2 talks about the
AArch64 translation regime in section 1.5 and bit 13 of SMMU_IDR2 says:
| PTFSv8_16kB, bit[13]
| Support for 16KB translation granule size. The possible values of this bit are:
| 0 The 16KB translation granule is not supported.
| 1 The 16KB translation granule is supported.
| In SMMUv1, this bit is reserved.
so I think Konrad's patch is about right, but if you want to extend it
to cover other implementations then that's fine too.
Will
next prev parent reply other threads:[~2024-08-23 15:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-29 8:37 [PATCH] iommu/arm-smmu-qcom: Work around SDM845 Adreno SMMU w/ 16K pages Konrad Dybcio
2024-07-29 20:14 ` Dmitry Baryshkov
2024-07-29 21:07 ` Rob Clark
2024-07-29 21:21 ` Dmitry Baryshkov
2024-07-30 8:08 ` Konrad Dybcio
2024-07-30 8:50 ` Dmitry Baryshkov
2024-07-30 10:12 ` Konrad Dybcio
2024-07-30 15:57 ` Rob Clark
2024-07-30 17:16 ` Trilok Soni
2024-08-23 15:21 ` Will Deacon [this message]
2024-08-23 17:15 ` Rob Clark
2024-07-30 16:39 ` Rob Clark
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240823152147.GA396@willie-the-truck \
--to=will@kernel.org \
--cc=andersson@kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=iommu@lists.linux.dev \
--cc=joro@8bytes.org \
--cc=konrad.dybcio@linaro.org \
--cc=konradybcio@gmail.com \
--cc=konradybcio@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=quic_tsoni@quicinc.com \
--cc=robdclark@gmail.com \
--cc=robin.murphy@arm.com \
--cc=sumit.semwal@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox