From: Nishanth Menon <nm@ti.com>
To: Bhavya Kapoor <b-kapoor@ti.com>
Cc: <linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>, <conor+dt@kernel.org>,
<krzk+dt@kernel.org>, <robh@kernel.org>, <kristo@kernel.org>,
<jm@ti.com>, <vigneshr@ti.com>
Subject: Re: [RESEND PATCH] arm64: dts: ti: k3-j722s-evm: Add support for multiple CAN instances
Date: Sat, 24 Aug 2024 12:43:37 -0500 [thread overview]
Message-ID: <20240824174337.lixnpedg24qaroxs@headed> (raw)
In-Reply-To: <20240808082030.2812216-1-b-kapoor@ti.com>
On 13:50-20240808, Bhavya Kapoor wrote:
> CAN instances 0 and 1 in the mcu domain and 0 in the main domain are
> brought on the evm through headers J5, J8 and J10 respectively. Thus,
> add their respective transceiver's 0, 1 and 2 dt nodes as well as
> add the required pinmux to add support for these CAN instances.
>
> Signed-off-by: Bhavya Kapoor <b-kapoor@ti.com>
> Reviewed-by: Judith Mendez <jm@ti.com>
[...]
> +&main_mcan0 {
> + status = "okay";
NAK: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/dts-coding-style.rst#n117
> + pinctrl-names = "default";
> + pinctrl-0 = <&main_mcan0_pins_default>;
> + phys = <&transceiver2>;
> +};
> +
> +&mcu_gpio0 {
> + status = "okay";
> +};
> --
> 2.34.1
>
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
prev parent reply other threads:[~2024-08-24 17:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-08 8:20 [RESEND PATCH] arm64: dts: ti: k3-j722s-evm: Add support for multiple CAN instances Bhavya Kapoor
2024-08-24 17:43 ` Nishanth Menon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240824174337.lixnpedg24qaroxs@headed \
--to=nm@ti.com \
--cc=b-kapoor@ti.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jm@ti.com \
--cc=kristo@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox