Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Nishanth Menon <nm@ti.com>
To: Bhavya Kapoor <b-kapoor@ti.com>
Cc: <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<vigneshr@ti.com>, <kristo@kernel.org>, <robh@kernel.org>,
	<krzk+dt@kernel.org>, <conor+dt@kernel.org>,
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] arm64: dts: ti: Add PWM and ECAP overlay for J722S-EVM
Date: Sat, 24 Aug 2024 13:12:18 -0500	[thread overview]
Message-ID: <20240824181218.zvymim3jonknmvm2@rearrange> (raw)
In-Reply-To: <20240820070607.30628-1-b-kapoor@ti.com>

On 12:36-20240820, Bhavya Kapoor wrote:
> The J722S-EVM has 3 PWM outputs and 1 ECAP output routed
> to the J28 connector. This overlay will set the appropriate
> pinmux and enable PWM and ECAP on the pins.

So, change the base evm default. do you have a daughter card that this
overlay represents? Then name this as the daughter card, provide a link
etc. If we start accepting ever pin mux combination, there is no end to
configurations we will get. Sorry.

> 
> Currently enabled PWM output on J28: 29, 31, 33 pins
> and ECAP output on J28: 32 pin
> 
> Signed-off-by: Bhavya Kapoor <b-kapoor@ti.com>
> ---
>  arch/arm64/boot/dts/ti/Makefile              |  1 +
>  arch/arm64/boot/dts/ti/k3-j722s-evm-pwm.dtso | 53 ++++++++++++++++++++
>  2 files changed, 54 insertions(+)
>  create mode 100644 arch/arm64/boot/dts/ti/k3-j722s-evm-pwm.dtso
> 
> diff --git a/arch/arm64/boot/dts/ti/Makefile b/arch/arm64/boot/dts/ti/Makefile
> index e20b27ddf901..61d51284dcba 100644
> --- a/arch/arm64/boot/dts/ti/Makefile
> +++ b/arch/arm64/boot/dts/ti/Makefile
> @@ -111,6 +111,7 @@ dtb-$(CONFIG_ARCH_K3) += k3-j721s2-evm-pcie1-ep.dtbo
>  
>  # Boards with J722s SoC
>  dtb-$(CONFIG_ARCH_K3) += k3-j722s-evm.dtb
> +dtb-$(CONFIG_ARCH_K3) += k3-j722s-evm-pwm.dtbo
>  
>  # Boards with J784s4 SoC
>  dtb-$(CONFIG_ARCH_K3) += k3-am69-sk.dtb
> diff --git a/arch/arm64/boot/dts/ti/k3-j722s-evm-pwm.dtso b/arch/arm64/boot/dts/ti/k3-j722s-evm-pwm.dtso
> new file mode 100644
> index 000000000000..f6d1f072b140
> --- /dev/null
> +++ b/arch/arm64/boot/dts/ti/k3-j722s-evm-pwm.dtso
> @@ -0,0 +1,53 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/**
> + * DT Overlay for enabling PWM output on User Expansion header on J722S-EVM
> + *
> + * Copyright (C) 2024 Texas Instruments Incorporated - https://www.ti.com/
> + */
> +
> +/dts-v1/;
> +/plugin/;
> +
> +#include <dt-bindings/gpio/gpio.h>
> +#include "k3-pinctrl.h"
> +
> +&main_pmx0 {
> +
> +	main_epwm0_pins_default: main-epwm0-default-pins {
> +		pinctrl-single,pins = <
> +			J722S_IOPAD(0x01b4, PIN_OUTPUT, 2) /* (B20) EHRPWM0_A */
> +		>;
> +	};
> +
> +	main_epwm1_pins_default: main-epwm1-default-pins {
> +		pinctrl-single,pins = <
> +			J722S_IOPAD(0x01bc, PIN_OUTPUT, 2) /* (D20) EHRPWM1_A */
> +			J722S_IOPAD(0x01c0, PIN_OUTPUT, 2) /* (E19) EHRPWM1_B */
> +		>;
> +	};
> +
> +	main_ecap0_pins_default: main-ecap0-default-pins {
> +		pinctrl-single,pins = <
> +			J722S_IOPAD(0x01b8, PIN_OUTPUT, 3) /* (C20) ECAP0_IN_APWM_OUT */
> +		>;
> +	};
> +};
> +
> +&epwm0 {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&main_epwm0_pins_default>;
> +	status = "okay";
> +};
> +
> +&epwm1 {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&main_epwm1_pins_default>;
> +	status = "okay";
> +};
> +
> +&ecap0 {
> +	/* ECAP in APWM mode */
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&main_ecap0_pins_default>;
> +	status = "okay";
> +};
> -- 
> 2.34.1
> 

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D


      reply	other threads:[~2024-08-24 18:13 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-20  7:06 [PATCH] arm64: dts: ti: Add PWM and ECAP overlay for J722S-EVM Bhavya Kapoor
2024-08-24 18:12 ` Nishanth Menon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240824181218.zvymim3jonknmvm2@rearrange \
    --to=nm@ti.com \
    --cc=b-kapoor@ti.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=kristo@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox