From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AB5C7C5321E for ; Sun, 25 Aug 2024 08:13:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=sSgHuusttk35m3TQkJELJyaQO7sfsjM6S8yuf1zPI/Q=; b=DTuew/88BXnV8MpKRvFXhqOxTZ pnZbGxyrWG4vfIuGuZ8KUJCkfmwyvZrHld/grUy2k1O9I/ujXwNwc6VSvKzvpjZmC12XkIB968FKA I5ByesL2hf9t/8aVs9xUEP+UYgl99hbYF5Fce0c38a2pkoxgcxyzk5wTtDYb2xRIQbrckIittG6M9 bj0GExvCX211mpsANvV+y01zUx2dLfJ4egJDT0APh/a/KWW7kH/IdqiLpziYB+4/Z4barheRs6ccE S4ayvjPOE5K69ylFMqEOlQxdAo0Bc1UxHLAgpo6+VlaOqZoS9ZfnHmR/KSO8sCtGpHANM+ON+e7SQ rXpewg8A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1si8N5-00000003vve-1OE1; Sun, 25 Aug 2024 08:13:11 +0000 Received: from sin.source.kernel.org ([145.40.73.55]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1si8MJ-00000003vog-3Xl9 for linux-arm-kernel@lists.infradead.org; Sun, 25 Aug 2024 08:12:25 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 49C17CE0AC3; Sun, 25 Aug 2024 08:12:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A3C75C32782; Sun, 25 Aug 2024 08:12:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1724573538; bh=UBJg/iM7uY+1hECYggabeakTTuQ/H8eQYbeWh2Ylcbk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=jV39yAUr3oj5PCWyeXwTH1jEb/cp3DHkw6dy8KQjpxF0xQzV+gTM4P6xaHpEA6aPk LKxl/q1+HM914asIfNrm8/eiuSXBk4gcW2JyzBRubcBzK1asPpmGjLnpeRVEwo6baZ VAhhcALmxzOqywCHYEwg/xvAx0ke8DdhocYKCtFZi1m30vPmcyy4tln+9lUw5Ij547 iMtqygSr7pqyhiFRCzM/jXHPJmCzR0GWsGFmX+3daOykVEILZkLya4lXO2uqNQnZt3 kJygI6d3WGSL2YnoVOgXlaCm62Vpew6OEkRa1i46CDB6NtPyGzkvOAwlSvzcEjJ81E SD6RqF9TqGFFw== Date: Sun, 25 Aug 2024 09:12:14 +0100 From: Simon Horman To: Yue Haibing Cc: sgoutham@marvell.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next] net: thunderx: Remove unused declarations Message-ID: <20240825081214.GV2164@kernel.org> References: <20240824082754.3637963-1-yuehaibing@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240824082754.3637963-1-yuehaibing@huawei.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240825_011224_079201_C3EFA371 X-CRM114-Status: GOOD ( 10.14 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Aug 24, 2024 at 04:27:54PM +0800, Yue Haibing wrote: > Commit 4863dea3fab0 ("net: Adding support for Cavium ThunderX network > controller") declared nicvf_qset_reg_{write,read}() but never implemented. > > Commit 4863dea3fab0 ("net: Adding support for Cavium ThunderX network > controller") declared bgx_add_dmac_addr() but no implementation. > > After commit 5fc7cf179449 ("net: thunderx: Cleanup PHY probing code.") > octeon_mdiobus_force_mod_depencency() is not used any more. Maybe not so important, but perhaps it is worth mentioning that the implementation of octeon_mdiobus_force_mod_depencency was subsequently removed from the tree in commit 791e5f61aec5 ("net: phy: mdio-octeon: Cleanup module loading dependencies"). > Signed-off-by: Yue Haibing I checked and all these symbols are indeed neither used nor implemented as described above. And, my comment above notwithstanding, the cited commits also look correct to me. Reviewed-by: Simon Horman