Re: [PATCH] dt-bindings: mfd: mediatek,mt6357: Fixup reference to pwrap node

Macpaul Lin
2024-08-30T11:46:52Z

On 8/26/24 23:50, Conor Dooley wrote:
> On Mon, Aug 26, 2024 at 02:54:15PM +0800, Macpaul Lin wrote:
>> The mt6357 is a subnode of pwrap node. Previously, the documentation
>> only included a note in the description of mt6357. This change adds the
>> appropriate $ref for pwrap to ensure clarity and correctness.
>
> I think this change is wrong and the existing binding is fine.
> Adding the ref overcomplicates the binding completely, and stating that
> this is a child node of another device is sufficient.
>
> Instead, if anything, the pwrap binding should have a ref to /this/
> binding.
>
> Thanks,
> Conor.

Thanks for the clarification of this parent-child relationship of the
binding. Will apply to further conversion tasks.

There are many PMIC devices belongs to the pwrap bindings. Hope I'll
have time to fix this soon.

>>
>> $ref: /schemas/soc/mediatek/mediatek,pwrap.yaml
>>
>> Additionally, the indentation for the pmic section has been adjusted
>> to match the corresponding structure.

Best regards,
Macpaul Lin