* [PATCH -next RESEND 00/10] mtd: Use for_each_child_of_node_scoped()
@ 2024-08-26 9:43 Jinjie Ruan
2024-08-26 9:43 ` [PATCH -next RESEND 01/10] mtd: rawnand: arasan: " Jinjie Ruan
` (10 more replies)
0 siblings, 11 replies; 30+ messages in thread
From: Jinjie Ruan @ 2024-08-26 9:43 UTC (permalink / raw)
To: miquel.raynal, michal.simek, richard, vigneshr, liang.yang,
neil.armstrong, khilman, jbrunet, martin.blumenstingl,
matthias.bgg, angelogioacchino.delregno, heiko, mcoquelin.stm32,
alexandre.torgue, wens, jernej.skrabec, samuel, kees, ruanjinjie,
gustavoars, linux, robh, u.kleine-koenig, erick.archer,
christophe.jaillet, val, christophe.kerello, linux-mtd,
linux-kernel, linux-arm-kernel, linux-amlogic, linux-mediatek,
linux-renesas-soc, linux-rockchip, linux-stm32, krzk, jic23
Use scoped for_each_available_child_of_node_scoped() when iterating over
device nodes to make code a bit simpler.
Jinjie Ruan (10):
mtd: rawnand: arasan: Use for_each_child_of_node_scoped()
mtd: rawnand: cadence: Use for_each_child_of_node_scoped()
mtd: rawnand: pl353: Use for_each_child_of_node_scoped()
mtd: rawnand: marvell: drm/rockchip: Use
for_each_child_of_node_scoped()
mtd: rawnand: rockchip: Use for_each_child_of_node_scoped()
mtd: rawnand: meson: Use for_each_child_of_node_scoped()
mtd: rawnand: mtk: Use for_each_child_of_node_scoped()
mtd: rawnand: renesas: Use for_each_child_of_node_scoped()
mtd: rawnand: stm32_fmc2: Use for_each_child_of_node_scoped()
mtd: rawnand: sunxi: Use for_each_child_of_node_scoped()
drivers/mtd/nand/raw/arasan-nand-controller.c | 5 ++---
drivers/mtd/nand/raw/cadence-nand-controller.c | 4 +---
drivers/mtd/nand/raw/marvell_nand.c | 12 +++---------
drivers/mtd/nand/raw/meson_nand.c | 4 +---
drivers/mtd/nand/raw/mtk_nand.c | 7 ++-----
drivers/mtd/nand/raw/pl35x-nand-controller.c | 5 ++---
drivers/mtd/nand/raw/renesas-nand-controller.c | 12 +++---------
drivers/mtd/nand/raw/rockchip-nand-controller.c | 5 ++---
drivers/mtd/nand/raw/stm32_fmc2_nand.c | 7 ++-----
drivers/mtd/nand/raw/sunxi_nand.c | 4 +---
10 files changed, 19 insertions(+), 46 deletions(-)
--
2.34.1
^ permalink raw reply [flat|nested] 30+ messages in thread
* [PATCH -next RESEND 01/10] mtd: rawnand: arasan: Use for_each_child_of_node_scoped()
2024-08-26 9:43 [PATCH -next RESEND 00/10] mtd: Use for_each_child_of_node_scoped() Jinjie Ruan
@ 2024-08-26 9:43 ` Jinjie Ruan
2024-09-06 15:04 ` Miquel Raynal
2024-08-26 9:43 ` [PATCH -next RESEND 02/10] mtd: rawnand: cadence: " Jinjie Ruan
` (9 subsequent siblings)
10 siblings, 1 reply; 30+ messages in thread
From: Jinjie Ruan @ 2024-08-26 9:43 UTC (permalink / raw)
To: miquel.raynal, michal.simek, richard, vigneshr, liang.yang,
neil.armstrong, khilman, jbrunet, martin.blumenstingl,
matthias.bgg, angelogioacchino.delregno, heiko, mcoquelin.stm32,
alexandre.torgue, wens, jernej.skrabec, samuel, kees, ruanjinjie,
gustavoars, linux, robh, u.kleine-koenig, erick.archer,
christophe.jaillet, val, christophe.kerello, linux-mtd,
linux-kernel, linux-arm-kernel, linux-amlogic, linux-mediatek,
linux-renesas-soc, linux-rockchip, linux-stm32, krzk, jic23
Avoids the need for manual cleanup of_node_put() in early exits
from the loop.
Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
---
drivers/mtd/nand/raw/arasan-nand-controller.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/mtd/nand/raw/arasan-nand-controller.c b/drivers/mtd/nand/raw/arasan-nand-controller.c
index 2ff1d2b13e3c..5436ec4a8fde 100644
--- a/drivers/mtd/nand/raw/arasan-nand-controller.c
+++ b/drivers/mtd/nand/raw/arasan-nand-controller.c
@@ -1360,7 +1360,7 @@ static void anfc_chips_cleanup(struct arasan_nfc *nfc)
static int anfc_chips_init(struct arasan_nfc *nfc)
{
- struct device_node *np = nfc->dev->of_node, *nand_np;
+ struct device_node *np = nfc->dev->of_node;
int nchips = of_get_child_count(np);
int ret;
@@ -1370,10 +1370,9 @@ static int anfc_chips_init(struct arasan_nfc *nfc)
return -EINVAL;
}
- for_each_child_of_node(np, nand_np) {
+ for_each_child_of_node_scoped(np, nand_np) {
ret = anfc_chip_init(nfc, nand_np);
if (ret) {
- of_node_put(nand_np);
anfc_chips_cleanup(nfc);
break;
}
--
2.34.1
^ permalink raw reply related [flat|nested] 30+ messages in thread
* [PATCH -next RESEND 02/10] mtd: rawnand: cadence: Use for_each_child_of_node_scoped()
2024-08-26 9:43 [PATCH -next RESEND 00/10] mtd: Use for_each_child_of_node_scoped() Jinjie Ruan
2024-08-26 9:43 ` [PATCH -next RESEND 01/10] mtd: rawnand: arasan: " Jinjie Ruan
@ 2024-08-26 9:43 ` Jinjie Ruan
2024-09-06 15:04 ` Miquel Raynal
2024-08-26 9:43 ` [PATCH -next RESEND 03/10] mtd: rawnand: pl353: " Jinjie Ruan
` (8 subsequent siblings)
10 siblings, 1 reply; 30+ messages in thread
From: Jinjie Ruan @ 2024-08-26 9:43 UTC (permalink / raw)
To: miquel.raynal, michal.simek, richard, vigneshr, liang.yang,
neil.armstrong, khilman, jbrunet, martin.blumenstingl,
matthias.bgg, angelogioacchino.delregno, heiko, mcoquelin.stm32,
alexandre.torgue, wens, jernej.skrabec, samuel, kees, ruanjinjie,
gustavoars, linux, robh, u.kleine-koenig, erick.archer,
christophe.jaillet, val, christophe.kerello, linux-mtd,
linux-kernel, linux-arm-kernel, linux-amlogic, linux-mediatek,
linux-renesas-soc, linux-rockchip, linux-stm32, krzk, jic23
Avoids the need for manual cleanup of_node_put() in early exits
from the loop by using for_each_child_of_node_scoped().
Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
---
drivers/mtd/nand/raw/cadence-nand-controller.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/mtd/nand/raw/cadence-nand-controller.c b/drivers/mtd/nand/raw/cadence-nand-controller.c
index ff92c17def83..3bc89b356963 100644
--- a/drivers/mtd/nand/raw/cadence-nand-controller.c
+++ b/drivers/mtd/nand/raw/cadence-nand-controller.c
@@ -2836,7 +2836,6 @@ static void cadence_nand_chips_cleanup(struct cdns_nand_ctrl *cdns_ctrl)
static int cadence_nand_chips_init(struct cdns_nand_ctrl *cdns_ctrl)
{
struct device_node *np = cdns_ctrl->dev->of_node;
- struct device_node *nand_np;
int max_cs = cdns_ctrl->caps2.max_banks;
int nchips, ret;
@@ -2849,10 +2848,9 @@ static int cadence_nand_chips_init(struct cdns_nand_ctrl *cdns_ctrl)
return -EINVAL;
}
- for_each_child_of_node(np, nand_np) {
+ for_each_child_of_node_scoped(np, nand_np) {
ret = cadence_nand_chip_init(cdns_ctrl, nand_np);
if (ret) {
- of_node_put(nand_np);
cadence_nand_chips_cleanup(cdns_ctrl);
return ret;
}
--
2.34.1
^ permalink raw reply related [flat|nested] 30+ messages in thread
* [PATCH -next RESEND 03/10] mtd: rawnand: pl353: Use for_each_child_of_node_scoped()
2024-08-26 9:43 [PATCH -next RESEND 00/10] mtd: Use for_each_child_of_node_scoped() Jinjie Ruan
2024-08-26 9:43 ` [PATCH -next RESEND 01/10] mtd: rawnand: arasan: " Jinjie Ruan
2024-08-26 9:43 ` [PATCH -next RESEND 02/10] mtd: rawnand: cadence: " Jinjie Ruan
@ 2024-08-26 9:43 ` Jinjie Ruan
2024-09-06 15:04 ` Miquel Raynal
2024-08-26 9:43 ` [PATCH -next RESEND 04/10] mtd: rawnand: marvell: drm/rockchip: " Jinjie Ruan
` (7 subsequent siblings)
10 siblings, 1 reply; 30+ messages in thread
From: Jinjie Ruan @ 2024-08-26 9:43 UTC (permalink / raw)
To: miquel.raynal, michal.simek, richard, vigneshr, liang.yang,
neil.armstrong, khilman, jbrunet, martin.blumenstingl,
matthias.bgg, angelogioacchino.delregno, heiko, mcoquelin.stm32,
alexandre.torgue, wens, jernej.skrabec, samuel, kees, ruanjinjie,
gustavoars, linux, robh, u.kleine-koenig, erick.archer,
christophe.jaillet, val, christophe.kerello, linux-mtd,
linux-kernel, linux-arm-kernel, linux-amlogic, linux-mediatek,
linux-renesas-soc, linux-rockchip, linux-stm32, krzk, jic23
Avoids the need for manual cleanup of_node_put() in early exits
from the loop by using for_each_child_of_node_scoped().
Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
---
drivers/mtd/nand/raw/pl35x-nand-controller.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/mtd/nand/raw/pl35x-nand-controller.c b/drivers/mtd/nand/raw/pl35x-nand-controller.c
index 1c76ee98efb7..2570fd0beea0 100644
--- a/drivers/mtd/nand/raw/pl35x-nand-controller.c
+++ b/drivers/mtd/nand/raw/pl35x-nand-controller.c
@@ -1111,7 +1111,7 @@ static void pl35x_nand_chips_cleanup(struct pl35x_nandc *nfc)
static int pl35x_nand_chips_init(struct pl35x_nandc *nfc)
{
- struct device_node *np = nfc->dev->of_node, *nand_np;
+ struct device_node *np = nfc->dev->of_node;
int nchips = of_get_child_count(np);
int ret;
@@ -1121,10 +1121,9 @@ static int pl35x_nand_chips_init(struct pl35x_nandc *nfc)
return -EINVAL;
}
- for_each_child_of_node(np, nand_np) {
+ for_each_child_of_node_scoped(np, nand_np) {
ret = pl35x_nand_chip_init(nfc, nand_np);
if (ret) {
- of_node_put(nand_np);
pl35x_nand_chips_cleanup(nfc);
break;
}
--
2.34.1
^ permalink raw reply related [flat|nested] 30+ messages in thread
* [PATCH -next RESEND 04/10] mtd: rawnand: marvell: drm/rockchip: Use for_each_child_of_node_scoped()
2024-08-26 9:43 [PATCH -next RESEND 00/10] mtd: Use for_each_child_of_node_scoped() Jinjie Ruan
` (2 preceding siblings ...)
2024-08-26 9:43 ` [PATCH -next RESEND 03/10] mtd: rawnand: pl353: " Jinjie Ruan
@ 2024-08-26 9:43 ` Jinjie Ruan
2024-09-06 15:03 ` Miquel Raynal
2024-08-26 9:43 ` [PATCH -next RESEND 05/10] mtd: rawnand: rockchip: " Jinjie Ruan
` (6 subsequent siblings)
10 siblings, 1 reply; 30+ messages in thread
From: Jinjie Ruan @ 2024-08-26 9:43 UTC (permalink / raw)
To: miquel.raynal, michal.simek, richard, vigneshr, liang.yang,
neil.armstrong, khilman, jbrunet, martin.blumenstingl,
matthias.bgg, angelogioacchino.delregno, heiko, mcoquelin.stm32,
alexandre.torgue, wens, jernej.skrabec, samuel, kees, ruanjinjie,
gustavoars, linux, robh, u.kleine-koenig, erick.archer,
christophe.jaillet, val, christophe.kerello, linux-mtd,
linux-kernel, linux-arm-kernel, linux-amlogic, linux-mediatek,
linux-renesas-soc, linux-rockchip, linux-stm32, krzk, jic23
Avoids the need for manual cleanup of_node_put() in early exits
from the loop.
Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
---
drivers/mtd/nand/raw/marvell_nand.c | 12 +++---------
1 file changed, 3 insertions(+), 9 deletions(-)
diff --git a/drivers/mtd/nand/raw/marvell_nand.c b/drivers/mtd/nand/raw/marvell_nand.c
index 5b0f5a9cef81..26648b72e691 100644
--- a/drivers/mtd/nand/raw/marvell_nand.c
+++ b/drivers/mtd/nand/raw/marvell_nand.c
@@ -2771,7 +2771,6 @@ static void marvell_nand_chips_cleanup(struct marvell_nfc *nfc)
static int marvell_nand_chips_init(struct device *dev, struct marvell_nfc *nfc)
{
struct device_node *np = dev->of_node;
- struct device_node *nand_np;
int max_cs = nfc->caps->max_cs_nb;
int nchips;
int ret;
@@ -2798,20 +2797,15 @@ static int marvell_nand_chips_init(struct device *dev, struct marvell_nfc *nfc)
return ret;
}
- for_each_child_of_node(np, nand_np) {
+ for_each_child_of_node_scoped(np, nand_np) {
ret = marvell_nand_chip_init(dev, nfc, nand_np);
if (ret) {
- of_node_put(nand_np);
- goto cleanup_chips;
+ marvell_nand_chips_cleanup(nfc);
+ return ret;
}
}
return 0;
-
-cleanup_chips:
- marvell_nand_chips_cleanup(nfc);
-
- return ret;
}
static int marvell_nfc_init_dma(struct marvell_nfc *nfc)
--
2.34.1
^ permalink raw reply related [flat|nested] 30+ messages in thread
* [PATCH -next RESEND 05/10] mtd: rawnand: rockchip: Use for_each_child_of_node_scoped()
2024-08-26 9:43 [PATCH -next RESEND 00/10] mtd: Use for_each_child_of_node_scoped() Jinjie Ruan
` (3 preceding siblings ...)
2024-08-26 9:43 ` [PATCH -next RESEND 04/10] mtd: rawnand: marvell: drm/rockchip: " Jinjie Ruan
@ 2024-08-26 9:43 ` Jinjie Ruan
2024-09-06 15:03 ` Miquel Raynal
2024-08-26 9:43 ` [PATCH -next RESEND 06/10] mtd: rawnand: meson: " Jinjie Ruan
` (5 subsequent siblings)
10 siblings, 1 reply; 30+ messages in thread
From: Jinjie Ruan @ 2024-08-26 9:43 UTC (permalink / raw)
To: miquel.raynal, michal.simek, richard, vigneshr, liang.yang,
neil.armstrong, khilman, jbrunet, martin.blumenstingl,
matthias.bgg, angelogioacchino.delregno, heiko, mcoquelin.stm32,
alexandre.torgue, wens, jernej.skrabec, samuel, kees, ruanjinjie,
gustavoars, linux, robh, u.kleine-koenig, erick.archer,
christophe.jaillet, val, christophe.kerello, linux-mtd,
linux-kernel, linux-arm-kernel, linux-amlogic, linux-mediatek,
linux-renesas-soc, linux-rockchip, linux-stm32, krzk, jic23
Avoids the need for manual cleanup of_node_put() in early exits
from the loop.
Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
---
drivers/mtd/nand/raw/rockchip-nand-controller.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/mtd/nand/raw/rockchip-nand-controller.c b/drivers/mtd/nand/raw/rockchip-nand-controller.c
index 55580447633b..51c9cf9013dc 100644
--- a/drivers/mtd/nand/raw/rockchip-nand-controller.c
+++ b/drivers/mtd/nand/raw/rockchip-nand-controller.c
@@ -1211,7 +1211,7 @@ static void rk_nfc_chips_cleanup(struct rk_nfc *nfc)
static int rk_nfc_nand_chips_init(struct device *dev, struct rk_nfc *nfc)
{
- struct device_node *np = dev->of_node, *nand_np;
+ struct device_node *np = dev->of_node;
int nchips = of_get_child_count(np);
int ret;
@@ -1221,10 +1221,9 @@ static int rk_nfc_nand_chips_init(struct device *dev, struct rk_nfc *nfc)
return -EINVAL;
}
- for_each_child_of_node(np, nand_np) {
+ for_each_child_of_node_scoped(np, nand_np) {
ret = rk_nfc_nand_chip_init(dev, nfc, nand_np);
if (ret) {
- of_node_put(nand_np);
rk_nfc_chips_cleanup(nfc);
return ret;
}
--
2.34.1
^ permalink raw reply related [flat|nested] 30+ messages in thread
* [PATCH -next RESEND 06/10] mtd: rawnand: meson: Use for_each_child_of_node_scoped()
2024-08-26 9:43 [PATCH -next RESEND 00/10] mtd: Use for_each_child_of_node_scoped() Jinjie Ruan
` (4 preceding siblings ...)
2024-08-26 9:43 ` [PATCH -next RESEND 05/10] mtd: rawnand: rockchip: " Jinjie Ruan
@ 2024-08-26 9:43 ` Jinjie Ruan
2024-09-06 15:03 ` Miquel Raynal
2024-08-26 9:43 ` [PATCH -next RESEND 07/10] mtd: rawnand: mtk: " Jinjie Ruan
` (4 subsequent siblings)
10 siblings, 1 reply; 30+ messages in thread
From: Jinjie Ruan @ 2024-08-26 9:43 UTC (permalink / raw)
To: miquel.raynal, michal.simek, richard, vigneshr, liang.yang,
neil.armstrong, khilman, jbrunet, martin.blumenstingl,
matthias.bgg, angelogioacchino.delregno, heiko, mcoquelin.stm32,
alexandre.torgue, wens, jernej.skrabec, samuel, kees, ruanjinjie,
gustavoars, linux, robh, u.kleine-koenig, erick.archer,
christophe.jaillet, val, christophe.kerello, linux-mtd,
linux-kernel, linux-arm-kernel, linux-amlogic, linux-mediatek,
linux-renesas-soc, linux-rockchip, linux-stm32, krzk, jic23
Avoids the need for manual cleanup of_node_put() in early exits
from the loop.
Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
---
drivers/mtd/nand/raw/meson_nand.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/mtd/nand/raw/meson_nand.c b/drivers/mtd/nand/raw/meson_nand.c
index 9eb5470344d0..8806a06462ac 100644
--- a/drivers/mtd/nand/raw/meson_nand.c
+++ b/drivers/mtd/nand/raw/meson_nand.c
@@ -1495,14 +1495,12 @@ static int meson_nfc_nand_chips_init(struct device *dev,
struct meson_nfc *nfc)
{
struct device_node *np = dev->of_node;
- struct device_node *nand_np;
int ret;
- for_each_child_of_node(np, nand_np) {
+ for_each_child_of_node_scoped(np, nand_np) {
ret = meson_nfc_nand_chip_init(dev, nfc, nand_np);
if (ret) {
meson_nfc_nand_chip_cleanup(nfc);
- of_node_put(nand_np);
return ret;
}
}
--
2.34.1
^ permalink raw reply related [flat|nested] 30+ messages in thread
* [PATCH -next RESEND 07/10] mtd: rawnand: mtk: Use for_each_child_of_node_scoped()
2024-08-26 9:43 [PATCH -next RESEND 00/10] mtd: Use for_each_child_of_node_scoped() Jinjie Ruan
` (5 preceding siblings ...)
2024-08-26 9:43 ` [PATCH -next RESEND 06/10] mtd: rawnand: meson: " Jinjie Ruan
@ 2024-08-26 9:43 ` Jinjie Ruan
2024-09-06 15:03 ` Miquel Raynal
2024-08-26 9:43 ` [PATCH -next RESEND 08/10] mtd: rawnand: renesas: " Jinjie Ruan
` (3 subsequent siblings)
10 siblings, 1 reply; 30+ messages in thread
From: Jinjie Ruan @ 2024-08-26 9:43 UTC (permalink / raw)
To: miquel.raynal, michal.simek, richard, vigneshr, liang.yang,
neil.armstrong, khilman, jbrunet, martin.blumenstingl,
matthias.bgg, angelogioacchino.delregno, heiko, mcoquelin.stm32,
alexandre.torgue, wens, jernej.skrabec, samuel, kees, ruanjinjie,
gustavoars, linux, robh, u.kleine-koenig, erick.archer,
christophe.jaillet, val, christophe.kerello, linux-mtd,
linux-kernel, linux-arm-kernel, linux-amlogic, linux-mediatek,
linux-renesas-soc, linux-rockchip, linux-stm32, krzk, jic23
Avoids the need for manual cleanup of_node_put() in early exits
from the loop.
Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
---
drivers/mtd/nand/raw/mtk_nand.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/mtd/nand/raw/mtk_nand.c b/drivers/mtd/nand/raw/mtk_nand.c
index 17477bb2d48f..d65e6371675b 100644
--- a/drivers/mtd/nand/raw/mtk_nand.c
+++ b/drivers/mtd/nand/raw/mtk_nand.c
@@ -1432,15 +1432,12 @@ static int mtk_nfc_nand_chip_init(struct device *dev, struct mtk_nfc *nfc,
static int mtk_nfc_nand_chips_init(struct device *dev, struct mtk_nfc *nfc)
{
struct device_node *np = dev->of_node;
- struct device_node *nand_np;
int ret;
- for_each_child_of_node(np, nand_np) {
+ for_each_child_of_node_scoped(np, nand_np) {
ret = mtk_nfc_nand_chip_init(dev, nfc, nand_np);
- if (ret) {
- of_node_put(nand_np);
+ if (ret)
return ret;
- }
}
return 0;
--
2.34.1
^ permalink raw reply related [flat|nested] 30+ messages in thread
* [PATCH -next RESEND 08/10] mtd: rawnand: renesas: Use for_each_child_of_node_scoped()
2024-08-26 9:43 [PATCH -next RESEND 00/10] mtd: Use for_each_child_of_node_scoped() Jinjie Ruan
` (6 preceding siblings ...)
2024-08-26 9:43 ` [PATCH -next RESEND 07/10] mtd: rawnand: mtk: " Jinjie Ruan
@ 2024-08-26 9:43 ` Jinjie Ruan
2024-08-26 9:53 ` Geert Uytterhoeven
2024-09-06 15:03 ` Miquel Raynal
2024-08-26 9:43 ` [PATCH -next RESEND 09/10] mtd: rawnand: stm32_fmc2: " Jinjie Ruan
` (2 subsequent siblings)
10 siblings, 2 replies; 30+ messages in thread
From: Jinjie Ruan @ 2024-08-26 9:43 UTC (permalink / raw)
To: miquel.raynal, michal.simek, richard, vigneshr, liang.yang,
neil.armstrong, khilman, jbrunet, martin.blumenstingl,
matthias.bgg, angelogioacchino.delregno, heiko, mcoquelin.stm32,
alexandre.torgue, wens, jernej.skrabec, samuel, kees, ruanjinjie,
gustavoars, linux, robh, u.kleine-koenig, erick.archer,
christophe.jaillet, val, christophe.kerello, linux-mtd,
linux-kernel, linux-arm-kernel, linux-amlogic, linux-mediatek,
linux-renesas-soc, linux-rockchip, linux-stm32, krzk, jic23
Avoids the need for manual cleanup of_node_put() in early exits
from the loop.
Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
---
drivers/mtd/nand/raw/renesas-nand-controller.c | 12 +++---------
1 file changed, 3 insertions(+), 9 deletions(-)
diff --git a/drivers/mtd/nand/raw/renesas-nand-controller.c b/drivers/mtd/nand/raw/renesas-nand-controller.c
index c9a01feff8df..0e92d50c5249 100644
--- a/drivers/mtd/nand/raw/renesas-nand-controller.c
+++ b/drivers/mtd/nand/raw/renesas-nand-controller.c
@@ -1297,23 +1297,17 @@ static void rnandc_chips_cleanup(struct rnandc *rnandc)
static int rnandc_chips_init(struct rnandc *rnandc)
{
- struct device_node *np;
int ret;
- for_each_child_of_node(rnandc->dev->of_node, np) {
+ for_each_child_of_node_scoped(rnandc->dev->of_node, np) {
ret = rnandc_chip_init(rnandc, np);
if (ret) {
- of_node_put(np);
- goto cleanup_chips;
+ rnandc_chips_cleanup(rnandc);
+ return ret;
}
}
return 0;
-
-cleanup_chips:
- rnandc_chips_cleanup(rnandc);
-
- return ret;
}
static int rnandc_probe(struct platform_device *pdev)
--
2.34.1
^ permalink raw reply related [flat|nested] 30+ messages in thread
* [PATCH -next RESEND 09/10] mtd: rawnand: stm32_fmc2: Use for_each_child_of_node_scoped()
2024-08-26 9:43 [PATCH -next RESEND 00/10] mtd: Use for_each_child_of_node_scoped() Jinjie Ruan
` (7 preceding siblings ...)
2024-08-26 9:43 ` [PATCH -next RESEND 08/10] mtd: rawnand: renesas: " Jinjie Ruan
@ 2024-08-26 9:43 ` Jinjie Ruan
2024-09-06 15:03 ` Miquel Raynal
2024-08-26 9:43 ` [PATCH -next RESEND 10/10] mtd: rawnand: sunxi: " Jinjie Ruan
2024-08-26 9:52 ` [PATCH -next RESEND 00/10] mtd: " Miquel Raynal
10 siblings, 1 reply; 30+ messages in thread
From: Jinjie Ruan @ 2024-08-26 9:43 UTC (permalink / raw)
To: miquel.raynal, michal.simek, richard, vigneshr, liang.yang,
neil.armstrong, khilman, jbrunet, martin.blumenstingl,
matthias.bgg, angelogioacchino.delregno, heiko, mcoquelin.stm32,
alexandre.torgue, wens, jernej.skrabec, samuel, kees, ruanjinjie,
gustavoars, linux, robh, u.kleine-koenig, erick.archer,
christophe.jaillet, val, christophe.kerello, linux-mtd,
linux-kernel, linux-arm-kernel, linux-amlogic, linux-mediatek,
linux-renesas-soc, linux-rockchip, linux-stm32, krzk, jic23
Avoids the need for manual cleanup of_node_put() in early exits
from the loop.
Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
---
drivers/mtd/nand/raw/stm32_fmc2_nand.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/mtd/nand/raw/stm32_fmc2_nand.c b/drivers/mtd/nand/raw/stm32_fmc2_nand.c
index 264556939a00..0f67e96cc240 100644
--- a/drivers/mtd/nand/raw/stm32_fmc2_nand.c
+++ b/drivers/mtd/nand/raw/stm32_fmc2_nand.c
@@ -1851,7 +1851,6 @@ static int stm32_fmc2_nfc_parse_child(struct stm32_fmc2_nfc *nfc,
static int stm32_fmc2_nfc_parse_dt(struct stm32_fmc2_nfc *nfc)
{
struct device_node *dn = nfc->dev->of_node;
- struct device_node *child;
int nchips = of_get_child_count(dn);
int ret = 0;
@@ -1865,12 +1864,10 @@ static int stm32_fmc2_nfc_parse_dt(struct stm32_fmc2_nfc *nfc)
return -EINVAL;
}
- for_each_child_of_node(dn, child) {
+ for_each_child_of_node_scoped(dn, child) {
ret = stm32_fmc2_nfc_parse_child(nfc, child);
- if (ret < 0) {
- of_node_put(child);
+ if (ret < 0)
return ret;
- }
}
return ret;
--
2.34.1
^ permalink raw reply related [flat|nested] 30+ messages in thread
* [PATCH -next RESEND 10/10] mtd: rawnand: sunxi: Use for_each_child_of_node_scoped()
2024-08-26 9:43 [PATCH -next RESEND 00/10] mtd: Use for_each_child_of_node_scoped() Jinjie Ruan
` (8 preceding siblings ...)
2024-08-26 9:43 ` [PATCH -next RESEND 09/10] mtd: rawnand: stm32_fmc2: " Jinjie Ruan
@ 2024-08-26 9:43 ` Jinjie Ruan
2024-09-06 15:03 ` Miquel Raynal
2024-08-26 9:52 ` [PATCH -next RESEND 00/10] mtd: " Miquel Raynal
10 siblings, 1 reply; 30+ messages in thread
From: Jinjie Ruan @ 2024-08-26 9:43 UTC (permalink / raw)
To: miquel.raynal, michal.simek, richard, vigneshr, liang.yang,
neil.armstrong, khilman, jbrunet, martin.blumenstingl,
matthias.bgg, angelogioacchino.delregno, heiko, mcoquelin.stm32,
alexandre.torgue, wens, jernej.skrabec, samuel, kees, ruanjinjie,
gustavoars, linux, robh, u.kleine-koenig, erick.archer,
christophe.jaillet, val, christophe.kerello, linux-mtd,
linux-kernel, linux-arm-kernel, linux-amlogic, linux-mediatek,
linux-renesas-soc, linux-rockchip, linux-stm32, krzk, jic23
Avoids the need for manual cleanup of_node_put() in early exits
from the loop.
Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
---
drivers/mtd/nand/raw/sunxi_nand.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/mtd/nand/raw/sunxi_nand.c b/drivers/mtd/nand/raw/sunxi_nand.c
index 4ec17c8bce5a..c28634e20abf 100644
--- a/drivers/mtd/nand/raw/sunxi_nand.c
+++ b/drivers/mtd/nand/raw/sunxi_nand.c
@@ -2025,13 +2025,11 @@ static int sunxi_nand_chip_init(struct device *dev, struct sunxi_nfc *nfc,
static int sunxi_nand_chips_init(struct device *dev, struct sunxi_nfc *nfc)
{
struct device_node *np = dev->of_node;
- struct device_node *nand_np;
int ret;
- for_each_child_of_node(np, nand_np) {
+ for_each_child_of_node_scoped(np, nand_np) {
ret = sunxi_nand_chip_init(dev, nfc, nand_np);
if (ret) {
- of_node_put(nand_np);
sunxi_nand_chips_cleanup(nfc);
return ret;
}
--
2.34.1
^ permalink raw reply related [flat|nested] 30+ messages in thread
* Re: [PATCH -next RESEND 00/10] mtd: Use for_each_child_of_node_scoped()
2024-08-26 9:43 [PATCH -next RESEND 00/10] mtd: Use for_each_child_of_node_scoped() Jinjie Ruan
` (9 preceding siblings ...)
2024-08-26 9:43 ` [PATCH -next RESEND 10/10] mtd: rawnand: sunxi: " Jinjie Ruan
@ 2024-08-26 9:52 ` Miquel Raynal
2024-08-26 10:19 ` Krzysztof Kozlowski
2024-08-26 10:53 ` Jinjie Ruan
10 siblings, 2 replies; 30+ messages in thread
From: Miquel Raynal @ 2024-08-26 9:52 UTC (permalink / raw)
To: Jinjie Ruan
Cc: michal.simek, richard, vigneshr, liang.yang, neil.armstrong,
khilman, jbrunet, martin.blumenstingl, matthias.bgg,
angelogioacchino.delregno, heiko, mcoquelin.stm32,
alexandre.torgue, wens, jernej.skrabec, samuel, kees, gustavoars,
linux, robh, u.kleine-koenig, erick.archer, christophe.jaillet,
val, christophe.kerello, linux-mtd, linux-kernel,
linux-arm-kernel, linux-amlogic, linux-mediatek,
linux-renesas-soc, linux-rockchip, linux-stm32, krzk, jic23
Hi Jinjie,
ruanjinjie@huawei.com wrote on Mon, 26 Aug 2024 17:43:18 +0800:
> Use scoped for_each_available_child_of_node_scoped() when iterating over
> device nodes to make code a bit simpler.
Why is this a resend ? Did I miss a previous iteration?
Thanks,
Miquèl
^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [PATCH -next RESEND 08/10] mtd: rawnand: renesas: Use for_each_child_of_node_scoped()
2024-08-26 9:43 ` [PATCH -next RESEND 08/10] mtd: rawnand: renesas: " Jinjie Ruan
@ 2024-08-26 9:53 ` Geert Uytterhoeven
2024-09-06 15:03 ` Miquel Raynal
1 sibling, 0 replies; 30+ messages in thread
From: Geert Uytterhoeven @ 2024-08-26 9:53 UTC (permalink / raw)
To: Jinjie Ruan
Cc: miquel.raynal, michal.simek, richard, vigneshr, liang.yang,
neil.armstrong, khilman, jbrunet, martin.blumenstingl,
matthias.bgg, angelogioacchino.delregno, heiko, mcoquelin.stm32,
alexandre.torgue, wens, jernej.skrabec, samuel, kees, gustavoars,
linux, robh, u.kleine-koenig, erick.archer, christophe.jaillet,
val, christophe.kerello, linux-mtd, linux-kernel,
linux-arm-kernel, linux-amlogic, linux-mediatek,
linux-renesas-soc, linux-rockchip, linux-stm32, krzk, jic23
On Mon, Aug 26, 2024 at 11:37 AM Jinjie Ruan <ruanjinjie@huawei.com> wrote:
> Avoids the need for manual cleanup of_node_put() in early exits
> from the loop.
>
> Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [PATCH -next RESEND 00/10] mtd: Use for_each_child_of_node_scoped()
2024-08-26 9:52 ` [PATCH -next RESEND 00/10] mtd: " Miquel Raynal
@ 2024-08-26 10:19 ` Krzysztof Kozlowski
2024-08-26 10:56 ` Jinjie Ruan
2024-08-26 12:49 ` Miquel Raynal
2024-08-26 10:53 ` Jinjie Ruan
1 sibling, 2 replies; 30+ messages in thread
From: Krzysztof Kozlowski @ 2024-08-26 10:19 UTC (permalink / raw)
To: Miquel Raynal, Jinjie Ruan
Cc: michal.simek, richard, vigneshr, liang.yang, neil.armstrong,
khilman, jbrunet, martin.blumenstingl, matthias.bgg,
angelogioacchino.delregno, heiko, mcoquelin.stm32,
alexandre.torgue, wens, jernej.skrabec, samuel, kees, gustavoars,
linux, robh, u.kleine-koenig, erick.archer, christophe.jaillet,
val, christophe.kerello, linux-mtd, linux-kernel,
linux-arm-kernel, linux-amlogic, linux-mediatek,
linux-renesas-soc, linux-rockchip, linux-stm32, jic23
On 26/08/2024 11:52, Miquel Raynal wrote:
> Hi Jinjie,
>
> ruanjinjie@huawei.com wrote on Mon, 26 Aug 2024 17:43:18 +0800:
>
>> Use scoped for_each_available_child_of_node_scoped() when iterating over
>> device nodes to make code a bit simpler.
>
> Why is this a resend ? Did I miss a previous iteration?
You were not cc-ed on previous iteration. I asked for proper split
between subsystems and sending to maintainers, thus this resend.
Although for such big patchset, I would expect some waiting time, not
sending immediately.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [PATCH -next RESEND 00/10] mtd: Use for_each_child_of_node_scoped()
2024-08-26 9:52 ` [PATCH -next RESEND 00/10] mtd: " Miquel Raynal
2024-08-26 10:19 ` Krzysztof Kozlowski
@ 2024-08-26 10:53 ` Jinjie Ruan
1 sibling, 0 replies; 30+ messages in thread
From: Jinjie Ruan @ 2024-08-26 10:53 UTC (permalink / raw)
To: Miquel Raynal
Cc: michal.simek, richard, vigneshr, liang.yang, neil.armstrong,
khilman, jbrunet, martin.blumenstingl, matthias.bgg,
angelogioacchino.delregno, heiko, mcoquelin.stm32,
alexandre.torgue, wens, jernej.skrabec, samuel, kees, gustavoars,
linux, robh, u.kleine-koenig, erick.archer, christophe.jaillet,
val, christophe.kerello, linux-mtd, linux-kernel,
linux-arm-kernel, linux-amlogic, linux-mediatek,
linux-renesas-soc, linux-rockchip, linux-stm32, krzk, jic23
On 2024/8/26 17:52, Miquel Raynal wrote:
> Hi Jinjie,
>
> ruanjinjie@huawei.com wrote on Mon, 26 Aug 2024 17:43:18 +0800:
>
>> Use scoped for_each_available_child_of_node_scoped() when iterating over
>> device nodes to make code a bit simpler.
>
> Why is this a resend ? Did I miss a previous iteration?
Hi Miquel,
The previous cc list has missing some entries.
>
> Thanks,
> Miquèl
^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [PATCH -next RESEND 00/10] mtd: Use for_each_child_of_node_scoped()
2024-08-26 10:19 ` Krzysztof Kozlowski
@ 2024-08-26 10:56 ` Jinjie Ruan
2024-08-26 12:49 ` Miquel Raynal
1 sibling, 0 replies; 30+ messages in thread
From: Jinjie Ruan @ 2024-08-26 10:56 UTC (permalink / raw)
To: Krzysztof Kozlowski, Miquel Raynal
Cc: michal.simek, richard, vigneshr, liang.yang, neil.armstrong,
khilman, jbrunet, martin.blumenstingl, matthias.bgg,
angelogioacchino.delregno, heiko, mcoquelin.stm32,
alexandre.torgue, wens, jernej.skrabec, samuel, kees, gustavoars,
linux, robh, u.kleine-koenig, erick.archer, christophe.jaillet,
val, christophe.kerello, linux-mtd, linux-kernel,
linux-arm-kernel, linux-amlogic, linux-mediatek,
linux-renesas-soc, linux-rockchip, linux-stm32, jic23
On 2024/8/26 18:19, Krzysztof Kozlowski wrote:
> On 26/08/2024 11:52, Miquel Raynal wrote:
>> Hi Jinjie,
>>
>> ruanjinjie@huawei.com wrote on Mon, 26 Aug 2024 17:43:18 +0800:
>>
>>> Use scoped for_each_available_child_of_node_scoped() when iterating over
>>> device nodes to make code a bit simpler.
>>
>> Why is this a resend ? Did I miss a previous iteration?
>
> You were not cc-ed on previous iteration. I asked for proper split
> between subsystems and sending to maintainers, thus this resend.
>
> Although for such big patchset, I would expect some waiting time, not
> sending immediately.
Sorry, I will pay attention to it later.
>
> Best regards,
> Krzysztof
>
^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [PATCH -next RESEND 00/10] mtd: Use for_each_child_of_node_scoped()
2024-08-26 10:19 ` Krzysztof Kozlowski
2024-08-26 10:56 ` Jinjie Ruan
@ 2024-08-26 12:49 ` Miquel Raynal
2024-08-26 12:56 ` Jinjie Ruan
2024-08-30 6:34 ` Jinjie Ruan
1 sibling, 2 replies; 30+ messages in thread
From: Miquel Raynal @ 2024-08-26 12:49 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Jinjie Ruan, michal.simek, richard, vigneshr, liang.yang,
neil.armstrong, khilman, jbrunet, martin.blumenstingl,
matthias.bgg, angelogioacchino.delregno, heiko, mcoquelin.stm32,
alexandre.torgue, wens, jernej.skrabec, samuel, kees, gustavoars,
linux, robh, u.kleine-koenig, erick.archer, christophe.jaillet,
val, christophe.kerello, linux-mtd, linux-kernel,
linux-arm-kernel, linux-amlogic, linux-mediatek,
linux-renesas-soc, linux-rockchip, linux-stm32, jic23
Hi Krzysztof,
krzk@kernel.org wrote on Mon, 26 Aug 2024 12:19:07 +0200:
> On 26/08/2024 11:52, Miquel Raynal wrote:
> > Hi Jinjie,
> >
> > ruanjinjie@huawei.com wrote on Mon, 26 Aug 2024 17:43:18 +0800:
> >
> >> Use scoped for_each_available_child_of_node_scoped() when iterating over
> >> device nodes to make code a bit simpler.
> >
> > Why is this a resend ? Did I miss a previous iteration?
>
> You were not cc-ed on previous iteration. I asked for proper split
> between subsystems and sending to maintainers, thus this resend.
Ok. Makes sense, and the patchset looks fine.
Jinjie, please always include a changelog when you send new versions,
and explanations for a RESEND.
Thanks,
Miquèl
^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [PATCH -next RESEND 00/10] mtd: Use for_each_child_of_node_scoped()
2024-08-26 12:49 ` Miquel Raynal
@ 2024-08-26 12:56 ` Jinjie Ruan
2024-08-30 6:34 ` Jinjie Ruan
1 sibling, 0 replies; 30+ messages in thread
From: Jinjie Ruan @ 2024-08-26 12:56 UTC (permalink / raw)
To: Miquel Raynal, Krzysztof Kozlowski
Cc: michal.simek, richard, vigneshr, liang.yang, neil.armstrong,
khilman, jbrunet, martin.blumenstingl, matthias.bgg,
angelogioacchino.delregno, heiko, mcoquelin.stm32,
alexandre.torgue, wens, jernej.skrabec, samuel, kees, gustavoars,
linux, robh, u.kleine-koenig, erick.archer, christophe.jaillet,
val, christophe.kerello, linux-mtd, linux-kernel,
linux-arm-kernel, linux-amlogic, linux-mediatek,
linux-renesas-soc, linux-rockchip, linux-stm32, jic23
On 2024/8/26 20:49, Miquel Raynal wrote:
> Hi Krzysztof,
>
> krzk@kernel.org wrote on Mon, 26 Aug 2024 12:19:07 +0200:
>
>> On 26/08/2024 11:52, Miquel Raynal wrote:
>>> Hi Jinjie,
>>>
>>> ruanjinjie@huawei.com wrote on Mon, 26 Aug 2024 17:43:18 +0800:
>>>
>>>> Use scoped for_each_available_child_of_node_scoped() when iterating over
>>>> device nodes to make code a bit simpler.
>>>
>>> Why is this a resend ? Did I miss a previous iteration?
>>
>> You were not cc-ed on previous iteration. I asked for proper split
>> between subsystems and sending to maintainers, thus this resend.
>
> Ok. Makes sense, and the patchset looks fine.
>
> Jinjie, please always include a changelog when you send new versions,
> and explanations for a RESEND.
Ok, thanks for the advice.
>
> Thanks,
> Miquèl
^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [PATCH -next RESEND 00/10] mtd: Use for_each_child_of_node_scoped()
2024-08-26 12:49 ` Miquel Raynal
2024-08-26 12:56 ` Jinjie Ruan
@ 2024-08-30 6:34 ` Jinjie Ruan
2024-08-30 7:45 ` Miquel Raynal
1 sibling, 1 reply; 30+ messages in thread
From: Jinjie Ruan @ 2024-08-30 6:34 UTC (permalink / raw)
To: Miquel Raynal, Krzysztof Kozlowski
Cc: michal.simek, richard, vigneshr, liang.yang, neil.armstrong,
khilman, jbrunet, martin.blumenstingl, matthias.bgg,
angelogioacchino.delregno, heiko, mcoquelin.stm32,
alexandre.torgue, wens, jernej.skrabec, samuel, kees, gustavoars,
linux, robh, u.kleine-koenig, erick.archer, christophe.jaillet,
val, christophe.kerello, linux-mtd, linux-kernel,
linux-arm-kernel, linux-amlogic, linux-mediatek,
linux-renesas-soc, linux-rockchip, linux-stm32, jic23
On 2024/8/26 20:49, Miquel Raynal wrote:
> Hi Krzysztof,
>
> krzk@kernel.org wrote on Mon, 26 Aug 2024 12:19:07 +0200:
>
>> On 26/08/2024 11:52, Miquel Raynal wrote:
>>> Hi Jinjie,
>>>
>>> ruanjinjie@huawei.com wrote on Mon, 26 Aug 2024 17:43:18 +0800:
>>>
>>>> Use scoped for_each_available_child_of_node_scoped() when iterating over
>>>> device nodes to make code a bit simpler.
>>>
>>> Why is this a resend ? Did I miss a previous iteration?
>>
>> You were not cc-ed on previous iteration. I asked for proper split
>> between subsystems and sending to maintainers, thus this resend.
>
> Ok. Makes sense, and the patchset looks fine.
Hi, Miquel,
Could this series be merged, thank you!
>
> Jinjie, please always include a changelog when you send new versions,
> and explanations for a RESEND.
>
> Thanks,
> Miquèl
^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [PATCH -next RESEND 00/10] mtd: Use for_each_child_of_node_scoped()
2024-08-30 6:34 ` Jinjie Ruan
@ 2024-08-30 7:45 ` Miquel Raynal
0 siblings, 0 replies; 30+ messages in thread
From: Miquel Raynal @ 2024-08-30 7:45 UTC (permalink / raw)
To: Jinjie Ruan
Cc: Krzysztof Kozlowski, michal.simek, richard, vigneshr, liang.yang,
neil.armstrong, khilman, jbrunet, martin.blumenstingl,
matthias.bgg, angelogioacchino.delregno, heiko, mcoquelin.stm32,
alexandre.torgue, wens, jernej.skrabec, samuel, kees, gustavoars,
linux, robh, u.kleine-koenig, erick.archer, christophe.jaillet,
val, christophe.kerello, linux-mtd, linux-kernel,
linux-arm-kernel, linux-amlogic, linux-mediatek,
linux-renesas-soc, linux-rockchip, linux-stm32, jic23
Jinjie,
ruanjinjie@huawei.com wrote on Fri, 30 Aug 2024 14:34:38 +0800:
> On 2024/8/26 20:49, Miquel Raynal wrote:
> > Hi Krzysztof,
> >
> > krzk@kernel.org wrote on Mon, 26 Aug 2024 12:19:07 +0200:
> >
> >> On 26/08/2024 11:52, Miquel Raynal wrote:
> >>> Hi Jinjie,
> >>>
> >>> ruanjinjie@huawei.com wrote on Mon, 26 Aug 2024 17:43:18 +0800:
> >>>
> >>>> Use scoped for_each_available_child_of_node_scoped() when iterating over
> >>>> device nodes to make code a bit simpler.
> >>>
> >>> Why is this a resend ? Did I miss a previous iteration?
> >>
> >> You were not cc-ed on previous iteration. I asked for proper split
> >> between subsystems and sending to maintainers, thus this resend.
> >
> > Ok. Makes sense, and the patchset looks fine.
>
> Hi, Miquel,
>
> Could this series be merged, thank you!
You've sent this series on Monday, we are Friday. I answered a first
time within 5h and reviewed it within 8h. So that means I will take the
patchset:
- when I have the time to do so
- after several days to give a chance to other to review it as well
- unless someone speaks up against it in a "reasonable time frame"
- unless a robot that parses the patches on the mailing lists complains
about it (usually within few days, up to a week).
In general, a good rule of thumb is to refrain yourself from pinging
within 2 weeks for non-urgent matters like this series.
Thanks,
Miquèl
^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [PATCH -next RESEND 10/10] mtd: rawnand: sunxi: Use for_each_child_of_node_scoped()
2024-08-26 9:43 ` [PATCH -next RESEND 10/10] mtd: rawnand: sunxi: " Jinjie Ruan
@ 2024-09-06 15:03 ` Miquel Raynal
0 siblings, 0 replies; 30+ messages in thread
From: Miquel Raynal @ 2024-09-06 15:03 UTC (permalink / raw)
To: Jinjie Ruan, miquel.raynal, michal.simek, richard, vigneshr,
liang.yang, neil.armstrong, khilman, jbrunet, martin.blumenstingl,
matthias.bgg, angelogioacchino.delregno, heiko, mcoquelin.stm32,
alexandre.torgue, wens, jernej.skrabec, samuel, kees, gustavoars,
linux, robh, u.kleine-koenig, erick.archer, christophe.jaillet,
val, christophe.kerello, linux-mtd, linux-kernel,
linux-arm-kernel, linux-amlogic, linux-mediatek,
linux-renesas-soc, linux-rockchip, linux-stm32, krzk, jic23
On Mon, 2024-08-26 at 09:43:28 UTC, Jinjie Ruan wrote:
> Avoids the need for manual cleanup of_node_put() in early exits
> from the loop.
>
> Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next, thanks.
Miquel
^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [PATCH -next RESEND 09/10] mtd: rawnand: stm32_fmc2: Use for_each_child_of_node_scoped()
2024-08-26 9:43 ` [PATCH -next RESEND 09/10] mtd: rawnand: stm32_fmc2: " Jinjie Ruan
@ 2024-09-06 15:03 ` Miquel Raynal
0 siblings, 0 replies; 30+ messages in thread
From: Miquel Raynal @ 2024-09-06 15:03 UTC (permalink / raw)
To: Jinjie Ruan, miquel.raynal, michal.simek, richard, vigneshr,
liang.yang, neil.armstrong, khilman, jbrunet, martin.blumenstingl,
matthias.bgg, angelogioacchino.delregno, heiko, mcoquelin.stm32,
alexandre.torgue, wens, jernej.skrabec, samuel, kees, gustavoars,
linux, robh, u.kleine-koenig, erick.archer, christophe.jaillet,
val, christophe.kerello, linux-mtd, linux-kernel,
linux-arm-kernel, linux-amlogic, linux-mediatek,
linux-renesas-soc, linux-rockchip, linux-stm32, krzk, jic23
On Mon, 2024-08-26 at 09:43:27 UTC, Jinjie Ruan wrote:
> Avoids the need for manual cleanup of_node_put() in early exits
> from the loop.
>
> Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next, thanks.
Miquel
^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [PATCH -next RESEND 08/10] mtd: rawnand: renesas: Use for_each_child_of_node_scoped()
2024-08-26 9:43 ` [PATCH -next RESEND 08/10] mtd: rawnand: renesas: " Jinjie Ruan
2024-08-26 9:53 ` Geert Uytterhoeven
@ 2024-09-06 15:03 ` Miquel Raynal
1 sibling, 0 replies; 30+ messages in thread
From: Miquel Raynal @ 2024-09-06 15:03 UTC (permalink / raw)
To: Jinjie Ruan, miquel.raynal, michal.simek, richard, vigneshr,
liang.yang, neil.armstrong, khilman, jbrunet, martin.blumenstingl,
matthias.bgg, angelogioacchino.delregno, heiko, mcoquelin.stm32,
alexandre.torgue, wens, jernej.skrabec, samuel, kees, gustavoars,
linux, robh, u.kleine-koenig, erick.archer, christophe.jaillet,
val, christophe.kerello, linux-mtd, linux-kernel,
linux-arm-kernel, linux-amlogic, linux-mediatek,
linux-renesas-soc, linux-rockchip, linux-stm32, krzk, jic23
On Mon, 2024-08-26 at 09:43:26 UTC, Jinjie Ruan wrote:
> Avoids the need for manual cleanup of_node_put() in early exits
> from the loop.
>
> Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next, thanks.
Miquel
^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [PATCH -next RESEND 07/10] mtd: rawnand: mtk: Use for_each_child_of_node_scoped()
2024-08-26 9:43 ` [PATCH -next RESEND 07/10] mtd: rawnand: mtk: " Jinjie Ruan
@ 2024-09-06 15:03 ` Miquel Raynal
0 siblings, 0 replies; 30+ messages in thread
From: Miquel Raynal @ 2024-09-06 15:03 UTC (permalink / raw)
To: Jinjie Ruan, miquel.raynal, michal.simek, richard, vigneshr,
liang.yang, neil.armstrong, khilman, jbrunet, martin.blumenstingl,
matthias.bgg, angelogioacchino.delregno, heiko, mcoquelin.stm32,
alexandre.torgue, wens, jernej.skrabec, samuel, kees, gustavoars,
linux, robh, u.kleine-koenig, erick.archer, christophe.jaillet,
val, christophe.kerello, linux-mtd, linux-kernel,
linux-arm-kernel, linux-amlogic, linux-mediatek,
linux-renesas-soc, linux-rockchip, linux-stm32, krzk, jic23
On Mon, 2024-08-26 at 09:43:25 UTC, Jinjie Ruan wrote:
> Avoids the need for manual cleanup of_node_put() in early exits
> from the loop.
>
> Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next, thanks.
Miquel
^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [PATCH -next RESEND 06/10] mtd: rawnand: meson: Use for_each_child_of_node_scoped()
2024-08-26 9:43 ` [PATCH -next RESEND 06/10] mtd: rawnand: meson: " Jinjie Ruan
@ 2024-09-06 15:03 ` Miquel Raynal
0 siblings, 0 replies; 30+ messages in thread
From: Miquel Raynal @ 2024-09-06 15:03 UTC (permalink / raw)
To: Jinjie Ruan, miquel.raynal, michal.simek, richard, vigneshr,
liang.yang, neil.armstrong, khilman, jbrunet, martin.blumenstingl,
matthias.bgg, angelogioacchino.delregno, heiko, mcoquelin.stm32,
alexandre.torgue, wens, jernej.skrabec, samuel, kees, gustavoars,
linux, robh, u.kleine-koenig, erick.archer, christophe.jaillet,
val, christophe.kerello, linux-mtd, linux-kernel,
linux-arm-kernel, linux-amlogic, linux-mediatek,
linux-renesas-soc, linux-rockchip, linux-stm32, krzk, jic23
On Mon, 2024-08-26 at 09:43:24 UTC, Jinjie Ruan wrote:
> Avoids the need for manual cleanup of_node_put() in early exits
> from the loop.
>
> Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next, thanks.
Miquel
^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [PATCH -next RESEND 05/10] mtd: rawnand: rockchip: Use for_each_child_of_node_scoped()
2024-08-26 9:43 ` [PATCH -next RESEND 05/10] mtd: rawnand: rockchip: " Jinjie Ruan
@ 2024-09-06 15:03 ` Miquel Raynal
0 siblings, 0 replies; 30+ messages in thread
From: Miquel Raynal @ 2024-09-06 15:03 UTC (permalink / raw)
To: Jinjie Ruan, miquel.raynal, michal.simek, richard, vigneshr,
liang.yang, neil.armstrong, khilman, jbrunet, martin.blumenstingl,
matthias.bgg, angelogioacchino.delregno, heiko, mcoquelin.stm32,
alexandre.torgue, wens, jernej.skrabec, samuel, kees, gustavoars,
linux, robh, u.kleine-koenig, erick.archer, christophe.jaillet,
val, christophe.kerello, linux-mtd, linux-kernel,
linux-arm-kernel, linux-amlogic, linux-mediatek,
linux-renesas-soc, linux-rockchip, linux-stm32, krzk, jic23
On Mon, 2024-08-26 at 09:43:23 UTC, Jinjie Ruan wrote:
> Avoids the need for manual cleanup of_node_put() in early exits
> from the loop.
>
> Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next, thanks.
Miquel
^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [PATCH -next RESEND 04/10] mtd: rawnand: marvell: drm/rockchip: Use for_each_child_of_node_scoped()
2024-08-26 9:43 ` [PATCH -next RESEND 04/10] mtd: rawnand: marvell: drm/rockchip: " Jinjie Ruan
@ 2024-09-06 15:03 ` Miquel Raynal
0 siblings, 0 replies; 30+ messages in thread
From: Miquel Raynal @ 2024-09-06 15:03 UTC (permalink / raw)
To: Jinjie Ruan, miquel.raynal, michal.simek, richard, vigneshr,
liang.yang, neil.armstrong, khilman, jbrunet, martin.blumenstingl,
matthias.bgg, angelogioacchino.delregno, heiko, mcoquelin.stm32,
alexandre.torgue, wens, jernej.skrabec, samuel, kees, gustavoars,
linux, robh, u.kleine-koenig, erick.archer, christophe.jaillet,
val, christophe.kerello, linux-mtd, linux-kernel,
linux-arm-kernel, linux-amlogic, linux-mediatek,
linux-renesas-soc, linux-rockchip, linux-stm32, krzk, jic23
On Mon, 2024-08-26 at 09:43:22 UTC, Jinjie Ruan wrote:
> Avoids the need for manual cleanup of_node_put() in early exits
> from the loop.
>
> Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next, thanks.
Miquel
^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [PATCH -next RESEND 03/10] mtd: rawnand: pl353: Use for_each_child_of_node_scoped()
2024-08-26 9:43 ` [PATCH -next RESEND 03/10] mtd: rawnand: pl353: " Jinjie Ruan
@ 2024-09-06 15:04 ` Miquel Raynal
0 siblings, 0 replies; 30+ messages in thread
From: Miquel Raynal @ 2024-09-06 15:04 UTC (permalink / raw)
To: Jinjie Ruan, miquel.raynal, michal.simek, richard, vigneshr,
liang.yang, neil.armstrong, khilman, jbrunet, martin.blumenstingl,
matthias.bgg, angelogioacchino.delregno, heiko, mcoquelin.stm32,
alexandre.torgue, wens, jernej.skrabec, samuel, kees, gustavoars,
linux, robh, u.kleine-koenig, erick.archer, christophe.jaillet,
val, christophe.kerello, linux-mtd, linux-kernel,
linux-arm-kernel, linux-amlogic, linux-mediatek,
linux-renesas-soc, linux-rockchip, linux-stm32, krzk, jic23
On Mon, 2024-08-26 at 09:43:21 UTC, Jinjie Ruan wrote:
> Avoids the need for manual cleanup of_node_put() in early exits
> from the loop by using for_each_child_of_node_scoped().
>
> Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next, thanks.
Miquel
^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [PATCH -next RESEND 02/10] mtd: rawnand: cadence: Use for_each_child_of_node_scoped()
2024-08-26 9:43 ` [PATCH -next RESEND 02/10] mtd: rawnand: cadence: " Jinjie Ruan
@ 2024-09-06 15:04 ` Miquel Raynal
0 siblings, 0 replies; 30+ messages in thread
From: Miquel Raynal @ 2024-09-06 15:04 UTC (permalink / raw)
To: Jinjie Ruan, miquel.raynal, michal.simek, richard, vigneshr,
liang.yang, neil.armstrong, khilman, jbrunet, martin.blumenstingl,
matthias.bgg, angelogioacchino.delregno, heiko, mcoquelin.stm32,
alexandre.torgue, wens, jernej.skrabec, samuel, kees, gustavoars,
linux, robh, u.kleine-koenig, erick.archer, christophe.jaillet,
val, christophe.kerello, linux-mtd, linux-kernel,
linux-arm-kernel, linux-amlogic, linux-mediatek,
linux-renesas-soc, linux-rockchip, linux-stm32, krzk, jic23
On Mon, 2024-08-26 at 09:43:20 UTC, Jinjie Ruan wrote:
> Avoids the need for manual cleanup of_node_put() in early exits
> from the loop by using for_each_child_of_node_scoped().
>
> Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next, thanks.
Miquel
^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [PATCH -next RESEND 01/10] mtd: rawnand: arasan: Use for_each_child_of_node_scoped()
2024-08-26 9:43 ` [PATCH -next RESEND 01/10] mtd: rawnand: arasan: " Jinjie Ruan
@ 2024-09-06 15:04 ` Miquel Raynal
0 siblings, 0 replies; 30+ messages in thread
From: Miquel Raynal @ 2024-09-06 15:04 UTC (permalink / raw)
To: Jinjie Ruan, miquel.raynal, michal.simek, richard, vigneshr,
liang.yang, neil.armstrong, khilman, jbrunet, martin.blumenstingl,
matthias.bgg, angelogioacchino.delregno, heiko, mcoquelin.stm32,
alexandre.torgue, wens, jernej.skrabec, samuel, kees, gustavoars,
linux, robh, u.kleine-koenig, erick.archer, christophe.jaillet,
val, christophe.kerello, linux-mtd, linux-kernel,
linux-arm-kernel, linux-amlogic, linux-mediatek,
linux-renesas-soc, linux-rockchip, linux-stm32, krzk, jic23
On Mon, 2024-08-26 at 09:43:19 UTC, Jinjie Ruan wrote:
> Avoids the need for manual cleanup of_node_put() in early exits
> from the loop.
>
> Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next, thanks.
Miquel
^ permalink raw reply [flat|nested] 30+ messages in thread
end of thread, other threads:[~2024-09-06 15:23 UTC | newest]
Thread overview: 30+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-26 9:43 [PATCH -next RESEND 00/10] mtd: Use for_each_child_of_node_scoped() Jinjie Ruan
2024-08-26 9:43 ` [PATCH -next RESEND 01/10] mtd: rawnand: arasan: " Jinjie Ruan
2024-09-06 15:04 ` Miquel Raynal
2024-08-26 9:43 ` [PATCH -next RESEND 02/10] mtd: rawnand: cadence: " Jinjie Ruan
2024-09-06 15:04 ` Miquel Raynal
2024-08-26 9:43 ` [PATCH -next RESEND 03/10] mtd: rawnand: pl353: " Jinjie Ruan
2024-09-06 15:04 ` Miquel Raynal
2024-08-26 9:43 ` [PATCH -next RESEND 04/10] mtd: rawnand: marvell: drm/rockchip: " Jinjie Ruan
2024-09-06 15:03 ` Miquel Raynal
2024-08-26 9:43 ` [PATCH -next RESEND 05/10] mtd: rawnand: rockchip: " Jinjie Ruan
2024-09-06 15:03 ` Miquel Raynal
2024-08-26 9:43 ` [PATCH -next RESEND 06/10] mtd: rawnand: meson: " Jinjie Ruan
2024-09-06 15:03 ` Miquel Raynal
2024-08-26 9:43 ` [PATCH -next RESEND 07/10] mtd: rawnand: mtk: " Jinjie Ruan
2024-09-06 15:03 ` Miquel Raynal
2024-08-26 9:43 ` [PATCH -next RESEND 08/10] mtd: rawnand: renesas: " Jinjie Ruan
2024-08-26 9:53 ` Geert Uytterhoeven
2024-09-06 15:03 ` Miquel Raynal
2024-08-26 9:43 ` [PATCH -next RESEND 09/10] mtd: rawnand: stm32_fmc2: " Jinjie Ruan
2024-09-06 15:03 ` Miquel Raynal
2024-08-26 9:43 ` [PATCH -next RESEND 10/10] mtd: rawnand: sunxi: " Jinjie Ruan
2024-09-06 15:03 ` Miquel Raynal
2024-08-26 9:52 ` [PATCH -next RESEND 00/10] mtd: " Miquel Raynal
2024-08-26 10:19 ` Krzysztof Kozlowski
2024-08-26 10:56 ` Jinjie Ruan
2024-08-26 12:49 ` Miquel Raynal
2024-08-26 12:56 ` Jinjie Ruan
2024-08-30 6:34 ` Jinjie Ruan
2024-08-30 7:45 ` Miquel Raynal
2024-08-26 10:53 ` Jinjie Ruan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).