From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D3F15C5472C for ; Mon, 26 Aug 2024 22:23:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Subject:Cc:To: From:Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Y/50k2BgJimFnQZKi4VoI7/6FLsT0LuN2lY3DITs2iw=; b=nUAFu728OPfIUKcaeY2ZUGQi/W 8oi940ZdXL1pAJORnPHL4t6TwoqXr9hC2Ylhh69lb75p0SLEA2lLy5BaBYTC7K5AA9jMUyUloM0Ej wqlsNlooVhrRCT05wtDuF0KwDpR1pxsiUdZolZQH+fZNuTRfZOECVQCt6FB0TtmF3KfGHQFtpgEjA 2/i3XVCWl9e8UDuXrxnRza38nO+elOFZPsZlFDi8R5oxwPYVCP6k0PqY6FKsPd6Co+Tnr9Nd1ULQ7 y2+JWJsJRf4KzYUZF4qZslEppKyh1d6XGluObGYuU+2jMCwMzjYB0sZxzrkVWiJqIoysPJVNOdPCw cg7DMftQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sii7l-00000008zGZ-1KXo; Mon, 26 Aug 2024 22:23:45 +0000 Received: from nyc.source.kernel.org ([2604:1380:45d1:ec00::3]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sii6a-00000008z4E-2un4 for linux-arm-kernel@lists.infradead.org; Mon, 26 Aug 2024 22:22:34 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 92F13A40DDF; Mon, 26 Aug 2024 22:22:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0FE93C4FE00; Mon, 26 Aug 2024 22:15:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1724710521; bh=n8gcZiAC0tOhqnbHGpl+P3dIj4Y7x2ew9/hSqEmdqYE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=f+rDslGmjbisVo9bTthG3D9FKhutZ8wRqbAo44ZxhIDHlbkIRfiNO+bHLyS8a2Jyx x96RnINdxQbltUMQdqBcJ8p1uXXRJpU9z9ONfCM8ELuiipd+Lnt5etFKM60/YJ1vcU ZxkRTzQ8PL6OgNlLYd5NY9Jgwf+jtzNGuw+5aUV22ULI/mQcwXnhjJrfj3LZPoJjCp Z44pZanGSjnzwNZ4yh5579PzsS0qw5SI9ETAR7lB4FxwT9rxunRB0vOlvU7gdsBugr QRTZZhpgw63eqigMMBJEulSLYVJ0l1Pzc8EeMpyB1wg5uYB3y6AmVrsDfCKmSKQ5Aq RS3fw3ejwkuJg== Date: Mon, 26 Aug 2024 15:15:18 -0700 From: Jakub Kicinski To: Yangtao Li Cc: clement.leger@bootlin.com, andrew@lunn.ch, f.fainelli@gmail.com, olteanv@gmail.com, davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, ulli.kroll@googlemail.com, linus.walleij@linaro.org, marcin.s.wojtas@gmail.com, linux@armlinux.org.uk, alexandre.torgue@foss.st.com, joabreu@synopsys.com, mcoquelin.stm32@gmail.com, hkallweit1@gmail.com, kees@kernel.org, justinstitt@google.com, u.kleine-koenig@pengutronix.de, horms@kernel.org, sd@queasysnail.net, linux-renesas-soc@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com Subject: Re: [net-next v2 6/9] net: ethernet: broadcom: bcm63xx_enet: Convert to devm_clk_get_enabled() Message-ID: <20240826151518.6ccaec1f@kernel.org> In-Reply-To: <20240823072122.2053401-7-frank.li@vivo.com> References: <20240823072122.2053401-1-frank.li@vivo.com> <20240823072122.2053401-7-frank.li@vivo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240826_152232_880829_8A700D8B X-CRM114-Status: UNSURE ( 9.99 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 23 Aug 2024 01:21:18 -0600 Yangtao Li wrote: > diff --git a/drivers/net/ethernet/broadcom/bcm63xx_enet.c b/drivers/net/ethernet/broadcom/bcm63xx_enet.c > index 3c0e3b9828be..6e288cee2c35 100644 > --- a/drivers/net/ethernet/broadcom/bcm63xx_enet.c > +++ b/drivers/net/ethernet/broadcom/bcm63xx_enet.c > @@ -1718,6 +1718,7 @@ static int bcm_enet_probe(struct platform_device *pdev) > struct bcm63xx_enet_platform_data *pd; move the local clock variables here, keep lines longest to shortest > int irq, irq_rx, irq_tx; > struct mii_bus *bus; > + struct clk *phy_clk, *mac_clk;