From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8FA90C5321E for ; Mon, 26 Aug 2024 07:31:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=HPaejHCSR6aBmP0YvOsLTW9thoS6Tf2vIlBxLGDv4Jg=; b=cYyjpoJQ8btZWQrKvIecBApIio G+YNUlmTPwKhZ3pz8q1U/VuyPTw3EP+VrO8/7VyzQIMGRgyOKBjGjMJibe0xvf+lSi8i4QftHNU/Z 935j30MCd3Bczgki8/EZAzksy6ZcwpyluZI0kqr1yxSmh4Av/li2cPCKelT6lhgfP43dZvi0Dj3C2 pIGHeISXBTjYzpGm0zoYthns6n11EVWmGuoPgqQqav60lz3fFOv0rwYBBB5uGx0ZBqCQywfpAAI/v xHx3Ej19cQUkIdgLroDZ3V6Cz9AkSl4HaqVqmLJAI/KRmVNU8TcO0Q2U7zz37bZr1FFL9jiEOKh2+ v+K1NjCQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1siUCB-00000006HC3-1HQR; Mon, 26 Aug 2024 07:31:23 +0000 Received: from nyc.source.kernel.org ([147.75.193.91]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1siUBO-00000006H3B-1LUR for linux-arm-kernel@lists.infradead.org; Mon, 26 Aug 2024 07:30:36 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 9FA9CA41197; Mon, 26 Aug 2024 07:30:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9CAFBC8CDC1; Mon, 26 Aug 2024 07:30:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1724657433; bh=nLJafC/RJkAiXMmcJ/serDyLuQ5oEl1N6bGyWiLxg4Y=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=cZ5RB3D5dAncRGaWeUEbGsIQ5WH4jGnpnWnV8DZ1XAd8FUaqpQlEmRmyGHxUjy2or EGubQ6IAp9znH/XaycXZFddQsIdY/cmGyWfuFUii1EcDC0bKiyJW1aNnc4ovJW3hiI I3/HDEPU3+UB+5O+WlgGGrjzS1pzGsM/wTGK6u5k= Date: Mon, 26 Aug 2024 09:30:30 +0200 From: Greg KH To: Markus Elfring Subject: Re: rtc: at91sam9: fix OF node leak in probe() error path Message-ID: <2024082622-freckles-armored-978c@gregkh> References: <20240825183103.102904-1-krzysztof.kozlowski@linaro.org> <675f1e34-784f-44d2-9774-2652b919eecd@web.de> <391cc2f7-4a88-4565-8653-e46bd77e28f8@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240826_003034_448691_98A3A0AE X-CRM114-Status: GOOD ( 17.05 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-rtc@vger.kernel.org, Alexandre Belloni , Arnd Bergmann , Boris Brezillon , LKML , Claudiu Beznea , stable@vger.kernel.org, Johan Hovold , Krzysztof Kozlowski , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Aug 26, 2024 at 09:12:32AM +0200, Markus Elfring wrote: > >>> Driver is leaking an OF node reference obtained from > >>> of_parse_phandle_with_fixed_args(). > >> > >> Is there a need to improve such a change description another bit? > >> > >> + Imperative mood > … > > Commit msg is fine. > … > >> + Tags like “Fixes” and “Cc” > > > > Read the patch. > > What does hinder you to take requirements from a known information source > better into account? > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.11-rc5#n94 > > Regards, > Markus > Hi, This is the semi-friendly patch-bot of Greg Kroah-Hartman. Markus, you seem to have sent a nonsensical or otherwise pointless review comment to a patch submission on a Linux kernel developer mailing list. I strongly suggest that you not do this anymore. Please do not bother developers who are actively working to produce patches and features with comments that, in the end, are a waste of time. Patch submitter, please ignore Markus's suggestion; you do not need to follow it at all. The person/bot/AI that sent it is being ignored by almost all Linux kernel maintainers for having a persistent pattern of behavior of producing distracting and pointless commentary, and inability to adapt to feedback. Please feel free to also ignore emails from them. thanks, greg k-h's patch email bot