From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4ADC0C5321D for ; Mon, 26 Aug 2024 13:28:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=LWn7wVfmmprjnu/69X9ETszd0EbTgOQvMdRaC3Oesj4=; b=MhsfLjjb3vVB8SKBg1x8fY6dHr 221xxVHC6vfe/OQQ+qogbAoWwChpRHe14WVKrqjDkBscNSVCOZdWH25yY/uZ3lOFMaZHHj3v8hKxW k/bH4/wyP+9tT+qj48QkMyi7adsjnMZk8WmLs1QvPUmR2He8tHDOYvG2KATGHVH4pL2H5DauXJeld AYFaCotszntGafl/v56TTzZwdLm/EQ9TqeyHcB+Dc8xxriuQ7KzEty5tZVDd4qV0YoaWahUNQ8ygE OLJkaA9WS8sw/3ig0LQGduailT1mV5FyZSPY/XIdXM9du9D4SPiw9Zvr9CaE8HEOrM3tU9Gbv6JFH l99qNFdQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1siZlh-00000007VYE-1tg0; Mon, 26 Aug 2024 13:28:25 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1siZkt-00000007VI1-2n2E for linux-arm-kernel@lists.infradead.org; Mon, 26 Aug 2024 13:27:37 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 97638CE0E9A; Mon, 26 Aug 2024 13:27:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2099FC5829B; Mon, 26 Aug 2024 13:11:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1724677868; bh=0ppJbQ1K1Yzftc2Bz5hjnDOj8PGFXrJ4oVr1tSmFbdU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=KBNA5jyAmqsMXesEJ/Jh3EpPV+JzcdC0kcca7j2q62fd1uzq94IftMuLFOk+oC0B2 W5+Sma+TJhKIwPof6m0DL3zc8x9LFW8j4QhdvNWsvZVidANj92hVN03Y5fpsfz5J9a ksE6zvb1rfAtnXeEcnM3oeBdCEsANtmLOGbh0UEw= Date: Mon, 26 Aug 2024 15:11:05 +0200 From: Greg Kroah-Hartman To: Harry Austen Cc: Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Michal Simek , Shubhrajyoti Datta , Dave Ertman , Ira Weiny , linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v3 7/9] uio: add Xilinx user clock monitor support Message-ID: <2024082655-cubicle-flashily-6ab3@gregkh> References: <20240826123602.1872-1-hpausten@protonmail.com> <20240826123602.1872-8-hpausten@protonmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240826123602.1872-8-hpausten@protonmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240826_062735_899338_490DEDE3 X-CRM114-Status: GOOD ( 18.77 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Aug 26, 2024 at 12:38:36PM +0000, Harry Austen wrote: > Xilinx clocking wizard IP core supports monitoring of up to four > optional user clock inputs, with a corresponding interrupt for > notification in change of clock state (stop, underrun, overrun or > glitch). Give userspace access to this monitor logic through use of the > UIO framework. > > Implemented as an auxiliary_driver to avoid introducing UIO dependency > to the main clock driver. > > Signed-off-by: Harry Austen > --- > drivers/uio/Kconfig | 8 ++++ > drivers/uio/Makefile | 1 + > drivers/uio/uio_xlnx_clk_mon.c | 71 ++++++++++++++++++++++++++++++++++ > 3 files changed, 80 insertions(+) > create mode 100644 drivers/uio/uio_xlnx_clk_mon.c > > diff --git a/drivers/uio/Kconfig b/drivers/uio/Kconfig > index b060dcd7c6350..ca8a53de26a67 100644 > --- a/drivers/uio/Kconfig > +++ b/drivers/uio/Kconfig > @@ -164,4 +164,12 @@ config UIO_DFL > opae-sdk/tools/libopaeuio/ > > If you compile this as a module, it will be called uio_dfl. > + > +config UIO_XLNX_CLK_MON > + tristate "Xilinx user clock monitor support" > + depends on COMMON_CLK_XLNX_CLKWZRD > + help > + Userspace I/O interface to the user clock monitor logic within the > + Xilinx Clocking Wizard IP core. Why do you want a UIO api for a clock device? What userspace code is going to access the hardware this way? Why not use the normal kernel/user apis instead? thanks, greg k-h