From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0D9DFC5320E for ; Tue, 27 Aug 2024 10:00:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Subject:Cc:To: From:Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=2UUzozClc1g/4wJHL7AZEfKpZ+z049vTa6KhZnn20Z8=; b=j8eYcW0nNh06oG8xuebdhM5WIV QWDPMk6M9eUFBK0dEkwO7qxChTMS/6CjPdFPzLZWLOcfp8YWEAhzV6EYkt0/K03oNvbXoflWGlLMK jYtE/GI9fMeLbTDvXHA7esQimR8LSKtfQAy6+Qi4JU4fjvn18uUUI8YmNX11JUZv4cmDsSx5/RzlX L3RERr61HXzK+N0hhsDmQ8X+MlzLnNZ3f6GInKQtvHaoKLY7j6KMVbKfdssEEoHMfjaXzL84ueOq0 F2smUhnASfwo4hQJ/htrtAEwWVSRsjp960Yo5QuDk8QxYL+H87r9pZBXHYbp1DbSvepLSmqlnYtx0 EWwzP3Dw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sit03-0000000Ahql-0aW8; Tue, 27 Aug 2024 10:00:31 +0000 Received: from relay5-d.mail.gandi.net ([2001:4b98:dc4:8::225]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sirsN-0000000ASdP-3I29 for linux-arm-kernel@lists.infradead.org; Tue, 27 Aug 2024 08:48:33 +0000 Received: by mail.gandi.net (Postfix) with ESMTPSA id 61CF41C0005; Tue, 27 Aug 2024 08:48:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1724748509; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2UUzozClc1g/4wJHL7AZEfKpZ+z049vTa6KhZnn20Z8=; b=RYaxzkwgyvA0kHKjcM0ddbBmpvVD9HrE+anbiBb+fKay0rhCN0u1RFwDaklS20Ghx4FlRE JEpTZueS3BbpQeJogXXfAtmLTAmI5DEhXwKbpoLHeQ8wBODAs9uyAvLERMElM+TTNOBs9T mJ6ysxcTXN5lg7ULV0F87ayOpogBLhj9B+SeXKvJxUWnt3rsXobvaRYodgCfq1i3/HmGW2 G0VAJ2khJzte84kaHaXyaS502p/GZVIv8sOS0jI1XEIxSV9Irx0lAVeueDPxOqk8r7jQw4 GXfdi3WAfrcK8WWIBs4Jyv+2RjWIR/zBaJH8F300HG50wRH3Z7dymRfEB+p9Ww== Date: Tue, 27 Aug 2024 10:48:25 +0200 From: Maxime Chevallier To: Dan Carpenter Cc: Pengfei Xu , davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com, Andrew Lunn , Jakub Kicinski , Eric Dumazet , Paolo Abeni , Russell King , linux-arm-kernel@lists.infradead.org, Christophe Leroy , Herve Codina , Florian Fainelli , Heiner Kallweit , Vladimir Oltean , =?UTF-8?B?S8O2cnk=?= Maincent , Jesse Brandeburg , Marek =?UTF-8?B?QmVow7pu?= , Piergiorgio Beruto , Oleksij Rempel , =?UTF-8?B?Tmljb2zDsg==?= Veronese , Simon Horman , mwojtas@chromium.org, Nathan Chancellor , Antoine Tenart , Marc Kleine-Budde , Romain Gantois Subject: Re: [PATCH net-next v17 11/14] net: ethtool: cable-test: Target the command to the requested PHY Message-ID: <20240827104825.5cbe0602@fedora-3.home> In-Reply-To: References: <20240709063039.2909536-1-maxime.chevallier@bootlin.com> <20240709063039.2909536-12-maxime.chevallier@bootlin.com> <20240827073359.5d47c077@fedora-3.home> Organization: Bootlin X-Mailer: Claws Mail 4.3.0 (GTK 3.24.43; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-GND-Sasl: maxime.chevallier@bootlin.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240827_014832_332698_82806F9B X-CRM114-Status: GOOD ( 10.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi again Dan, On Tue, 27 Aug 2024 11:27:48 +0300 Dan Carpenter wrote: > Could you add some comments to ethnl_req_get_phydev() what the NULL return > means vs the error pointers? I figured it out because the callers have comments > but it should be next to ethnl_req_get_phydev() as well. Actually I replied a bit too fast, this is already documented : https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/tree/net/ethtool/netlink.h#n284 Is this doc clear enough or should I still add some more explicit comments ? Thanks, Maxime