From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E77B4C54735 for ; Tue, 27 Aug 2024 11:11:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Subject:CC:To: From:Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=tJbWRYuxjoX5Uf2o9virIyDPPPA/Q6RF350zux9pyK4=; b=caepfRf0qtbrhUS5r9lJ5Qq1Op iZvdFcX1R0sUvO+6niRr5REkaBVDnSLhJcbsmI+FVuEBspdSxMVvjaHncn3LUMrItrc/sCFAY2nrK C8KtMb4cIBeitcF4qW7Rj0X4tGm9FLEonhgt98ZMcX9lpVlJROnEb3PyPzgxVsOY32Q3C5THh15qo wk+8aUD1orWa3y+M4wE7xKPoFXVeHmR6NiIQC82ykGq/tZn5DgqIRclxn1jBlKydu0ulWNZJ5G5Jh mts8xLkKtUy9+jCkC0Q7V4I6jYRxcL/YKFzJXWU0llbXnT1pwF6Jx+SWszM+cFn2lcDAlOtzPa3yY QSnlY/9w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1siu6A-0000000Aw7s-3RxR; Tue, 27 Aug 2024 11:10:54 +0000 Received: from frasgout.his.huawei.com ([185.176.79.56]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1siu5L-0000000AvuZ-0n5y for linux-arm-kernel@lists.infradead.org; Tue, 27 Aug 2024 11:10:04 +0000 Received: from mail.maildlp.com (unknown [172.18.186.231]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4WtPq92dSwz6J76Z; Tue, 27 Aug 2024 19:05:57 +0800 (CST) Received: from lhrpeml500005.china.huawei.com (unknown [7.191.163.240]) by mail.maildlp.com (Postfix) with ESMTPS id 519DE1400D4; Tue, 27 Aug 2024 19:09:55 +0800 (CST) Received: from localhost (10.203.177.66) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Tue, 27 Aug 2024 12:09:54 +0100 Date: Tue, 27 Aug 2024 12:09:53 +0100 From: Jonathan Cameron To: Yangtao Li CC: , , , , , , , , , , , , , , , , , , , , , , , , , , Maxime Chevallier , Christophe JAILLET Subject: Re: [net-next v3 8/9] net: mvpp2: Convert to devm_clk_get_enabled() and devm_clk_get_optional_enabled() Message-ID: <20240827120953.00005450@Huawei.com> In-Reply-To: <20240827095712.2672820-9-frank.li@vivo.com> References: <20240827095712.2672820-1-frank.li@vivo.com> <20240827095712.2672820-9-frank.li@vivo.com> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.203.177.66] X-ClientProxiedBy: lhrpeml500006.china.huawei.com (7.191.161.198) To lhrpeml500005.china.huawei.com (7.191.163.240) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240827_041003_410008_E080E886 X-CRM114-Status: UNSURE ( 9.49 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 27 Aug 2024 03:57:11 -0600 Yangtao Li wrote: > Use devm_clk_get_enabled() and devm_clk_get_optional_enabled() > to simplify code. > > Signed-off-by: Yangtao Li > Reviewed-by: Maxime Chevallier > Tested-by: Maxime Chevallier > Suggested-by: Christophe JAILLET > Reviewed-by: Marcin Wojtas > > @@ -7745,12 +7710,6 @@ static void mvpp2_remove(struct platform_device *pdev) > > if (!dev_of_node(&pdev->dev)) > return; Given this makes no difference any more, drop the above dev_of_node() check. > - > - clk_disable_unprepare(priv->axi_clk); > - clk_disable_unprepare(priv->mg_core_clk); > - clk_disable_unprepare(priv->mg_clk); > - clk_disable_unprepare(priv->pp_clk); > - clk_disable_unprepare(priv->gop_clk); > } > > static const struct of_device_id mvpp2_match[] = {