From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6BC6DC54734 for ; Tue, 27 Aug 2024 12:39:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=lDz4ISBXWZCRlL/3unK7Hse04bz7RKVPVPVtS46cgMQ=; b=OmexRcd2NEbYc7BV40dWv//lwu Qa49MNCTOq4H1SA/hLN33XM9Q6o1QVPfqS0QuUSUnT08NqoltlSAy77aZa+AMi0ytxiYjkxwupwlN 6Drv/S8jZdbvJcNYI5aMZvffByBSkdK8mDHDC3vHSGdBZVyBWiCklKUToK/wExO780bW0CF9fAQX+ Uigqd/PfT/Sp82mHaR75LXJl5iBuAT1qZ4frTL9P5y1i8v6Nc+fK7f1D6xOfKaZLrg843+kjms1s3 X/D8bGozc4tMdt8q4TS1bJMwVZd3X/zooLHQ5ZO+tkddHeNCviYJTEnkclGYqwAwO7X3U7ngv2i4g dPsohjiA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sivU0-0000000BHXZ-0KEf; Tue, 27 Aug 2024 12:39:36 +0000 Received: from sin.source.kernel.org ([145.40.73.55]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sivOW-0000000BFpa-275s for linux-arm-kernel@lists.infradead.org; Tue, 27 Aug 2024 12:33:57 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id A92E4CE11E1; Tue, 27 Aug 2024 12:33:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E69D6C61042; Tue, 27 Aug 2024 12:33:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1724762032; bh=lDz4ISBXWZCRlL/3unK7Hse04bz7RKVPVPVtS46cgMQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=gJ3+xc0Td318s/3ReSPtyBnJasCSAYV3s4/vS+ZGK/6gmRbJMz68oVD5FdT/i4We2 nedDkvlnoap8QcF26kJENeQe3WQGpaPQWmdUinbgSLmy7Ck7q+lCIgqs9Nf8Q42l7r LuF2i981vDOoB102SRf93nhqB5m93ktaX/pnvSv7ihZ0d8P1hWK5kdSOMO5MqvzyOp OfzxSD6ts6NHOARWUPx7ykt3e+qMTNfzWSBRu7NCOGmjy6nClRWNBc44QlOfGDzra8 3nyx6Zuzr3u75E0bp329u3zP418Feggn5PtxGWlzLdzO232LOB8cpCeR3qFgiDfuBo ZXmgGqCCyw4JQ== Date: Tue, 27 Aug 2024 13:33:47 +0100 From: Will Deacon To: Dev Jain Cc: shuah@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kselftest@vger.kernel.org, Catalin.Marinas@arm.com, broonie@kernel.org, ryan.roberts@arm.com, Anshuman.Khandual@arm.com, aneesh.kumar@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] selftests/arm64: Fix build warnings for abi Message-ID: <20240827123347.GC4679@willie-the-truck> References: <20240827051851.3738533-1-dev.jain@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240827051851.3738533-1-dev.jain@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240827_053356_749929_08F823CB X-CRM114-Status: UNSURE ( 8.57 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Aug 27, 2024 at 10:48:51AM +0530, Dev Jain wrote: > A "%s" is missing in ksft_exit_fail_msg(); instead, use the newly > introduced ksft_exit_fail_perror(). Also, uint64_t corresponds to > unsigned 64-bit integer, so use %lx instead of %llx. What's wrong with using %llx for a uint64_t? I think that part of the code is fine as-is. Will