From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7F264C54734 for ; Tue, 27 Aug 2024 13:13:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=1xlfb7CvBR3F8wsMBbhPbk/ajfmbPnxH4tDnVYhpnEw=; b=1mKAEQsVB3R4V/eIAgaC5jcqZ5 +/tTFgDawtKtiTSSNHGmXP1eNq+XvobDTcR8kruXAroL/kmEHfyVzhULnfVQCrX84G6Cp2C23Cu25 Go7lw96verz8rPMZn9SftoiuoLhEMawU+iwFNoZ9XWPLqQeRYv0phjGipf8w4C1/9blFdjBtMN8Q8 wxfhSteopUtyUPyJ+AmSC13odOBXtAtVjDpN40Mn1aWwAVmzuPXYCppPuIzABK7IA6mXBN439QwnL q9BNiZrobqFYuiV9TGKooEuJsYNfqir2Dm9CNQKm6Q/OQdNsyRXh0Jun/cPCPhXtAwtC0YtRjbvKq 5OFWdxHw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1siw0Z-0000000BP1H-0dIh; Tue, 27 Aug 2024 13:13:15 +0000 Received: from nyc.source.kernel.org ([147.75.193.91]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sivzl-0000000BOpj-3gl7 for linux-arm-kernel@lists.infradead.org; Tue, 27 Aug 2024 13:12:27 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 0ECEFA419FC; Tue, 27 Aug 2024 13:12:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6C142C4E677; Tue, 27 Aug 2024 13:02:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1724763759; bh=2cH48CeKweIa6Il0vytWOeXd373y5p9pQgTadJZeWak=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=sUHAfuRQQuWC0D0kxcnHrk1+9OQBRN3Eu+Hz5pam8SAGEMWKPHYbUo2km69hf4nSR b/b3qjYBQZC8eZkLF9+Fw44IfQmBJRX9eIlKdnJPqcU2DGh1DXcFVR493ASgv+pNtM ug7egLXUkynEUrJFlHiCiXV/vjCwcbVx1agAwkKAeCx2RQLUFZmZof+0OHI55kf0XD iTGJarE1EItpBR1teHm0tYQzW4tMvgpd0zCPhIU2QXDdePmoSJiONCs7NZl2sJQ6mY e2HyJBkO9RFzxEjRB52F8RevQWKlE8QMoolJnpq+QqF2qwfKliBhe03P9e62d6qve8 6vPdKIc4WmEaw== Date: Tue, 27 Aug 2024 14:02:34 +0100 From: Will Deacon To: Nicolin Chen Cc: robin.murphy@arm.com, joro@8bytes.org, jgg@nvidia.com, thierry.reding@gmail.com, vdumpa@nvidia.com, jonathanh@nvidia.com, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-tegra@vger.kernel.org Subject: Re: [PATCH v13 06/10] iommu/arm-smmu-v3: Add acpi_smmu_acpi_probe_model for impl Message-ID: <20240827130233.GF4772@willie-the-truck> References: <8a2629bb98cabb1be72b32c120bb5ed0114b21bc.1724453781.git.nicolinc@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8a2629bb98cabb1be72b32c120bb5ed0114b21bc.1724453781.git.nicolinc@nvidia.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240827_061226_003613_D24D964A X-CRM114-Status: GOOD ( 18.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Aug 23, 2024 at 05:10:40PM -0700, Nicolin Chen wrote: > For model-specific implementation, repurpose the acpi_smmu_get_options() > to a wider acpi_smmu_acpi_probe_model(). A new model can add to the list > in this new function. > > Suggested-by: Will Deacon > Signed-off-by: Nicolin Chen > --- > drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c | 18 +++++++++++++----- > 1 file changed, 13 insertions(+), 5 deletions(-) > > diff --git a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c > index afdb8a76a72a..ceb31d63f79b 100644 > --- a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c > +++ b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c > @@ -4341,18 +4341,28 @@ static int arm_smmu_device_hw_probe(struct arm_smmu_device *smmu) > } > > #ifdef CONFIG_ACPI > -static void acpi_smmu_get_options(u32 model, struct arm_smmu_device *smmu) > +static int acpi_smmu_iort_probe_model(struct acpi_iort_node *node, > + struct arm_smmu_device *smmu) > { > - switch (model) { > + struct acpi_iort_smmu_v3 *iort_smmu = > + (struct acpi_iort_smmu_v3 *)node->node_data; > + > + switch (iort_smmu->model) { > case ACPI_IORT_SMMU_V3_CAVIUM_CN99XX: > smmu->options |= ARM_SMMU_OPT_PAGE0_REGS_ONLY; > break; > case ACPI_IORT_SMMU_V3_HISILICON_HI161X: > smmu->options |= ARM_SMMU_OPT_SKIP_PREFETCH; > break; > + case ACPI_IORT_SMMU_V3_GENERIC: > + break; > + default: > + dev_err(smmu->dev, "Unknown/unsupported IORT model!\n"); > + return -ENXIO; We probably don't want this 'default' case, otherwise the driver will need to be updated every time there's a new model. If you agree, then I can just drop this bit when applying. Will