From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 78EDEC54734 for ; Tue, 27 Aug 2024 14:49:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=XeeF+WQLL0dmjNRchOJHaGCmt9kFYTLtoRHCM85xYEs=; b=AexXK2xt1ScSsQTsb7H1qRw5ms 0c8mO4Ny2ZWKcHYhSvVLTiOUuLDz2icrgd3c+oedRNzo3OpPZ+J1yVxiLeAfcobfiWGEKqdbJbN7D /XSRrB7nnDyWnaOeYv11HRJ6xMgcZc/qnyJmakC5slKDttG+gPY+1gnLjYbNz1H4Aq7pAPfkkU23Z Q6NrouKAaA71nCnUpDBwtSURW4kWSqMk2xuXk71NnmSISTvmoWdFSuOfyL+yZWdmo0Eo3RuzuN+bx zPVr2KEcZ6+BEfCq9CTz3GI6WZdtIphYfLQ3/JBR5beEW6cf/tol1zqVty0lFeCpim4clfEuJifMK 8UWXBwhQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sixVY-0000000BjBh-31yH; Tue, 27 Aug 2024 14:49:20 +0000 Received: from nyc.source.kernel.org ([147.75.193.91]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sixUk-0000000Bj14-0js4 for linux-arm-kernel@lists.infradead.org; Tue, 27 Aug 2024 14:48:31 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id CA6D7A41B7F; Tue, 27 Aug 2024 14:48:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7B6C4C6107B; Tue, 27 Aug 2024 14:48:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1724770108; bh=xSqwNdhpJetQ1Ga5qLAHMjPCMQYO+GkW/IDB1xWE8zM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=o8UGOyDomGVhy1QCxq1ZaKUwSAbW5YdZ7bzFjTDNtZhP+MiLXGy8H4LUCK1XIXGoG HeWZEabT9DBgIhHuyGQRd8OuDHltgV29H/iEkNPnL2uEFIsLyQ5bdlLMnUycu0t6vY tGghGFURbF7nKTm/brFE+lFinwKiC49lbmKC6hy/YPZVMm+AToGe9J1D4J2KfvQx50 qmp4sjJdVPdKfsuWqOZYcoTpZvYTJ5pt1dYutSxjniTzSYIDXZnBCu/4QtT5HvdqCm NRJdBsdkBcmvav0MPsQFo3jBKhq1FGtCKvrvyp3dG8US7OSo8YZnV+gRQDqHRJLmCb /8mLri0zG2TQA== Date: Tue, 27 Aug 2024 15:48:21 +0100 From: Simon Horman To: Yangtao Li Cc: clement.leger@bootlin.com, andrew@lunn.ch, f.fainelli@gmail.com, olteanv@gmail.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, ulli.kroll@googlemail.com, linus.walleij@linaro.org, marcin.s.wojtas@gmail.com, linux@armlinux.org.uk, alexandre.torgue@foss.st.com, joabreu@synopsys.com, mcoquelin.stm32@gmail.com, hkallweit1@gmail.com, kees@kernel.org, justinstitt@google.com, u.kleine-koenig@pengutronix.de, sd@queasysnail.net, linux-renesas-soc@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, Maxime Chevallier Subject: Re: [net-next v2 1/9] net: stmmac: dwmac-intel-plat: Convert to devm_clk_get_enabled() Message-ID: <20240827144821.GH1368797@kernel.org> References: <20240823072122.2053401-1-frank.li@vivo.com> <20240823072122.2053401-2-frank.li@vivo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240823072122.2053401-2-frank.li@vivo.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240827_074830_371347_B5B91592 X-CRM114-Status: GOOD ( 20.71 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Aug 23, 2024 at 01:21:13AM -0600, Yangtao Li wrote: > Convert devm_clk_get(), clk_prepare_enable() to a single > call to devm_clk_get_enabled(), as this is exactly > what this function does. > > Signed-off-by: Yangtao Li > Reviewed-by: Maxime Chevallier > --- > .../net/ethernet/stmicro/stmmac/dwmac-intel-plat.c | 11 ++--------- > 1 file changed, 2 insertions(+), 9 deletions(-) > > diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-intel-plat.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-intel-plat.c > index d68f0c4e7835..dcbae653ab8c 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-intel-plat.c > +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-intel-plat.c > @@ -104,12 +104,10 @@ static int intel_eth_plat_probe(struct platform_device *pdev) > > /* Enable TX clock */ > if (dwmac->data->tx_clk_en) { > - dwmac->tx_clk = devm_clk_get(&pdev->dev, "tx_clk"); > + dwmac->tx_clk = devm_clk_get_enabled(&pdev->dev, "tx_clk"); As it looks like there will be a v3 anyway, a minor nit from my side: IMHO, the line above could be trivially wrapped to keep it <= 80 columns wide, which is still preferred by Networking code. > if (IS_ERR(dwmac->tx_clk)) > return PTR_ERR(dwmac->tx_clk); > > - clk_prepare_enable(dwmac->tx_clk); > - > /* Check and configure TX clock rate */ > rate = clk_get_rate(dwmac->tx_clk); > if (dwmac->data->tx_clk_rate && > @@ -149,20 +147,15 @@ static int intel_eth_plat_probe(struct platform_device *pdev) > } > > ret = stmmac_dvr_probe(&pdev->dev, plat_dat, &stmmac_res); > - if (ret) { > - clk_disable_unprepare(dwmac->tx_clk); > + if (ret) > return ret; > - } > > return 0; > } > > static void intel_eth_plat_remove(struct platform_device *pdev) > { > - struct intel_dwmac *dwmac = get_stmmac_bsp_priv(&pdev->dev); > - > stmmac_pltfr_remove(pdev); > - clk_disable_unprepare(dwmac->tx_clk); > } > > static struct platform_driver intel_eth_plat_driver = { > -- > 2.39.0 >