From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5B7ABC54734 for ; Tue, 27 Aug 2024 14:53:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=P3nX1C/3oZl+qChi5vRFN5L49pwjCpNXW0VHqT6Y8uw=; b=wdPBj10tnEIkf97RBPi0dZ4apR fMnybGeI106+9w8vGuqJkRJggSsxiYLi/S3NPBppZdK/QfcIs4RegH41qrL+sL8NzTSw02MaQPu+M jAyMPkHTutjxVqXr1xhimmgIAdcGMpWL3EWdYEnouROIT532zy052IGoXOUlTaRMezcZCZ5nixUV+ XmFDMazzX9xfEJCY6Wfdt9OV+eM7Pp6K+sSFtZgm6ExCO7VexFbpPSxSn220M6LeX4yfxgQMcldBm 4x0Yqv3QynsKZJIN2O13pXEyyVZd1JKU0ojN5Zc72ZpQCfSGtOutZYBx810dv5s6ahDnoya+xsA0T tvs2RAyw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sixZO-0000000Bk3a-3Qk0; Tue, 27 Aug 2024 14:53:18 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sixY0-0000000Bjke-49Yi for linux-arm-kernel@lists.infradead.org; Tue, 27 Aug 2024 14:51:55 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id ABA9ACE134C; Tue, 27 Aug 2024 14:51:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DBFF4C4DE06; Tue, 27 Aug 2024 14:51:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1724770309; bh=NWB5s3i1kq4dW2CrUfpkajBrMSzQ94Hq46U32Q7Ft/c=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=p8iuOBjmg0viE6cadtY00LPh0+MNMt7PW9OUsvoUrh0nm2rdR/TUM6qaDTQjz18fg Zjy9nIq8LioA2jN83GxP/BBPmGlrYrQtoIAV2Ct2gHJRC0ISJ8MESFgGxEOnPFcw1G yfphDH4zRsiRR4i2BDIDga1R9Rs0rhMkQ57Sbr9jZ3Yk2CjcyWkmdQ+cYBJ5812lgy EqFhhzll9QJzUNZFtazSm3uVCZF4TieaeONPS04BWAR5ESkjYtoJnGY8stgBYfq0dW Iqu301WDbqghCwHu2hXY0JoURJPr9EPh7jnt0yYSOKfVzHu1m/e7zZTed2f5zpjAMB 1idVVIQyLuYPQ== Date: Tue, 27 Aug 2024 15:51:42 +0100 From: Simon Horman To: Yangtao Li Cc: clement.leger@bootlin.com, andrew@lunn.ch, f.fainelli@gmail.com, olteanv@gmail.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, ulli.kroll@googlemail.com, linus.walleij@linaro.org, marcin.s.wojtas@gmail.com, linux@armlinux.org.uk, alexandre.torgue@foss.st.com, joabreu@synopsys.com, mcoquelin.stm32@gmail.com, hkallweit1@gmail.com, u.kleine-koenig@pengutronix.de, jacob.e.keller@intel.com, justinstitt@google.com, sd@queasysnail.net, linux-renesas-soc@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, Maxime Chevallier Subject: Re: [net-next v3 1/9] net: stmmac: dwmac-intel-plat: Convert to devm_clk_get_enabled() Message-ID: <20240827145142.GI1368797@kernel.org> References: <20240827095712.2672820-1-frank.li@vivo.com> <20240827095712.2672820-2-frank.li@vivo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240827095712.2672820-2-frank.li@vivo.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240827_075153_280910_A8D6A301 X-CRM114-Status: GOOD ( 17.61 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Aug 27, 2024 at 03:57:04AM -0600, Yangtao Li wrote: > Convert devm_clk_get(), clk_prepare_enable() to a single > call to devm_clk_get_enabled(), as this is exactly > what this function does. > > Signed-off-by: Yangtao Li > Reviewed-by: Maxime Chevallier > --- > .../net/ethernet/stmicro/stmmac/dwmac-intel-plat.c | 11 ++--------- > 1 file changed, 2 insertions(+), 9 deletions(-) > > diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-intel-plat.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-intel-plat.c > index d68f0c4e7835..dcbae653ab8c 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-intel-plat.c > +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-intel-plat.c > @@ -104,12 +104,10 @@ static int intel_eth_plat_probe(struct platform_device *pdev) > > /* Enable TX clock */ > if (dwmac->data->tx_clk_en) { > - dwmac->tx_clk = devm_clk_get(&pdev->dev, "tx_clk"); > + dwmac->tx_clk = devm_clk_get_enabled(&pdev->dev, "tx_clk"); As it looks like there will be a v4 anyway, a minor nit from my side: IMHO, the line above could be trivially wrapped to keep it <= 80 columns wide, which is still preferred by Networking code. > if (IS_ERR(dwmac->tx_clk)) > return PTR_ERR(dwmac->tx_clk); > > - clk_prepare_enable(dwmac->tx_clk); > - > /* Check and configure TX clock rate */ > rate = clk_get_rate(dwmac->tx_clk); > if (dwmac->data->tx_clk_rate && ...