From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 704D9C5472D for ; Wed, 28 Aug 2024 07:08:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Type:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To :Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=YveW8MNJMQ/wSeyOIIEOplXeFkVWS1wpWaPUQ1l3sG8=; b=FuHxevGQT1kqqk9s5XUgR3bUrs BvPJUBC/LDGHRKg9+bJPew4hm6HHdH0dKUZyjlDRBE2XaBOLf4H0k2sFVmw+1gy3h3Yn9tZjtdRWI YtldjJCqdeqlbLEf5MuTvhJhr3ofLf3fD6OfG+sJ531EhBIotiCv90U2NYYgwA+jkTUudJTW2NGt4 XsAkuywOB+J9+gjz2RvwhX0lYC9gIjCvkF1fy7N3G74OnYcIE6if0xsz0SA/A1rBXjhICxz6g4MFV e4x1yHXZB3sMr9uilxuEW2n2q/6AooKf5Awxcyvcemq0cPM6RjEnFYtuxbGe7lmOYqduaMQcB3zyq f5hW1D7w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sjCmf-0000000ECb4-2Pf2; Wed, 28 Aug 2024 07:08:01 +0000 Received: from mail.thorsis.com ([217.92.40.78]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sjClq-0000000ECQ3-0vp8 for linux-arm-kernel@lists.infradead.org; Wed, 28 Aug 2024 07:07:12 +0000 Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id B2D851483481; Wed, 28 Aug 2024 09:07:06 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thorsis.com; s=dkim; t=1724828827; h=from:subject:date:message-id:to:cc:mime-version:content-type: in-reply-to:references; bh=YveW8MNJMQ/wSeyOIIEOplXeFkVWS1wpWaPUQ1l3sG8=; b=MyIX8IekILFmGAfenx/7D7jUKZ3EyHqDgfamPvb/F96IFLknxC7qedvz5Skt8188Hx7OhX iMHkGqz4CSVvDts1r+2JD1vWh93aVy8ojZAE6wsfIS81PR0sy44Y9fGi6WqvlR1DDvoAHB KYSZH9Nz0roL/a4KAwDM7ktHkTf3LOTiCMLhw51cAJHpVhzxONQJN0vDCVXpy1pHoe0Klg Vdhe63aRbGxzQI6EdG33TrQX+eALL076WzqPvovSjTw754QQikX+mcnm7nEXQ5yI032bFH zq7JmlNUK8NInOywWP189UpOzY2zPdeTHdx7kpaqj9DeanIyjZ9tv+qipev/1w== Date: Wed, 28 Aug 2024 09:07:05 +0200 From: Alexander Dahl To: claudiu beznea Subject: Re: [PATCH 3/3] ARM: dts: microchip: Use SCKC_{TD, MD}_SLCK IDs for clk32k clocks Message-ID: <20240828-chivalry-brunch-7e21bd12b7fa@thorsis.com> Mail-Followup-To: claudiu beznea , nicolas.ferre@microchip.com, alexandre.belloni@bootlin.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, mturquette@baylibre.com, sboyd@kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org References: <20240826173116.3628337-1-claudiu.beznea@tuxon.dev> <20240826173116.3628337-4-claudiu.beznea@tuxon.dev> <8ae724e3-f467-4df4-b8cc-f03489bd0f35@tuxon.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8ae724e3-f467-4df4-b8cc-f03489bd0f35@tuxon.dev> User-Agent: Mutt/2.2.12 (2023-09-09) X-Last-TLS-Session-Version: TLSv1.3 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240828_000710_617121_46003D27 X-CRM114-Status: GOOD ( 20.75 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: robh@kernel.org, conor+dt@kernel.org, devicetree@vger.kernel.org, sboyd@kernel.org, linux-kernel@vger.kernel.org, mturquette@baylibre.com, alexandre.belloni@bootlin.com, krzk+dt@kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello Claudiu, Am Mon, Aug 26, 2024 at 08:42:10PM +0300 schrieb claudiu beznea: > > > On 26.08.2024 20:31, Claudiu Beznea wrote: > > Use the newly introduced macros instead of raw number. With this device > > tree code is a bit easier to understand. > > > > Signed-off-by: Claudiu Beznea > > --- > > arch/arm/boot/dts/microchip/sam9x60.dtsi | 18 +++++++++--------- > > arch/arm/boot/dts/microchip/sama7g5.dtsi | 16 ++++++++-------- > > 2 files changed, 17 insertions(+), 17 deletions(-) > > > > diff --git a/arch/arm/boot/dts/microchip/sam9x60.dtsi b/arch/arm/boot/dts/microchip/sam9x60.dtsi > > index 04a6d716ecaf..eeda277e684f 100644 > > --- a/arch/arm/boot/dts/microchip/sam9x60.dtsi > > +++ b/arch/arm/boot/dts/microchip/sam9x60.dtsi > > @@ -560,7 +560,7 @@ tcb0: timer@f8008000 { > > #size-cells = <0>; > > reg = <0xf8008000 0x100>; > > interrupts = <17 IRQ_TYPE_LEVEL_HIGH 0>; > > - clocks = <&pmc PMC_TYPE_PERIPHERAL 17>, <&clk32k 0>; > > + clocks = <&pmc PMC_TYPE_PERIPHERAL 17>, <&clk32k SCKC_MD_SLCK>; > > Actually, looking again at it, I don't know if it worth as we use numbers > directly also for other PMC clock IDs. I think in this case it is worth it. The macros you added are more like the already existing PMC_MCK et al. macros for PMC_TYPE_CORE and do essentially the same thing in driver code working as somewhat arbitrary array index, without relation to SoC internals. The PMC clock IDs on the other hand are for PMC_TYPE_PERIPHERAL and are that long list in the Peripheral Identifiers table and correspond to the SoC internal IDs, which are not used in the same way. So from my point of view, the patch series is valuable and should be further worked on. Greets Alex > Sorry for the noise, > Claudiu Beznea > > >