From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5B530C54734 for ; Wed, 28 Aug 2024 08:15:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Type:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To :Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Ae8VdjX8mFVpb9WPRFks2pGa/7r509LGvwKGNfqo+B0=; b=obVkcQoNm4Fbz/f/MNtFS3Ie6A j0J+VerhJetn4WFW0l7FUOZ/P74fk/j2LsgGGIs0IfPJnH8+gzHe3Q4xPmskRFYuG5CbH7X35fmBD 5RWAeVPeZhCBHJ7OGbQ5GtXcsBntgy+SsuW18W+fcEzjAvESBa1fQwH1x50QjQiRQ85BxMyBmPzy6 FcU0BzgIXfJIgnXSBLkVC34XOYxwXiY91TMEfO8mxLuwBHQ42NUUFqrG507mONxw68+uhKGoqDFm/ 7Sivt6yFTHlx+kzGhXOMVHhLRkv0VCHiVM25GsQmaLPTmjC6m2t+MQNrMadNfcq1sQ7OE++HN0Tei ltyM6E6g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sjDqC-0000000EUmE-3gFI; Wed, 28 Aug 2024 08:15:44 +0000 Received: from mail.thorsis.com ([2003:a:e28:26e4::10]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sjDpN-0000000EUZa-0TtW for linux-arm-kernel@lists.infradead.org; Wed, 28 Aug 2024 08:14:54 +0000 Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 297F1148349A; Wed, 28 Aug 2024 10:14:49 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thorsis.com; s=dkim; t=1724832891; h=from:subject:date:message-id:to:cc:mime-version:content-type: in-reply-to:references; bh=Ae8VdjX8mFVpb9WPRFks2pGa/7r509LGvwKGNfqo+B0=; b=hmA4HqvY9T09iAg1FrAd7k2vsYfmYPthRH1VE4iYKlbvbyNFI/C/U3vXqcuCP2RuB9mcNX 81C7v5xIyHrIdea59w2Bfa6w3DGGLDTKMar/lszE15UGQTV9ojPpnwmCMVXAnhg4qzHFFa OGmdJAB6YQqIbP8uSqoqs3bVpLUcPhsQNkoIMnBeQw+5Nh1ww4s9/4wbyx/9HBbofaTGha +8luElagJSxLRfWY1/+qQxBlAN+23otUHc6xiv3X9usLY/PYAivP6k7nGYK0O9ZKMpdgKM Qn614qz+oHjgFneD8kPWFP1xAyuB73E0L2s3u+GrnqOMIJpSOKuMxS3vngQVBQ== Date: Wed, 28 Aug 2024 10:14:48 +0200 From: Alexander Dahl To: claudiu beznea Subject: Re: [PATCH v1 07/12] nvmem: microchip-otpc: Add missing register definitions Message-ID: <20240828-making-gangrene-786ec368b106@thorsis.com> Mail-Followup-To: claudiu beznea , Christian Melki , Srinivas Kandagatla , "moderated list:MICROCHIP OTPC DRIVER" , open list , Nicolas Ferre References: <20240821105943.230281-1-ada@thorsis.com> <20240821105943.230281-8-ada@thorsis.com> <5228af83-b423-4f51-820a-edfc40017ca8@tuxon.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5228af83-b423-4f51-820a-edfc40017ca8@tuxon.dev> User-Agent: Mutt/2.2.12 (2023-09-09) X-Last-TLS-Session-Version: TLSv1.3 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240828_011453_339865_42F55902 X-CRM114-Status: GOOD ( 13.50 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alexander Dahl , Christian Melki , open list , Srinivas Kandagatla , "moderated list:MICROCHIP OTPC DRIVER" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello Claudiu, Am Sat, Aug 24, 2024 at 06:54:02PM +0300 schrieb claudiu beznea: > > > On 21.08.2024 13:59, Alexander Dahl wrote: > > According to datasheets DS60001765B for SAMA7G5 and DS60001579G for > > SAM9X60. > > > > Signed-off-by: Alexander Dahl > > --- > > drivers/nvmem/microchip-otpc.c | 15 +++++++++++++++ > > 1 file changed, 15 insertions(+) > > > > diff --git a/drivers/nvmem/microchip-otpc.c b/drivers/nvmem/microchip-otpc.c > > index b8ed7412dbca..4630e96243ac 100644 > > --- a/drivers/nvmem/microchip-otpc.c > > +++ b/drivers/nvmem/microchip-otpc.c > > @@ -21,9 +21,24 @@ > > #define MCHP_OTPC_AR (0x8) > > #define MCHP_OTPC_SR (0xc) > > #define MCHP_OTPC_SR_READ BIT(6) > > +#define MCHP_OTPC_IER (0x10) > > +#define MCHP_OTPC_IDR (0x14) > > +#define MCHP_OTPC_IMR (0x18) > > +#define MCHP_OTPC_ISR (0x1C) > > +#define MCHP_OTPC_ISR_COERR BIT(13) > > #define MCHP_OTPC_HR (0x20) > > #define MCHP_OTPC_HR_SIZE GENMASK(15, 8) > > #define MCHP_OTPC_DR (0x24) > > +#define MCHP_OTPC_BAR (0x30) > > +#define MCHP_OTPC_CAR (0x34) > > +#define MCHP_OTPC_UHC0R (0x50) > > +#define MCHP_OTPC_UHC1R (0x54) > > +#define MCHP_OTPC_UID0R (0x60) > > +#define MCHP_OTPC_UID1R (0x64) > > +#define MCHP_OTPC_UID2R (0x68) > > +#define MCHP_OTPC_UID3R (0x6C) > > +#define MCHP_OTPC_WPMR (0xE4) > > +#define MCHP_OTPC_WPSR (0xE8) > > Are all these used in driver? Not all, but some. What are you implying? Only add register definitions actually used in the driver? Why? Those register offsets won't change, but helped us when debugging. Debug code (e.g. register dump) is not part of the patch series. Greets Alex > > > > > #define MCHP_OTPC_NAME "mchp-otpc" > > #define MCHP_OTPC_SIZE (11 * 1024)