From: Conor Dooley <conor@kernel.org>
To: Heiko Stuebner <heiko@sntech.de>
Cc: mturquette@baylibre.com, sboyd@kernel.org, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org,
linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org
Subject: Re: [PATCH v3 1/5] dt-bindings: clocks: add binding for gated-fixed-clocks
Date: Wed, 28 Aug 2024 16:43:54 +0100 [thread overview]
Message-ID: <20240828-throwing-gigahertz-739c6e5cfe84@spud> (raw)
In-Reply-To: <20240828101503.1478491-2-heiko@sntech.de>
[-- Attachment #1: Type: text/plain, Size: 986 bytes --]
On Wed, Aug 28, 2024 at 12:14:59PM +0200, Heiko Stuebner wrote:
> In contrast to fixed clocks that are described as ungateable, boards
> sometimes use additional oscillators for things like PCIe reference
> clocks, that need actual supplies to get enabled and enable-gpios to be
> toggled for them to work.
>
> This adds a binding for such oscillators that are not configurable
> themself, but need to handle supplies for them to work.
>
> In schematics they often can be seen as
>
> ----------------
> Enable - | 100MHz,3.3V, | - VDD
> | 3225 |
> GND - | | - OUT
> ----------------
>
> or similar. The enable pin might be separate but can also just be tied
> to the vdd supply, hence it is optional in the binding.
>
> Signed-off-by: Heiko Stuebner <heiko@sntech.de>
With Rob's fix,
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
Think the current name is more clear about what this is, thanks.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2024-08-28 15:53 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-28 10:14 [PATCH v3 0/5] Binding and driver for gated-fixed-clocks Heiko Stuebner
2024-08-28 10:14 ` [PATCH v3 1/5] dt-bindings: clocks: add binding " Heiko Stuebner
2024-08-28 13:37 ` Rob Herring
2024-08-28 15:43 ` Conor Dooley [this message]
2024-08-28 10:15 ` [PATCH v3 2/5] clk: clk-gpio: update documentation for gpio-gate clock Heiko Stuebner
2024-08-28 11:37 ` Diederik de Haas
2024-08-28 10:15 ` [PATCH v3 3/5] clk: clk-gpio: use dev_err_probe for gpio-get failure Heiko Stuebner
2024-08-28 10:15 ` [PATCH v3 4/5] clk: clk-gpio: add driver for gated-fixed-clocks Heiko Stuebner
2024-08-28 18:30 ` Stephen Boyd
2024-09-05 22:48 ` Heiko Stübner
2024-09-06 23:02 ` Stephen Boyd
2024-08-28 10:15 ` [PATCH v3 5/5] arm64: dts: rockchip: fix the pcie refclock oscillator on Rock 5 ITX Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240828-throwing-gigahertz-739c6e5cfe84@spud \
--to=conor@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mturquette@baylibre.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox