From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B1710C54E71 for ; Wed, 28 Aug 2024 10:15:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To:Cc: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=CB6BO/KLb4RXq0NQixkj5jR5dZS0zY9MFbOR0+McABQ=; b=BnQ+A8Aw5WRdr0znABDpcuVSH0 xznHku5M0tPVu0eVlk/chjYAud7EEezxLkNLxaw1DzKpbMWJ1JKGUmeNFRAopTgkVk4eT9jl0px8s cYDU/7l/z+0lmHiy1H0z34PTL/uQFZISkwTkM8YFsV2E670P0udttkKLtr8STvkuU0UnjCaJ7VmgR gJTtj7XWRG/PWeEe7AbAWxnt2SewrXK4IxV/q7nTibh4JWq9Z7PjxcOt7HjwVijBI6wqPyFkx/641 nV4mmR3IL72h6Wlg+ZT/VngxoDw3EbTj2mpQsQKBQMHBNlQw83TLmdPD1FwWWlOgaJNWnTRsz1Z0g UXCyYvEQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sjFha-0000000EsKh-14TJ; Wed, 28 Aug 2024 10:14:58 +0000 Received: from relay2-d.mail.gandi.net ([2001:4b98:dc4:8::222]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sjFgj-0000000Es9X-2Wud for linux-arm-kernel@lists.infradead.org; Wed, 28 Aug 2024 10:14:07 +0000 Received: by mail.gandi.net (Postfix) with ESMTPSA id 3C92840006; Wed, 28 Aug 2024 10:14:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1724840041; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=CB6BO/KLb4RXq0NQixkj5jR5dZS0zY9MFbOR0+McABQ=; b=JrshnpENn0+8kCxDPw+vOidiPhzUcXXxucnC4nGtiyuMRWQidOL3DVsxiasc3vXZAwp7B4 ew2l+EBphQqvvPq1Dunr2Ct/olGkJG2cjbyKTzCvHAeXMlUZPOOG97soXRXRPsLJ0Akx0X eCKbfO9xYw6SOFggoIG70At4MjJ5CRAXOZpqWKL6dNEvd6Pm8fIbCuMxhhf3RcgYTS3w2K E6zmQcXPVI4E8tXnNmB7eqFE+77qXR+MYOSQn4wUN0szD+lFZ9R0mWxRG8dOjbE9T5Y9ec Jaln9w4t/Z2bHbqgkbc9U1A5YUN1GORqMR8PY3cNOHOR391NqdjmaUMqbu7w/Q== Date: Wed, 28 Aug 2024 12:14:00 +0200 From: Alexandre Belloni To: claudiu beznea , nicolas.ferre@microchip.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, mturquette@baylibre.com, sboyd@kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org Subject: Re: [PATCH 3/3] ARM: dts: microchip: Use SCKC_{TD, MD}_SLCK IDs for clk32k clocks Message-ID: <2024082810140092b1c3d7@mail.local> References: <20240826173116.3628337-1-claudiu.beznea@tuxon.dev> <20240826173116.3628337-4-claudiu.beznea@tuxon.dev> <8ae724e3-f467-4df4-b8cc-f03489bd0f35@tuxon.dev> <20240828-chivalry-brunch-7e21bd12b7fa@thorsis.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240828-chivalry-brunch-7e21bd12b7fa@thorsis.com> X-GND-Sasl: alexandre.belloni@bootlin.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240828_031406_119767_68124099 X-CRM114-Status: GOOD ( 26.84 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 28/08/2024 09:07:05+0200, Alexander Dahl wrote: > Hello Claudiu, > > Am Mon, Aug 26, 2024 at 08:42:10PM +0300 schrieb claudiu beznea: > > > > > > On 26.08.2024 20:31, Claudiu Beznea wrote: > > > Use the newly introduced macros instead of raw number. With this device > > > tree code is a bit easier to understand. > > > > > > Signed-off-by: Claudiu Beznea > > > --- > > > arch/arm/boot/dts/microchip/sam9x60.dtsi | 18 +++++++++--------- > > > arch/arm/boot/dts/microchip/sama7g5.dtsi | 16 ++++++++-------- > > > 2 files changed, 17 insertions(+), 17 deletions(-) > > > > > > diff --git a/arch/arm/boot/dts/microchip/sam9x60.dtsi b/arch/arm/boot/dts/microchip/sam9x60.dtsi > > > index 04a6d716ecaf..eeda277e684f 100644 > > > --- a/arch/arm/boot/dts/microchip/sam9x60.dtsi > > > +++ b/arch/arm/boot/dts/microchip/sam9x60.dtsi > > > @@ -560,7 +560,7 @@ tcb0: timer@f8008000 { > > > #size-cells = <0>; > > > reg = <0xf8008000 0x100>; > > > interrupts = <17 IRQ_TYPE_LEVEL_HIGH 0>; > > > - clocks = <&pmc PMC_TYPE_PERIPHERAL 17>, <&clk32k 0>; > > > + clocks = <&pmc PMC_TYPE_PERIPHERAL 17>, <&clk32k SCKC_MD_SLCK>; > > > > Actually, looking again at it, I don't know if it worth as we use numbers > > directly also for other PMC clock IDs. > > I think in this case it is worth it. The macros you added are more > like the already existing PMC_MCK et al. macros for PMC_TYPE_CORE and > do essentially the same thing in driver code working as somewhat > arbitrary array index, without relation to SoC internals. > > The PMC clock IDs on the other hand are for PMC_TYPE_PERIPHERAL and > are that long list in the Peripheral Identifiers table and correspond > to the SoC internal IDs, which are not used in the same way. > > So from my point of view, the patch series is valuable and should be > further worked on. > I agree with this. > Greets > Alex > > > Sorry for the noise, > > Claudiu Beznea > > > > > > -- Alexandre Belloni, co-owner and COO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com