From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A59BCC54ED1 for ; Wed, 28 Aug 2024 11:41:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:CC:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=WHidzx9hkGROCHhuKZARBqdGMwVAMnyTXFGOZlH9G7s=; b=uYzfaJGu/xUrwSL90Orb4KQYqB MWIqZ0lkTU49sxTPFDCvZboxlj9W7n84K9NF+8+NXtb4b4vdpURQETLm5ByzXEQ6lS0fL4QKJ8ejy 4UU8tMTMWwXQgpXwvnetU4S+3/Af40qgmP9wQp89ug/WfIe32HkHUf7/PCCkdCBGFwi2Sx4OVqNcE Kkv+WTT8UBIRui0hy3RAfOii48CDeGXeOJ2r7oBEF+jrhGzL+rOPEn+2iWEe/pab9PX5W5cxW+ILD UQ5SyizJPcBpgPbEa7cjjKsjq5ZC6O2XX6oK4NVGgcBcpDrX/p4+QqGy7LsrI4EKTAfLqN7aaTYHf C61Agw7A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sjH2r-0000000FBJA-1ivm; Wed, 28 Aug 2024 11:41:01 +0000 Received: from fllv0016.ext.ti.com ([198.47.19.142]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sjH22-0000000FBAd-0YvK for linux-arm-kernel@lists.infradead.org; Wed, 28 Aug 2024 11:40:11 +0000 Received: from lelv0266.itg.ti.com ([10.180.67.225]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 47SBe6tq114076; Wed, 28 Aug 2024 06:40:06 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1724845206; bh=WHidzx9hkGROCHhuKZARBqdGMwVAMnyTXFGOZlH9G7s=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=YbinkGXp+/+nmsePGQErzntJu+R2quk+x5Y6rR+BevTMw4jyOktgC+aefgsFnBe9r wsrRx8euiiUq/79aimwv3zHL1LMUFbEqnelfP/EnyP9hguyawhqKjbeVYn9QR9J6yA Yqljja/3jyM5L4V2OHugTMoKClOqH9KZZGrwDtXI= Received: from DFLE115.ent.ti.com (dfle115.ent.ti.com [10.64.6.36]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 47SBe62x062141 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 28 Aug 2024 06:40:06 -0500 Received: from DFLE114.ent.ti.com (10.64.6.35) by DFLE115.ent.ti.com (10.64.6.36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Wed, 28 Aug 2024 06:40:06 -0500 Received: from lelvsmtp6.itg.ti.com (10.180.75.249) by DFLE114.ent.ti.com (10.64.6.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Wed, 28 Aug 2024 06:40:06 -0500 Received: from localhost (uda0133052.dhcp.ti.com [128.247.81.232]) by lelvsmtp6.itg.ti.com (8.15.2/8.15.2) with ESMTP id 47SBe6iV025132; Wed, 28 Aug 2024 06:40:06 -0500 Date: Wed, 28 Aug 2024 06:40:06 -0500 From: Nishanth Menon To: Beleswar Padhi CC: , , , , , , , , , , , Subject: Re: [PATCH v3 1/2] arm64: dts: ti: k3-j722s-main: Add R5F and C7x remote processor nodes Message-ID: <20240828114006.c6jasbkvdmrgvfrb@uniquely> References: <20240828112713.2668526-1-b-padhi@ti.com> <20240828112713.2668526-2-b-padhi@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20240828112713.2668526-2-b-padhi@ti.com> X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240828_044010_253719_23A4AECE X-CRM114-Status: UNSURE ( 7.68 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 16:57-20240828, Beleswar Padhi wrote: [...] > + main_r5fss0_core0: r5f@78400000 { > + compatible = "ti,am62-r5f"; > + reg = <0x78400000 0x00008000>, > + <0x78500000 0x00008000>; > + reg-names = "atcm", "btcm"; > + ti,sci = <&dmsc>; > + ti,sci-dev-id = <262>; > + ti,sci-proc-ids = <0x04 0xff>; > + resets = <&k3_reset 262 1>; > + firmware-name = "j722s-main-r5f0_0-fw"; > + ti,atcm-enable = <1>; > + ti,btcm-enable = <1>; > + ti,loczrama = <1>; https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/dts-coding-style.rst#n117 Please keep the dts coding style for vendor prefix and generic properties in mind. resets and firmware-name are generic properties. -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D