From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7483FC54FA6 for ; Wed, 28 Aug 2024 12:43:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Subject:CC:To: From:Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=R322qnMYGbR+dDyCB7G5ygpV/dJfxJv2H2dyY9v2KGA=; b=yFsH/8oq3oCGtzDFVkUDPobEeg Di4idH6UA/sfiobrBEd6FIS0/7lTIv53UdHZjDfVfLievw/+iYOoJYwV4mEQ7qfZ6gH8iwzAeYfMI RJ67sT8mXQhVbr1ymwVepLPqmfx9hEVSITQUQ0YtfFHElOKIkIAEOakZdRcNXC5kV13BlIBi2Xdu0 jzPmLrFL7xAr5WZ8+M4HlknYNjZfQOX1tiCW+VZZuMr1W3KBuAxjt8PrpxiYp1YmEGPFFkxFbGoKQ YSwgixeD6LxsqDkzkhTLwl9ocQien3wESbowcEdS6Qbrav6dFg2tf8Nup2zidg2+TEoZ3JClaxNyI SpxENf6g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sjI0g-0000000FMb7-2rMN; Wed, 28 Aug 2024 12:42:50 +0000 Received: from frasgout.his.huawei.com ([185.176.79.56]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sjHyS-0000000FLuD-2yt8 for linux-arm-kernel@lists.infradead.org; Wed, 28 Aug 2024 12:40:34 +0000 Received: from mail.maildlp.com (unknown [172.18.186.31]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4Wv3nq3QgKz6K98q; Wed, 28 Aug 2024 20:37:03 +0800 (CST) Received: from lhrpeml500005.china.huawei.com (unknown [7.191.163.240]) by mail.maildlp.com (Postfix) with ESMTPS id ADF3C140740; Wed, 28 Aug 2024 20:40:21 +0800 (CST) Received: from localhost (10.203.177.66) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Wed, 28 Aug 2024 13:40:21 +0100 Date: Wed, 28 Aug 2024 13:40:20 +0100 From: Jonathan Cameron To: Jinjie Ruan CC: , , , , , , , , , , , , , , , , , , , , , , , , , , , , , Subject: Re: [PATCH net-next v2 05/13] net: phy: Fix missing of_node_put() for leds Message-ID: <20240828134020.00005d99@Huawei.com> In-Reply-To: <20240828032343.1218749-6-ruanjinjie@huawei.com> References: <20240828032343.1218749-1-ruanjinjie@huawei.com> <20240828032343.1218749-6-ruanjinjie@huawei.com> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.203.177.66] X-ClientProxiedBy: lhrpeml100001.china.huawei.com (7.191.160.183) To lhrpeml500005.china.huawei.com (7.191.163.240) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240828_054032_922034_AC06A73C X-CRM114-Status: UNSURE ( 7.20 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 28 Aug 2024 11:23:35 +0800 Jinjie Ruan wrote: > The call of of_get_child_by_name() will cause refcount incremented > for leds, if it succeeds, it should call of_node_put() to decrease > it, fix it. > > Fixes: 01e5b728e9e4 ("net: phy: Add a binding for PHY LEDs") > Signed-off-by: Jinjie Ruan Reviewed-by: Jonathan Cameron