From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 75D84C54F32 for ; Wed, 28 Aug 2024 12:49:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Subject:CC:To: From:Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=oyxqeHu8vldQO5nP8U9bYF9USYwQiM7UDAyDWN/UoWQ=; b=4SkPwZfACoOfKopN+IxQotHNYD UDF0KpLgr9QCcryS/+zjxKczQxqsf9kT3WPIW4+y1Z8gFroj++pI2vl/rUIF9LXysQqoNRfKZ4gLY +x5TE1l/NRBGTazg4FB/oX1BIIzBZ6xSCJkhjJS1D4j7TZENIBY8lBCsx4UlmCSYcswmB1VfPGVF0 UUW7Ed+t56mfXaTJJ9O4BgPaPHJ55D/Mvswd0cceVve+jR/6InAoCI5dW8+MFpZq9aJElxdA+XNLJ J8gQEFQKuH5/V83JXiG9nBN2Z/mCSfwyzcV8rr5650OvuL/IEWsB0ZnHWDj9qRP7cu8/JgXPY9IFh byD4Rtog==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sjI6e-0000000FNwR-424N; Wed, 28 Aug 2024 12:49:00 +0000 Received: from frasgout.his.huawei.com ([185.176.79.56]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sjI3y-0000000FNRs-25Jj for linux-arm-kernel@lists.infradead.org; Wed, 28 Aug 2024 12:46:15 +0000 Received: from mail.maildlp.com (unknown [172.18.186.31]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4Wv3vd4st5z6K6HL; Wed, 28 Aug 2024 20:42:05 +0800 (CST) Received: from lhrpeml500005.china.huawei.com (unknown [7.191.163.240]) by mail.maildlp.com (Postfix) with ESMTPS id 106911400D1; Wed, 28 Aug 2024 20:46:07 +0800 (CST) Received: from localhost (10.203.177.66) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Wed, 28 Aug 2024 13:46:06 +0100 Date: Wed, 28 Aug 2024 13:46:05 +0100 From: Jonathan Cameron To: Jinjie Ruan CC: , , , , , , , , , , , , , , , , , , , , , , , , , , , , , Subject: Re: [PATCH net-next v2 07/13] net: mdio: mux-mmioreg: Simplified with scoped function Message-ID: <20240828134605.00000d23@Huawei.com> In-Reply-To: <20240828032343.1218749-8-ruanjinjie@huawei.com> References: <20240828032343.1218749-1-ruanjinjie@huawei.com> <20240828032343.1218749-8-ruanjinjie@huawei.com> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.203.177.66] X-ClientProxiedBy: lhrpeml100001.china.huawei.com (7.191.160.183) To lhrpeml500005.china.huawei.com (7.191.163.240) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240828_054614_707655_A3C06593 X-CRM114-Status: UNSURE ( 5.65 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 28 Aug 2024 11:23:37 +0800 Jinjie Ruan wrote: > Avoids the need for manual cleanup of_node_put() in early exits > from the loop by using for_each_available_child_of_node_scoped(). > > Signed-off-by: Jinjie Ruan Looks fine, though maybe driver would also benefit from dev_err_probe() Reviewed-by: Jonathan Cameron