From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 227D2C636EA for ; Wed, 28 Aug 2024 17:01:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:CC:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=yCu3p6k7jYdq0sC+LK3TcbQgS0qZfJnmMCl1ItmtqWY=; b=DW8eos1+z5ze2E5pIiVzA0qOC3 gSzXD2l/HP8ITGUNN0oq39AUNi8JKTEiEa7Lzm4bjVZBmgebEqzyGjIT8KzBayJi5/AmkhyuMn3Hh /cCL8ayz1eceAsybcgS0VmkN6KCZvt2KZkG5/y2BhnsaqAElQxJaBftZE3XksQTcrJsN5Gi/eAGUq miPvWaO7s9DGXpE/0F7cPGjnQGUF07B0N5Br7eXWStbIyH35HH9OYXjrQ5DaRtyjmAKZ7RvplTPrA tcM9isrUeZH4eOq/XCuK//p24LjSt5ldgKdLiMprmQbMOqhDj5slaxErnXozImMDoKd1SNeHYVlwR z2LgRFfw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sjM2v-0000000GHVZ-0bo2; Wed, 28 Aug 2024 17:01:25 +0000 Received: from fllv0016.ext.ti.com ([198.47.19.142]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sjM1Y-0000000GH4l-3JBI for linux-arm-kernel@lists.infradead.org; Wed, 28 Aug 2024 17:00:02 +0000 Received: from fllv0034.itg.ti.com ([10.64.40.246]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 47SGxsN0069441; Wed, 28 Aug 2024 11:59:54 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1724864394; bh=yCu3p6k7jYdq0sC+LK3TcbQgS0qZfJnmMCl1ItmtqWY=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=mYG2kvwEsWVFGSsze5CkQuYVi1FPhMb3OlNpGHDRxM8g1rfCiuG9DMLyepJponl7a 0dFkbIT+/xmUpWklW1QNp4pFTpcXNYUOXYxCO8+O9oRfcPEYsDrYz3ud5qE4dOz95h j/P0+e5uimIsNIeYFB7MCrvJj3/6HmUGA9LnACYs= Received: from DFLE114.ent.ti.com (dfle114.ent.ti.com [10.64.6.35]) by fllv0034.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 47SGxsFn004449 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 28 Aug 2024 11:59:54 -0500 Received: from DFLE113.ent.ti.com (10.64.6.34) by DFLE114.ent.ti.com (10.64.6.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Wed, 28 Aug 2024 11:59:54 -0500 Received: from lelvsmtp6.itg.ti.com (10.180.75.249) by DFLE113.ent.ti.com (10.64.6.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Wed, 28 Aug 2024 11:59:54 -0500 Received: from localhost (uda0133052.dhcp.ti.com [128.247.81.232]) by lelvsmtp6.itg.ti.com (8.15.2/8.15.2) with ESMTP id 47SGxsHE027680; Wed, 28 Aug 2024 11:59:54 -0500 Date: Wed, 28 Aug 2024 11:59:54 -0500 From: Nishanth Menon To: Robert Nelson CC: , , , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Vignesh Raghavendra , Andrew Davis , Jai Luthra , Roger Quadros , Siddharth Vadapalli , Jared McArthur , Jason Kridner , Deepak Khatri , Drew Fustini Subject: Re: [PATCH v3 2/2] arm64: dts: ti: Add k3-am67a-beagley-ai Message-ID: <20240828165954.4d2uf65khni7rlr5@uncurled> References: <20240822170440.265055-1-robertcnelson@gmail.com> <20240822170440.265055-2-robertcnelson@gmail.com> <20240824184415.o7ehjqm523igqbbi@cornhusk> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240828_100000_989755_652E7E09 X-CRM114-Status: UNSURE ( 9.60 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 11:34-20240828, Robert Nelson wrote: [...] > > /builds/RobertCNelson/arm64-multiplatform/KERNEL/arch/arm64/boot/dts/ti/k3-am67a-beagley-ai.dtb: > leds: led-0:linux,default-trigger: 'oneOf' conditional failed, one > must be fixed: > 'off' is not one of ['backlight', 'default-on', 'heartbeat', > 'disk-activity', 'disk-read', 'disk-write', 'timer', 'pattern', > 'audio-micmute', 'audio-mute', 'bluetooth-power', 'flash', > 'kbd-capslock', 'mtd', 'nand-disk', 'none', 'torch', 'usb-gadget', > 'usb-host', 'usbport'] > > I guess, 'none' is close... off/etc.. > I'd just suggest to drop the property since you already use heartbeat. Also function = is alternate option, if you choose to go down the road of enabling a function https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/include/dt-bindings/leds/common.h#n77 https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/leds/common.yaml#n83 -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D