From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 95848C83F2D for ; Thu, 29 Aug 2024 16:14:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=JppiVnOb8D4RuK886ThO4SYxjIGVu3hLmvqW1/E/tAw=; b=u07cPwK8HPg/MS5rk2vJYV5zEL DRtLSzlKS1FWLvXU39NrYiu5/utYzae8QXMODL8GHp5aUNotiP9r1yLRtCntWYySBZLdbNWx3Uq0P vEzOKenU/I7l7kd36FGrDPLv/ZYRc0JEcJU271+aKUwBbv21lblCe5udc4UYx7GPclUgAPJHWrPBp jUa8GC8RRc00AFMvxlsC2lvQFM+gPH5KRaW+qRGfDU61jXnRqjSk2Pvlo37ieVNECxUDZYBSqJ0OY COF7qv+1VcVQ4dwvJTTYj4fw4uogWq/N79ZHrpRHqxGVp18+1YHuPx6aaRROxfNLH5mNNH7jC+kTQ vqPYNxyg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sjhmr-00000002m6s-29zt; Thu, 29 Aug 2024 16:14:17 +0000 Received: from nyc.source.kernel.org ([2604:1380:45d1:ec00::3]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sjhlz-00000002lrz-34um for linux-arm-kernel@lists.infradead.org; Thu, 29 Aug 2024 16:13:25 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id D3906A44269; Thu, 29 Aug 2024 16:13:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A1A34C4CEC9; Thu, 29 Aug 2024 16:13:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1724948002; bh=VGs68PfNrarA1kIV4Q3+GneWz66NTWvS2Qg0QV3mnCU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=P0o6GpUbGD8sx9Ok+rGfmiYrhBg1C8TXmFjhyjkMA7w11yo0dbTIMwgb2dvsXVEDN fI/uAwfcMRI3Af0V1SVibi1nfGb/mwmuuJ5T7vF++fwmcOzejd7qBdP/daQof3hDPy cHNOzX4rvs5YwCxM3iPJxZt+Y/ojAbgPu/bdXrmOT6btLM4V0NY8s4kVgcv1jAYefT 896z7BUQjUHsXIeqBwfh24UViZxlNTw3JzQBKETcC42qhZpf3Uml5sdzMNWAxK2I80 eqErcgTGwbSyYMlYfaN8YTWKOia+4GDEPyn/1vt6aiFwxAu8XzkFM7BS0tHPKRFGNe 1ck9tWIH71Ktw== Date: Thu, 29 Aug 2024 17:13:17 +0100 From: Conor Dooley To: Lukasz Majewski Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , linux-sound@vger.kernel.org, Pengutronix Kernel Team , Fabio Estevam , devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Liam Girdwood , Mark Brown Subject: Re: [PATCH v4] ASoC: dt-bindings: Convert mxs-saif.txt to fsl,imx28-saif.yaml (imx28 saif) Message-ID: <20240829-power-traction-01344edc5fed@spud> References: <20240829102625.3128645-1-lukma@denx.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="flucLSha+vknQX0y" Content-Disposition: inline In-Reply-To: <20240829102625.3128645-1-lukma@denx.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240829_091324_132766_0BB9BC4C X-CRM114-Status: GOOD ( 17.01 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --flucLSha+vknQX0y Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Aug 29, 2024 at 12:26:25PM +0200, Lukasz Majewski wrote: > The 'fsl,imx28-saif' compatible has already the mxs-saif.txt description. > This patch converts (and removes it) this file to fsl,imx28-saif.yaml. >=20 > Changes for the mxs-saif.txt: > - Adds 'clocks', '#clock-cells' and '#sound-dai-cells' properties > - Provide device description >=20 > Signed-off-by: Lukasz Majewski >=20 > --- > Changes for v4: > - Change file name to match compatible (fsl,imx28-saif.yaml) > - Remove 'saif0' and 'saif1' labels as those are not needed in the > example node Hmm, what you've done is not quite what I was suggesting. I was saying that either you should remove one of the examples entirely, or merge the two examples retaining the only saif0 label. With that sorted, Reviewed-by: Conor Dooley Cheers, Conor. > +examples: > + - | > + saif@80042000 { > + compatible =3D "fsl,imx28-saif"; > + reg =3D <0x80042000 2000>; > + #sound-dai-cells =3D <0>; > + interrupts =3D <59>; > + dmas =3D <&dma_apbx 4>; > + dma-names =3D "rx-tx"; > + #clock-cells =3D <0>; > + clocks =3D <&clks 53>; > + }; > + saif@80046000 { > + compatible =3D "fsl,imx28-saif"; > + reg =3D <0x80046000 2000>; > + #sound-dai-cells =3D <0>; > + interrupts =3D <58>; > + dmas =3D <&dma_apbx 5>; > + dma-names =3D "rx-tx"; > + clocks =3D <&clks 53>; > + fsl,saif-master =3D <&saif0>; > + }; --flucLSha+vknQX0y Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZtCeHQAKCRB4tDGHoIJi 0rbiAP9Y7W5F+NPN2JmNH/14k5YrCbeB7Ma9GtGh5Mu/5AE86wD/bYJfDPmUwzxq VnrDiy27sjxu9PeSf8eyLVHCH6mTRgA= =Ftps -----END PGP SIGNATURE----- --flucLSha+vknQX0y--