From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E583EC83F2E for ; Thu, 29 Aug 2024 14:56:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=e5eClhLZpOKGunPdU6b8hnQxT41wDa1dXgFv4W/tO/w=; b=OjNBF4FMBOz7jOpKAa3xClfFIz Okw0AhkX404ph2P7KSKvz99IXPMagovM9RnSkaediw9Co75jJghjyHvjWNfa88O8YhvmFN0H8u4vu c1O8q7H6W2u9qMteIdT0Al8omcytb6oEchNIyVPzx2cKv+BZOdqLeXGxBek/xT3Sgy50PEj+xIPlK 9jIzNfJfMnMmTgC/jQatag0yhegLu3Wye5iVfXfcVet+dg2Kji5KKjVmAb/78A2kGcSmNn8gbx9YY /08t2ZIKeTbb+BUAF7z/AHOzwONnvzfiQQzYipv8EtwmIYOZmG1dnd6SYi3ET4f+lHSr712ciqwC2 ED1vX1Xw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sjgZt-00000002VV1-1kwZ; Thu, 29 Aug 2024 14:56:49 +0000 Received: from nyc.source.kernel.org ([147.75.193.91]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sjgXl-00000002Uqi-2MWF for linux-arm-kernel@lists.infradead.org; Thu, 29 Aug 2024 14:54:38 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 96DC4A4410C; Thu, 29 Aug 2024 14:54:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DB876C4CEC3; Thu, 29 Aug 2024 14:54:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1724943276; bh=94sqycuEg7LZE3IfoAS/UYJHpdhV1CbtJdmFG3iWS1U=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Y/hg1oCh+Ij6W4jgfibIcNLBH2y6qwXWngwcUcGr4b3eYryJduYRVobwRt6oxc42R H6f1zYxHYCrS7niInBO5J0AjCy8ecFWqNseOf/cmogScebBhrEna8OTyktEs8yEjrJ 175Q0V6vAr2G+DQqxPtZGIdZNe+qIREnbKSj8qwgAhz5FNxTFMhz5yEsTHAxdoLS3i hI3xZDeYhtA/QPLEtmCboawwvUP6HlSbtj5geHqzV/za/0DVs4yDF5mOzTCBINi1xj x4gwu3HxpENBZpP5e0AkTwn4UUpF/Eb8me1jX0fvP6HHtr585Fv4o2jsG3R7yMmQpr Zda3hB26yi+pQ== Date: Thu, 29 Aug 2024 09:54:34 -0500 From: Rob Herring To: Kuninori Morimoto Cc: Daniel Vetter , David Airlie , Helge Deller , Jaroslav Kysela , Laurent Pinchart , Liam Girdwood , Maarten Lankhorst , Mark Brown , Mauro Carvalho Chehab , Maxime Ripard , Michal Simek , Saravana Kannan , Takashi Iwai , Thomas Zimmermann , Tomi Valkeinen , devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-fbdev@vger.kernel.org, linux-media@vger.kernel.org, linux-omap@vger.kernel.org, linux-sound@vger.kernel.org, Sakari Ailus Subject: Re: [PATCH v4 9/9] media: xilinx-tpg: use new of_graph functions Message-ID: <20240829145434.GA465065-robh@kernel.org> References: <87bk1d2pvt.wl-kuninori.morimoto.gx@renesas.com> <87y14h1b9f.wl-kuninori.morimoto.gx@renesas.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87y14h1b9f.wl-kuninori.morimoto.gx@renesas.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240829_075437_689484_B7F776E6 X-CRM114-Status: GOOD ( 18.46 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Aug 28, 2024 at 05:12:28AM +0000, Kuninori Morimoto wrote: > Now we can use new port related functions for port parsing. Use it. > > Signed-off-by: Kuninori Morimoto > Reviewed-by: Tomi Valkeinen > --- > drivers/media/platform/xilinx/xilinx-tpg.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/media/platform/xilinx/xilinx-tpg.c b/drivers/media/platform/xilinx/xilinx-tpg.c > index e05e528ffc6f7..a25f216b2513c 100644 > --- a/drivers/media/platform/xilinx/xilinx-tpg.c > +++ b/drivers/media/platform/xilinx/xilinx-tpg.c > @@ -13,6 +13,7 @@ > #include > #include > #include > +#include > #include > #include > > @@ -744,7 +745,7 @@ static int xtpg_parse_of(struct xtpg_device *xtpg) > } > This function is looping over port nodes, why don't you make it use for_each_of_graph_port()? > if (nports == 0) { > - endpoint = of_get_next_child(port, NULL); > + endpoint = of_graph_get_next_port_endpoint(port, NULL); > if (endpoint) > has_endpoint = true; > of_node_put(endpoint); > -- > 2.43.0 >