From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AAAE8C83F2D for ; Thu, 29 Aug 2024 15:44:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Q5qESUGpBEQ5QVawNNJ587e9vZ4fA+55sLarjd9/QIc=; b=eU0vxG7KZ+aznBAMzO1XeGQJ/Y utQ/6w0IhLufTMrnr7kjbGm9mhgStYGXJ0NNOaphj8dfzDZ1Q5q0PjSj2izWdwVTxnj8IqtDSeDLV k0fohEmP/+WYoKq78gNxWYYm104ICzPoT4mBIiIxt/Oi3RyNTYo2KfsRBNy1SLG3L6pp4eY4BM9/Q UDb57NQmKV4q8cKi6uVPGi6It7VQW7ys963x12nnx7hcirqNyCOLl719Jk9x1WVwM7qA3bAuHBvDi +a2szZlhQSsbB9v7JtuhwbyzkCSZ1BnDG8oKihq7nOWNHeiAQEDxycsWQv9uWgyIJqZgPIAq1b6ef cWOKnRaA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sjhJu-00000002ffn-01ew; Thu, 29 Aug 2024 15:44:22 +0000 Received: from nyc.source.kernel.org ([2604:1380:45d1:ec00::3]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sjhIt-00000002fQh-3V8C for linux-arm-kernel@lists.infradead.org; Thu, 29 Aug 2024 15:43:21 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 03BECA441D9; Thu, 29 Aug 2024 15:43:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 66BADC4CEC3; Thu, 29 Aug 2024 15:43:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1724946198; bh=F7RTQPtDOnRRFJUgG6erlEaYNrW5gyiWnn8+Dsb7Ze4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=WfMY30LC/MTR7UoIwYXTcquRzuZHFJKHbCE8dQm/pgWNLwbXbhdScutPCbrQGXNMM p1aS2YIjyBgIEGx1Y3y6u6Rp/8OugXX3duxygDxmn55nCTzUMSSCjebvCivN6+jTum pVHXy6F6i2nwZbdky/30D0BV9PTH8Tj2x6ppFH90oYD9fQmHMWG8JmXAh4qG8gB9+w GuDOEAQbCOVMyS7gbv+j12rayTdjt7VJdyg8LsNyjav1f3tkO0jQdnWnVIr2d769Ve jLKLR+zB3xGUbgCYUjeum+nAUs2MrwwelPppMrfJo81h72SmdprSVNYUMBRxi+606h 0uEGmag9ZB4rg== Date: Thu, 29 Aug 2024 10:43:16 -0500 From: Rob Herring To: Kuninori Morimoto Cc: Daniel Vetter , David Airlie , Helge Deller , Jaroslav Kysela , Laurent Pinchart , Liam Girdwood , Maarten Lankhorst , Mark Brown , Mauro Carvalho Chehab , Maxime Ripard , Michal Simek , Saravana Kannan , Takashi Iwai , Thomas Zimmermann , Tomi Valkeinen , devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-fbdev@vger.kernel.org, linux-media@vger.kernel.org, linux-omap@vger.kernel.org, linux-sound@vger.kernel.org, Sakari Ailus Subject: Re: [PATCH v4 8/9] fbdev: omapfb: use new of_graph functions Message-ID: <20240829154316.GC465065-robh@kernel.org> References: <87bk1d2pvt.wl-kuninori.morimoto.gx@renesas.com> <87zfox1b9m.wl-kuninori.morimoto.gx@renesas.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87zfox1b9m.wl-kuninori.morimoto.gx@renesas.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240829_084320_297922_5B9B10B0 X-CRM114-Status: GOOD ( 23.14 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Aug 28, 2024 at 05:12:22AM +0000, Kuninori Morimoto wrote: > Now we can use new port related functions for port parsing. Use it. > > Signed-off-by: Kuninori Morimoto > --- > drivers/video/fbdev/omap2/omapfb/dss/dpi.c | 3 +- > drivers/video/fbdev/omap2/omapfb/dss/dss-of.c | 66 ------------------- > drivers/video/fbdev/omap2/omapfb/dss/dss.c | 9 +-- > drivers/video/fbdev/omap2/omapfb/dss/sdi.c | 3 +- > include/video/omapfb_dss.h | 8 --- > 5 files changed, 9 insertions(+), 80 deletions(-) > > diff --git a/drivers/video/fbdev/omap2/omapfb/dss/dpi.c b/drivers/video/fbdev/omap2/omapfb/dss/dpi.c > index 7c1b7d89389aa..395b1139a5ae7 100644 > --- a/drivers/video/fbdev/omap2/omapfb/dss/dpi.c > +++ b/drivers/video/fbdev/omap2/omapfb/dss/dpi.c > @@ -20,6 +20,7 @@ > #include > #include > #include > +#include > #include > #include > > @@ -845,7 +846,7 @@ int dpi_init_port(struct platform_device *pdev, struct device_node *port) > if (!dpi) > return -ENOMEM; > > - ep = omapdss_of_get_next_endpoint(port, NULL); > + ep = of_graph_get_next_port_endpoint(port, NULL); > if (!ep) > return 0; > > diff --git a/drivers/video/fbdev/omap2/omapfb/dss/dss-of.c b/drivers/video/fbdev/omap2/omapfb/dss/dss-of.c > index 4040e247e026e..efb7d2e4ce85d 100644 > --- a/drivers/video/fbdev/omap2/omapfb/dss/dss-of.c > +++ b/drivers/video/fbdev/omap2/omapfb/dss/dss-of.c > @@ -15,72 +15,6 @@ > > #include "dss.h" > > -struct device_node * > -omapdss_of_get_next_port(const struct device_node *parent, > - struct device_node *prev) > -{ > - struct device_node *port = NULL; > - > - if (!parent) > - return NULL; > - > - if (!prev) { > - struct device_node *ports; > - /* > - * It's the first call, we have to find a port subnode > - * within this node or within an optional 'ports' node. > - */ > - ports = of_get_child_by_name(parent, "ports"); > - if (ports) > - parent = ports; > - > - port = of_get_child_by_name(parent, "port"); > - > - /* release the 'ports' node */ > - of_node_put(ports); > - } else { > - struct device_node *ports; > - > - ports = of_get_parent(prev); > - if (!ports) > - return NULL; > - > - do { > - port = of_get_next_child(ports, prev); > - if (!port) { > - of_node_put(ports); > - return NULL; > - } > - prev = port; > - } while (!of_node_name_eq(port, "port")); > - > - of_node_put(ports); > - } > - > - return port; > -} > -EXPORT_SYMBOL_GPL(omapdss_of_get_next_port); > - > -struct device_node * > -omapdss_of_get_next_endpoint(const struct device_node *parent, > - struct device_node *prev) > -{ > - struct device_node *ep = NULL; > - > - if (!parent) > - return NULL; > - > - do { > - ep = of_get_next_child(parent, prev); > - if (!ep) > - return NULL; > - prev = ep; > - } while (!of_node_name_eq(ep, "endpoint")); > - > - return ep; > -} > -EXPORT_SYMBOL_GPL(omapdss_of_get_next_endpoint); > - > struct device_node *dss_of_port_get_parent_device(struct device_node *port) > { > struct device_node *np; > diff --git a/drivers/video/fbdev/omap2/omapfb/dss/dss.c b/drivers/video/fbdev/omap2/omapfb/dss/dss.c > index d814e4baa4b33..5cab317011eeb 100644 > --- a/drivers/video/fbdev/omap2/omapfb/dss/dss.c > +++ b/drivers/video/fbdev/omap2/omapfb/dss/dss.c > @@ -26,6 +26,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -922,7 +923,7 @@ static int dss_init_ports(struct platform_device *pdev) > if (parent == NULL) > return 0; of_graph_get_next_port() handles parent==NULL, so you can drop this check. And the other cases. Rob