From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8E6F5C87FC8 for ; Thu, 29 Aug 2024 16:54:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Owner; bh=NMDCbzoZUqxHvI44Gj1G0rH6mjO1S+Nzwy/SPVJOW8A=; b=LH7ibB4JhH1fDf SbH+No9hT4vMHoYkYXdjLjwg8aZ/QbqqS6jSNjS6t3iyzwKjgD0RhTvAjULyz/Tksz+0qXYtDCZE+ ik0xfQQuRiuYn1PV2GjqTiB/aMqh0gHCl+9BlMspTTM9SFmWzglmNa4Jso3BNEAcM8sYEhXYelIRk lfcXyfd02g5zYh082AHhHbc75/1sEQsVMnCBX9FpB7wHh3tscc3o6QdMNLFpOnen/XNCdfuxaQn+F QWM0yiMIJKeCF7KaC2t7xw7W6O3aKSocdXGf9YYKV13yz94s/P8MzGBAAKErgwQ9kPsRXmBjWZoLv 1/FwxnOWS5lhtsv1XRAw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sjiQ1-00000002uqQ-0wUQ; Thu, 29 Aug 2024 16:54:45 +0000 Received: from nyc.source.kernel.org ([147.75.193.91]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sjiOp-00000002uRd-2duL for linux-arm-kernel@lists.infradead.org; Thu, 29 Aug 2024 16:53:33 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 79BFBA414B1; Thu, 29 Aug 2024 16:53:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B02BEC4CEC1; Thu, 29 Aug 2024 16:53:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1724950410; bh=7lGLL0XhrxlPC1QZEvRqoSTWUVqnsrXOpUkvm7E/9d4=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=P2KPzdKVTqEVMDVIYblA2mTa0t+ZjXsZQy30AWbBeaFdZ8aK21f12ysTr3hIWwd5R 4LUmkxL+zEeeGtSHvEtwHIQwyaoWrAoIk0kqN/1qHSR0u5/VnMgtrd6+0plwCh40A5 n23ApadZodBHpnro8Qh7i880GGyhHBJnK70Hov1Rt8lCnGmZUKj2jhldiRbjTlXaDj SpSfi2lnsSXebJtxpDtuUlmwWCrysYblN0zzl0sgrDfGP4wVBrlAZC/Dvj0+aQfiy3 Kv6mMYGyGKDp5uuWxPly266+GXcp2eqGrHMvooFHIj/iogs1FqxkSewWprUVg8YJHL 4GRIKqVAjMmPw== Date: Thu, 29 Aug 2024 11:53:22 -0500 From: Bjorn Helgaas To: Siddharth Vadapalli Cc: bhelgaas@google.com, lpieralisi@kernel.org, kw@linux.com, manivannan.sadhasivam@linaro.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, vigneshr@ti.com, kishon@kernel.org, linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, srk@ti.com Subject: Re: [PATCH v4 2/2] PCI: j721e: Enable ACSPCIE Refclk if "ti,syscon-acspcie-proxy-ctrl" exists Message-ID: <20240829165322.GA66640@bhelgaas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240829105316.1483684-3-s-vadapalli@ti.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240829_095331_768674_F48254F6 X-CRM114-Status: GOOD ( 11.02 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Aug 29, 2024 at 04:23:16PM +0530, Siddharth Vadapalli wrote: > The ACSPCIE module is capable of driving the reference clock required by > the PCIe Endpoint device. It is an alternative to on-board and external > reference clock generators. Enabling the output from the ACSPCIE module's > PAD IO Buffers requires clearing the "PAD IO disable" bits of the > ACSPCIE_PROXY_CTRL register in the CTRL_MMR register space. > > Add support to enable the ACSPCIE reference clock output using the optional > device-tree property "ti,syscon-acspcie-proxy-ctrl". > > Signed-off-by: Siddharth Vadapalli Looks good to me, thanks! > v3: > https://lore.kernel.org/r/20240827055548.901285-3-s-vadapalli@ti.com/ > Changes since v3: > - Rebased patch on next-20240829. Doesn't hurt to do it, but no need to rebase for PCI patches. We apply everything to -rc1 anyway.